[Bug 256090] New: Patch review for control-center2
https://bugzilla.novell.com/show_bug.cgi?id=256090 Summary: Patch review for control-center2 Product: openSUSE 10.3 Version: Alpha 2 Platform: Other OS/Version: Other Status: NEW Severity: Normal Priority: P5 - None Component: GNOME AssignedTo: jpr@novell.com ReportedBy: maw@novell.com QAContact: qa@suse.de CC: maw@novell.com Patch100: control-center2-po-update.patch Patch12: size.patch (this patch is dead simple, can't remember why it was a problem) Patch15: control-center-default-applications-ftp+news.patch (this patch was commented out (by someone else)) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=256090 jpr@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|jpr@novell.com |rodrigo@novell.com -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=256090 JP Rosevear <jpr@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|Normal |Critical -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=256090#c1 --- Comment #1 from JP Rosevear <jpr@novell.com> 2007-07-27 11:18:42 MST --- also control-center-seamonkey.patch which depended on control-center-default-applications-ftp+news.patch -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=256090#c2 --- Comment #2 from Rodrigo Moya <rodrigo@novell.com> 2007-08-02 03:11:37 MST --- The FTP+News patch was not accepted upstream because of this: "I've multiple times said no to a patch that adds a default ftp uri handler in the gnome-vfs gconf schemas. If there is a registered application specified for a uri that tends to override all application type mappings, so if you click on a pdf file on a ftp share in nautilus it tends to open gftp instead of evince." from http://bugzilla.gnome.org/show_bug.cgi?id=426638 as for news, who really needs that? How many people open news: URLs from a browser? There is only the system-proxy patch that might be useful (and accepted) upstream, but it's too SuSE-specific and we might need to write distro-specific code for detecting the system proxy settings. So this is on hold until 2.21/2.22 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=256090#c3 JP Rosevear <jpr@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sbrabec@novell.com --- Comment #3 from JP Rosevear <jpr@novell.com> 2007-08-02 11:51:39 MST --- The seamonkey patch is obsolete, its in the xml list now. The proxy patch I expect to be suse specific. new+ftp was because of bug 113104. What about size.patch and control-center2-po-update.patch? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=256090#c4 --- Comment #4 from Stanislav Brabec <sbrabec@novell.com> 2007-08-03 02:32:09 MST --- control-center-default-applications-ftp+news.patch: It was rejected yesterday by upstream. If we want this feature (and as upstream bug shows, that many people don't like forced ftp:// opening in nautilus, we have to maintain it forever). It's my patch and I can try to port it. When we will modify ftp://, it's easy to add (or not add) news:// as well. control-center-seamonkey.patch: Adds support for seamonkey to URL handler lists. Applying depends on previous patch, because it modifies ftp:// and news:// as well. control-center2-po-update.patch: Most probably obsolete. It was po update for SLES10. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=256090#c5 --- Comment #5 from Rodrigo Moya <rodrigo@novell.com> 2007-08-03 08:43:50 MST --- Seamonkey support in the XML files was added months ago, from our patch. As for news, I still need a convincing argument (that is, lots of people use it) to add it upstream. As for cc2-po-update.patch, both format strings are now fixed upstream. So, this leaves us with the system proxy patch only, which I'll rewrite to be less SuSE-specific and add it upstream for 2.21 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=256090#c6 JP Rosevear <jpr@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|rodrigo@novell.com |sbrabec@novell.com Severity|Critical |Normal --- Comment #6 from JP Rosevear <jpr@novell.com> 2007-08-03 10:02:44 MST --- All cleaned up now except for news+ftp patch. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=256090#c7 Stanislav Brabec <sbrabec@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO Info Provider| |jpr@novell.com --- Comment #7 from Stanislav Brabec <sbrabec@novell.com> 2007-10-01 09:49:06 MST --- What do you think about news+ftp patch? Should we diverge from upstream and allow users to simply change ftp:// to anything else than Nautilus? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=256090#c8 --- Comment #8 from Rodrigo Moya <rodrigo@novell.com> 2007-10-02 05:48:27 MST --- I think the reason given by upstream is good enough, so unless there are lots of our users wanting this feature, I would not diverge. For news though, I guess we can keep the patch and send it upstream again. Even if just a few people use it, I think it might make sense to have it. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=256090#c9 --- Comment #9 from Stanislav Brabec <sbrabec@novell.com> 2007-10-02 06:14:58 MST --- They rejected it as well in the same bug. It is still possible to configure it by a gconf-editor or by using schemas included to the package providing news:// (AFAIK only thunderbird can do it). I guess that redirecting ftp:// from Nautilus to web browser use more people. I issued a new bug for gnome-vfs to at least document the behavior, if there will be no GUI: http://bugzilla.gnome.org/show_bug.cgi?id=482284 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=256090#c10 Stephan Kulow <coolo@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |NEW Info Provider|jpr@novell.com | --- Comment #10 from Stephan Kulow <coolo@novell.com> 2007-11-10 09:56:59 MST --- I don't see what info from JP is pending, so I assume NEEDINFO is outdated -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=256090#c11 Stanislav Brabec <sbrabec@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO Info Provider| |jpr@novell.com --- Comment #11 from Stanislav Brabec <sbrabec@novell.com> 2007-11-21 10:19:28 MST --- The NEEDINFO was intended: JP, do we want to maintain the news+ftp patches outside upstream or drop them from the GUI? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=256090 User jpr@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=256090#c12 JP Rosevear <jpr@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |NEW Info Provider|jpr@novell.com | --- Comment #12 from JP Rosevear <jpr@novell.com> 2008-01-28 07:17:21 MST --- They are there because of customer requests so we need to keep them. Talk to Rodrigo to see if he can take them upstrea.m -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=256090 User rodrigo@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=256090#c13 --- Comment #13 from Rodrigo Moya <rodrigo@novell.com> 2008-01-28 09:20:12 MST --- ftp+news patch was not accepted upstream because of conflicts with FTP in Nautilus and the default application for FTP. For news, it's a little used feature, so the default applications capplet does not need to get crowded with all this. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=256090 User sbrabec@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=256090#c14 --- Comment #14 from Stanislav Brabec <sbrabec@novell.com> 2008-01-28 10:02:28 MST --- No, there are no conflicts with Nautilus, at least not in time I ported the patch last time. The default is not Nautilus, but "File type based", which opens directories in Nautilus. Upstream rejected it saying "File type based open is the only correct solution." My patch allows to keep original behavior or force selected application. See http://bugzilla.gnome.org/attachment.cgi?id=88586&action=view for screenshot and these bugs for discussion: GUI: http://bugzilla.gnome.org/show_bug.cgi?id=426638 backend: http://bugzilla.gnome.org/show_bug.cgi?id=482284 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=256090 User federico@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=256090#c16 Federico Mena Quintero <federico@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |federico@novell.com Status|NEW |NEEDINFO Info Provider| |sbrabec@novell.com --- Comment #16 from Federico Mena Quintero <federico@novell.com> 2008-05-28 12:42:14 MDT --- Should we mark this bug as INVALID, or is there something else left to do? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=256090 User rodrigo@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=256090#c17 --- Comment #17 from Rodrigo Moya <rodrigo@novell.com> 2008-05-29 05:14:09 MDT --- I would like to have the solution being accepted upstream, so we probably should start a thread on the gnomecc-list about this, to get to a solution. Stanislav, could you start the thread please ? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=256090 User sbrabec@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=256090#c18 Stanislav Brabec <sbrabec@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |NEW Info Provider|sbrabec@novell.com | --- Comment #18 from Stanislav Brabec <sbrabec@novell.com> 2008-05-29 05:27:05 MDT --- Well. First the backend bug http://bugzilla.gnome.org/show_bug.cgi?id=482284 should be accepted in gnome-vfs. I guess, that after move to gvfs, these parts of the code will be rewritten. I am not developing gnomecc and my proposal was already rejected in past. Please start the discussion, and I can subscribe the list. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=256090 User rodrigo@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=256090#c19 --- Comment #19 from Rodrigo Moya <rodrigo@novell.com> 2008-05-29 05:52:00 MDT --- Well, I disagree with the patch also, so it's hard for me to start the discussion to try to convince them about something I am not convinced about :-) That's why I ask you to start the discussion, since you wrote the patch. If you still want me to start it, please let me know when you're subscribed to the list, and I'll start it Although, as you say, we would need to have the backend part for gvfs -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=256090 User sbrabec@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=256090#c20 --- Comment #20 from Stanislav Brabec <sbrabec@novell.com> 2008-05-29 06:25:29 MDT --- The gnome-vfs patch does not provide any GUI. It only documents current behavior, to make help visible in gconf-editor. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=256090 User casualprogrammer@gmail.com added comment https://bugzilla.novell.com/show_bug.cgi?id=256090#c21 Casual J. Programmer <casualprogrammer@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |casualprogrammer@gmail.com --- Comment #21 from Casual J. Programmer <casualprogrammer@gmail.com> 2008-06-11 10:29:07 MDT --- So is there any consensus yet on what needs to be done ? This has been filed 2007-03-20 and is still going strong. It doesn't look like a solution is _really_ needed by anybody living.. Please decide on a solution ( Flip a coin ), or simply close as WONTFIX -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=256090 User sbrabec@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=256090#c22 Stanislav Brabec <sbrabec@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #22 from Stanislav Brabec <sbrabec@novell.com> 2008-09-18 05:43:19 MDT --- gnome-control-center: control-center2-po-update.patch: Temporary patch, dropped long time ago. size.patch: The patch is not present any more. control-center-default-applications-ftp+news.patch: The patch was created upon request of our customer several years ago. Upstream rejected the patch. It does not apply any more. Dropped completely from sources. gnome-vfs2: gnome-vfs-url_handler_ftp.patch, gnome-vfs-url_handler_news.patch:Patches only improve usability and don't cause any problems. gnome-vfs is deprecated and will not be develop any more. Let's keep it there. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com