[Bug 1136198] New: opensuse/leap KIWI image has no <history> element
http://bugzilla.opensuse.org/show_bug.cgi?id=1136198 Bug ID: 1136198 Summary: opensuse/leap KIWI image has no <history> element Classification: openSUSE Product: openSUSE Distribution Version: Leap 15.1 Hardware: Other OS: Other Status: NEW Severity: Normal Priority: P5 - None Component: Containers Assignee: containers-bugowner@suse.de Reporter: swagner@suse.com QA Contact: qa-bugs@suse.de Found By: --- Blocker: --- Tumbleweed has a <history> element:
https://build.opensuse.org/package/view_file/openSUSE:Containers:Tumbleweed/...
<history author="Fabian Vogt <fvogt@suse.com>">openSUSE Tumbleweed %OS_VERSION_ID% Base Container</history>
$ docker history opensuse/tumbleweed IMAGE CREATED CREATED BY SIZE > COMMENT 9940bd785cff 2 days ago KIWI 9.17.37 122MB > openSUSE Tumbleweed 20190521 Base Container
The Leap 15 image doesn't have a history element:
https://build.opensuse.org/package/view_file/openSUSE:Leap:15.1/opensuse-lea...
resulting is no comment at all:
$ docker history opensuse/leap:15.1 IMAGE CREATED CREATED BY SIZE COMMENT 58e409bb9cad 41 hours ago umoci config 0B <missing> 41 hours ago KIWI 9.17.15 104MB
Which leads to derived container without any reference to the origin:
$ docker history registry.opensuse.org/filesystems/ceph/nautilus/images/rook/ceph:1.0.2.1 IMAGE CREATED CREATED BY SIZE COMMENT 25667589e8ab 24 hours ago KIWI 9.17.15 482MB Derive the image <missing> 3 months ago umoci config 0B <missing> 3 months ago KIWI 9.17.13 105MB
-- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1136198 http://bugzilla.opensuse.org/show_bug.cgi?id=1136198#c1 David Cassany <dcassany@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcassany@suse.com, | |fvogt@suse.com Flags| |needinfo?(fvogt@suse.com) --- Comment #1 from David Cassany <dcassany@suse.com> --- I am not sure about the motivations to not include the `<history>` element in Leap 15.1 (adding Fabian fvogt@suse.com regarding that), in any case since KIWI 9.17.10 there is support for the history element. Thus from KIWI POV there could be support in Leap 15.1 images. However, as it can be noted from the `docker history` commands copied in this issue, leap images include some more empty spurious entries with empty size and missing image. This happens because of the `umoci` tool being used, in Leap 15.1 there is umoci 0.3.1 which does not include some improvements regarding how history is being handled, however in tumbleweed there is umoci 0.4.4 which includes those history improvements and lets KIWI create nicer and cleaner history entries. Probably this is why <history> is not being included in leap 15.1 (Fabian? Any clue regarding that?). In addition note that references from base image can be found in labels IIRC. There should be something like "org.opensuse.base.disturl=DISTURL_TO_BASE_IMAGE". The DISTURL parameter is a url pointing to the project that built the base image in OBS, note sure if this covers your needs. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1136198 http://bugzilla.opensuse.org/show_bug.cgi?id=1136198#c2 Fabian Vogt <fvogt@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(fvogt@suse.com) | --- Comment #2 from Fabian Vogt <fvogt@suse.com> --- (In reply to David Cassany from comment #1)
I am not sure about the motivations to not include the `<history>` element in Leap 15.1 (adding Fabian fvogt@suse.com regarding that), in any case since KIWI 9.17.10 there is support for the history element. Thus from KIWI POV there could be support in Leap 15.1 images.
IIRC it also depends on specific skopeo or umoci versions and as currently the SLE 15 and Leap 15 images are meant to be as close as possible, adding <history/> wasn't possible yet. If it meanwhile is in SLE 15 and Leap 15.0, I can add it.
However, as it can be noted from the `docker history` commands copied in this issue, leap images include some more empty spurious entries with empty size and missing image. This happens because of the `umoci` tool being used, in Leap 15.1 there is umoci 0.3.1 which does not include some improvements regarding how history is being handled, however in tumbleweed there is umoci 0.4.4 which includes those history improvements and lets KIWI create nicer and cleaner history entries. Probably this is why <history> is not being included in leap 15.1 (Fabian? Any clue regarding that?).
In addition note that references from base image can be found in labels IIRC. There should be something like "org.opensuse.base.disturl=DISTURL_TO_BASE_IMAGE". The DISTURL parameter is a url pointing to the project that built the base image in OBS, note sure if this covers your needs.
Yes, the existing labels are best option. The history entry is (for now) just for convenience and doesn't carry any additional information. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1136198 http://bugzilla.opensuse.org/show_bug.cgi?id=1136198#c4 --- Comment #4 from Sebastian Wagner <swagner@suse.com> --- (In reply to Fabian Vogt from comment #2)
(In reply to David Cassany from comment #1)
However, as it can be noted from the `docker history` commands copied in this issue, leap images include some more empty spurious entries with empty size and missing image. This happens because of the `umoci` tool being used, in Leap 15.1 there is umoci 0.3.1 which does not include some improvements regarding how history is being handled, however in tumbleweed there is umoci 0.4.4 which includes those history improvements and lets KIWI create nicer and cleaner history entries. Probably this is why <history> is not being included in leap 15.1 (Fabian? Any clue regarding that?).
In addition note that references from base image can be found in labels IIRC. There should be something like "org.opensuse.base.disturl=DISTURL_TO_BASE_IMAGE". The DISTURL parameter is a url pointing to the project that built the base image in OBS, note sure if this covers your needs.
Yes, the existing labels are best option. The history entry is (for now) just for convenience and doesn't carry any additional information.
Thanks for looking into this! I agree that this is mostly a convenience thing, nevertheless important as users may look into the history. Especially as it is so prominently documented in https://en.opensuse.org/Building_derived_containers -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1136198 Ludwig Nussel <lnussel@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - None |P3 - Medium -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1136198 Fabian Vogt <fvogt@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |swagner@suse.com Flags| |needinfo?(swagner@suse.com) -- You are receiving this mail because: You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply@novell.com