[Bug 523793] New: circuslinux-1.0.3-1259.2: possible memory leak
http://bugzilla.novell.com/show_bug.cgi?id=523793 Summary: circuslinux-1.0.3-1259.2: possible memory leak Classification: openSUSE Product: openSUSE 11.2 Version: Factory Platform: All OS/Version: openSUSE 11.1 Status: NEW Severity: Normal Priority: P5 - None Component: Other AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: dcb314@hotmail.com QAContact: qa@suse.de Found By: --- I just had a look at factory package circuslinux-1.0.3-1259.2 For source code file circuslinux-1.0.3/circuslinux.c, around line 3431 is the source code for the function open_option_file. I notice the following code filename = (char *) malloc(sizeof(char) * (strlen(home) + strlen("/.circuslinux") + 1)); but no matching call to free. This looks like a memory leak to me. Suggest code rework by adding a call to free near the end of the routine. Maybe #ifdef LINUX free( filename); #endif return fi; would be enough. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=523793 Marcus Meissner <meissner@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|bnc-team-screening@forge.pr |prusnak@novell.com |ovo.novell.com | -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=523793 Pavol Rusnak <prusnak@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|circuslinux-1.0.3-1259.2: |JJ: |possible memory leak |circuslinux-1.0.3-1259.2: | |possible memory leak -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=523793 User rguenther@novell.com added comment http://bugzilla.novell.com/show_bug.cgi?id=523793#c1 --- Comment #1 from Richard Guenther <rguenther@novell.com> 2009-10-17 08:54:35 MDT --- David, in case the issues are not introduced by a patch local to openSUSE please report the issues upstream. Packagers, please do not add openSUSE-local patches to fix this kind of errors but forward the bugs upstream and close the bugs as RESOLVED UPSTREAM. Note that it is perfectly fine to have "resource leaks" at the end of a program as the kernel will clean up for you. Manually freeing them only increases binary size and runtime. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=523793 https://bugzilla.novell.com/show_bug.cgi?id=523793#c2 Pavol Rusnak <prusnak@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |WONTFIX --- Comment #2 from Pavol Rusnak <prusnak@novell.com> 2010-11-12 19:38:39 CET --- wontfix -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply@novell.com