[Bug 717934] New: bash completions don't add a space anymore
https://bugzilla.novell.com/show_bug.cgi?id=717934 https://bugzilla.novell.com/show_bug.cgi?id=717934#c0 Summary: bash completions don't add a space anymore Classification: openSUSE Product: openSUSE 11.4 Version: Final Platform: Other OS/Version: Other Status: NEW Severity: Minor Priority: P5 - None Component: Basesystem AssignedTo: werner@suse.com ReportedBy: matz@suse.com QAContact: qa@suse.de Found By: Development Blocker: --- This is a behavioral change from 11.3 to 11.4 . Try this: # ls /etc/inp<TAB> it will complete to: # ls /etc/inputrc _ (_ indicates the cursor position, i.e. the above adds a space after it successfully completed to a single item). This assumes that /etc/inputrc is the only completion for the above prefix, otherwise try with some other file which is unique. Now try the same with less: # less /etc/inp<TAB> .. completes to ... # less /etc/inputrc_ i.e. the cursor will be placed directly after the last character, which is the same behaviour as if multiple completions would exist. Indeed pressing <TAB> again results in a new call to the completion routines, of course with the same single result. I find this change very annoying because in former times I could simply continue typing with the next file names, and now I have to enter the space myself. What's worse is, that I took the space after a filename as indication that this was infact the only matching completion. That it's now missing makes me always wonder if there are other completions, hence I need to press <TAB> again to see that, no, in fact this is really the only one. It breaks typing flow. I see that the reason for this change is the unconditional addition of "-o nospace" to the _file and _dir variables. That seems to have been necessary because _exp_ now calls _compreply_ which puts it's own '/' at the end of directories (which it had to do because $HO<TAB> would otherwise be incorrectly expanded). So we can't use -o filenames anymore. But if we were simply adding spaces always this would breaks the flow of typing "/et<TAB>" which would be completed to "/etc/ _", making it impossible to continue typing the filename in a directory. I will attach a patch which goes back to the 11.3 behaviour for non-directory files only implementing what I think we should unconditionally do.
From looking at aaa_base-extras in the current factory tree it reads as if the 11.4 behaviour is still current in 12.1.
-- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=717934 https://bugzilla.novell.com/show_bug.cgi?id=717934#c1 --- Comment #1 from Michael Matz <matz@suse.com> 2011-09-14 22:43:47 UTC --- Created an attachment (id=450852) --> (http://bugzilla.novell.com/attachment.cgi?id=450852) Proposed fix Werner, please consider adding this patch. It locally disables the nospace option for the current completion in flight when there's only on entry in the reply, and that entry is a non-directory file-system object. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=717934 https://bugzilla.novell.com/show_bug.cgi?id=717934#c2 Dr. Werner Fink <werner@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #2 from Dr. Werner Fink <werner@suse.com> 2011-09-15 11:04:20 UTC --- Thanks for the patch, added and submitted to factory -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=717934 https://bugzilla.novell.com/show_bug.cgi?id=717934#c3 --- Comment #3 from Bernhard Wiedemann <bwiedemann@suse.com> 2011-09-16 10:41:23 CEST --- This is an autogenerated message for OBS integration: This bug (717934) was mentioned in https://build.opensuse.org/request/show/82205 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply@novell.com