[Bug 223258] New: Wrong implementation of "skip language dialog" feature
https://bugzilla.novell.com/show_bug.cgi?id=223258 Summary: Wrong implementation of "skip language dialog" feature Product: openSUSE 10.2 Version: RC 1 Platform: Other OS/Version: Other Status: NEW Severity: Normal Priority: P5 - None Component: Installation AssignedTo: jsuchome@novell.com ReportedBy: locilka@novell.com QAContact: jsrain@novell.com I've tried to install openSUSE 10.2 when I had selected Language different to en_US, then the fist stage installation failed. Next thing I've done, was starting the installation again. My recently-selected language stayed pre-selected - actually, the dialog is skipped with message in y2log: y2milestone("Skipping language dialog, Language changed to %1",preselected); (select_language.ycp client) What is wrong - in this case, License agreement still shows [Back] button enabled. If I click on the back button, the entire installation is somehow aborted. Well, License agreement dialog doesn't know that the previous step is disabled. Also the entire installation process doesn't know that (that's why "Language" is still visible between installation steps even if it doesn't make sense). Solution: select_language.ycp client should * set some accessible variable in, e.g., Installation module, that the language step has been disabled. * touch some file in /var/lib/YaST2/ * something similar to inform other modules and clients that the step is disabled... -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=223258 jsuchome@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Wrong implementation of |First dialog has back button enabled |"skip language dialog" | |feature | -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=223258 jsuchome@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO Info Provider| |locilka@novell.com ------- Comment #1 from jsuchome@novell.com 2006-11-23 00:51 MST ------- I prefer adding the same check which is in language module to the licence client (or maybe better to installation.ycp, which than calls licence client with proper button arguments?) instead of creating new API. The check is: if ( Stage::initial () && ProductFeatures::GetBooleanFeature ("globals", "skip_language_dialog") && Language::preselected != "en_US") ) Alternatively, I could create something like global boolean Language::selection_skipped, but it would only be set in the above situation anyway. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=223258 aj@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |ASSIGNED Info Provider|locilka@novell.com | ------- Comment #3 from aj@novell.com 2006-11-23 01:52 MST ------- The fix from comment #1 looks fine to me and I'll accept it for RC2. A more sophisticated solution would be something for 10.3. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=223258 jsuchome@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jsuchome@novell.com AssignedTo|jsuchome@novell.com |locilka@novell.com Status|ASSIGNED |NEW ------- Comment #4 from jsuchome@novell.com 2006-11-23 02:04 MST ------- Lukas, return back to me after 10.2. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=223258 locilka@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED ------- Comment #5 from locilka@novell.com 2006-11-23 02:25 MST ------- Despite the fact I don't like duplication of code on more places, you are right that it's better to do it this way for 10.2 and do it better for next product :) I'll fix that in the yast2-installation today. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=223258 locilka@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|locilka@novell.com |jsuchome@novell.com Status|ASSIGNED |NEW ------- Comment #6 from locilka@novell.com 2006-11-23 04:42 MST ------- - Disabling [Back] button in License Agreement dialog when the previous (Language) dialog has been skipped (223258). - yast2-installation-2.14.15 Patch has been tested with result -> passed ;) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=223258 jsuchome@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |LATER ------- Comment #7 from jsuchome@novell.com 2006-11-23 04:46 MST ------- LATER for a while -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=223258 jsuchome@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|LATER | ------- Comment #8 from jsuchome@novell.com 2006-12-04 06:31 MST ------- wake up -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=223258 jsuchome@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|jsuchome@novell.com |locilka@novell.com Status|REOPENED |NEW ------- Comment #9 from jsuchome@novell.com 2006-12-04 06:35 MST ------- yast2-country-2.13.45 (SLES10SP1) and yast2-country-2.15.0 (STABLE) contains global variable Language::selection_skipped which is set to true exactly when the criteria from comment #1 are met. Reassigning to Lukas to adapt yast2-installation. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=223258 locilka@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|Normal |Enhancement Status|NEW |RESOLVED Component|Installation |Installation Product|openSUSE 10.2 |openSUSE 10.3 Resolution| |FIXED Version|RC 1 |unspecified ------- Comment #10 from locilka@novell.com 2006-12-04 10:17 MST ------- Enhancement for 10.3 fixed in yast2-installation 2.15.0. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
participants (1)
-
bugzilla_noreply＠novell.com