[Bug 478513] New: iwconfig wlanX nick command breaks ifup
https://bugzilla.novell.com/show_bug.cgi?id=478513 Summary: iwconfig wlanX nick command breaks ifup Classification: openSUSE Product: openSUSE 11.1 Version: Final Platform: All OS/Version: openSUSE 11.1 Status: NEW Severity: Major Priority: P5 - None Component: Network AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: Larry.Finger@lwfinger.net QAContact: qa@suse.de Found By: --- User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.0.6) Gecko/2009012700 SUSE/3.0.6-0.1.2 Firefox/3.0.6 With the development of cfg80211 and its replacement of the old wireless extension implementation, the command "iwconfig wlanX nick blah-blah" is no longer implemented; however the following scripts still use it: /etc/sysconfig/network/scripts/ifdown-wireless /etc/sysconfig/network/scripts/ifup-wireless /etc/sysconfig/network/scripts/ifstatus-wireless When the /sbin/ifup wlan0 command is given, it returns the following command 'iwconfig wlan0 nick <host-name>' returned Error for wireless request "Set Nickname" (8B1C) : SET failed on device wlan0 ; Operation not supported. interface wlan0 is not up The fix is to remove the line "nick $WIRELESS_NICK" from the 3 scripts indicated above. Reproducible: Always Steps to Reproduce: 1. Configure the use of if-up for network devices. 2. Issue an ifup wlan0 command. 3. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=478513 Pavol Rusnak <prusnak@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hschaa@novell.com AssignedTo|bnc-team-screening@forge.pr |mt@novell.com |ovo.novell.com | -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=478513 User hschaa@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=478513#c1 --- Comment #1 from Helmut Schaa <hschaa@novell.com> 2009-02-23 08:03:35 MST --- Agreed. Marius, we should simply drop the call to "iwconfig wlan0 nick xxx" for 11.2 and later. Not sure what to do with 11.1 and SLED11. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=478513 User mt@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=478513#c2 Marius Tomaschewski <mt@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO Info Provider| |hschaa@novell.com --- Comment #2 from Marius Tomaschewski <mt@novell.com> 2009-02-24 03:59:45 MST --- I'd say we should not set WIRELESS_NICK to the hostname when it is empty; or is this required for a driver to always provide a nick? My fix would look like this at the moment: --- ifup-wireless.11.1 2009-01-27 14:53:26.000000000 +0100 +++ ifup-wireless 2009-02-24 11:50:58.000000000 +0100 @@ -277,14 +277,15 @@ # Mode need to be first : some settings apply only in a specific mode ! run_iw_tool config mode $WIRELESS_MODE # This is a bit hackish, but should do the job right... - if [ -n "$WIRELESS_ESSID" -o -n "$WIRELESS_MODE" ] ; then - test -z "$WIRELESS_NICK" && WIRELESS_NICK=`/bin/hostname` - fi + #if [ -n "$WIRELESS_ESSID" -o -n "$WIRELESS_MODE" ] ; then + # test -z "$WIRELESS_NICK" && WIRELESS_NICK=`/bin/hostname` + #fi # Regular stuff... while read OPT ARG; do run_iw_tool config $OPT "$ARG" done <<-EOL nick $WIRELESS_NICK nwid $WIRELESS_NWID freq $WIRELESS_FREQ channel $WIRELESS_CHANNEL Note, that the run_iw_tool function skips all calls with empty $ARG. Helmut, OK? I'll apply this fix to my queue at home:mtomaschewski:11.1/sysconfig on build.opensuse.org and let you know when this fix is available as test rpm. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=478513 User hschaa@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=478513#c3 Helmut Schaa <hschaa@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |NEW Info Provider|hschaa@novell.com | --- Comment #3 from Helmut Schaa <hschaa@novell.com> 2009-02-24 04:14:41 MST --- (In reply to comment #2)
I'd say we should not set WIRELESS_NICK to the hostname when it is empty; or is this required for a driver to always provide a nick?
No driver should require the nickname to be set. If one does we have to fix the driver instead ;)
Helmut, OK?
Fine with me. However, I would also agree on dropping everything related to the nickname stuff. That would make ifup-wireless slightly less complex. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=478513 User Larry.Finger@lwfinger.net added comment https://bugzilla.novell.com/show_bug.cgi?id=478513#c4 --- Comment #4 from Larry Finger <Larry.Finger@lwfinger.net> 2009-02-24 08:27:27 MST --- If I had a vote, dropping the nickname would get it. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=478513 User mt@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=478513#c5 --- Comment #5 from Marius Tomaschewski <mt@novell.com> 2009-02-24 10:52:30 MST --- Created an attachment (id=275078) --> (https://bugzilla.novell.com/attachment.cgi?id=275078) Proposed patch -- don't set nick by default -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=478513 User mt@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=478513#c6 Marius Tomaschewski <mt@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #6 from Marius Tomaschewski <mt@novell.com> 2009-02-24 10:55:50 MST --- (In reply to comment #4)
If I had a vote, dropping the nickname would get it.
Well, it is maybe useless, but not invalid, so we apply it when the user explicitly sets one, but not by default (hostname) any more. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=478513 Swamp Workflow Management <swamp@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status Whiteboard| |maint:planned:update -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com