[Bug 673826] New: pam_listfile's quiet option wrong behaviour
https://bugzilla.novell.com/show_bug.cgi?id=673826 https://bugzilla.novell.com/show_bug.cgi?id=673826#c0 Summary: pam_listfile's quiet option wrong behaviour Classification: openSUSE Product: openSUSE 11.4 Version: Factory Platform: Other OS/Version: Other Status: NEW Severity: Normal Priority: P5 - None Component: Basesystem AssignedTo: mc@novell.com ReportedBy: vcizek@novell.com QAContact: qa@suse.de Found By: --- Blocker: --- This option behaves differently, than stated in manual.
From manpage:
quiet Do not treat service refusals or missing list files as errors that need to be logged. I assumed, that quiet option, doesn't need a value, but browsing through the code, all options must have values, including quiet. Next, the quiet option doesn't make it much "quiet". (eg. even when quiet=1 is specified, a missing file is logged) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=673826
https://bugzilla.novell.com/show_bug.cgi?id=673826#c1
--- Comment #1 from Vitezslav Cizek
https://bugzilla.novell.com/show_bug.cgi?id=673826
https://bugzilla.novell.com/show_bug.cgi?id=673826#c2
Vitezslav Cizek
https://bugzilla.novell.com/show_bug.cgi?id=673826
https://bugzilla.novell.com/show_bug.cgi?id=673826#c3
--- Comment #3 from Thorsten Kukuk
https://bugzilla.novell.com/show_bug.cgi?id=673826
https://bugzilla.novell.com/show_bug.cgi?id=673826#c4
Vitezslav Cizek
pam_listfile has the following code:
} else if (!strcmp(mybuf,"quiet")) { quiet = 1;
Which means the option is "quiet" and nothing else. quiet=1 or quiet=yes will not work.
But few lines obove that you can find: junk = strchr(argv[i], '='); if((junk == NULL) || (junk - argv[i]) >= (int) sizeof(mybuf)) { pam_syslog(pamh,LOG_ERR, "Bad option: \"%s\"", argv[i]); continue; } strncpy(mybuf, argv[i], LESSER(junk - argv[i], (int)sizeof(mybuf) - 1)); strncpy(myval, junk + 1, sizeof(myval) - 1); Which strips the =1 and sets mybuf to "quiet", so it does work. The (junk == NULL) test eliminates quiet option without argument. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=673826
https://bugzilla.novell.com/show_bug.cgi?id=673826#c5
Vitezslav Cizek
https://bugzilla.novell.com/show_bug.cgi?id=673826
https://bugzilla.novell.com/show_bug.cgi?id=673826#c6
Vitezslav Cizek
participants (1)
-
bugzilla_noreply@novell.com