[Bug 1226986] New: Valkey migration enables bogus valkey@basename services
https://bugzilla.suse.com/show_bug.cgi?id=1226986 Bug ID: 1226986 Summary: Valkey migration enables bogus valkey@basename services Classification: openSUSE Product: openSUSE Tumbleweed Version: Current Hardware: Other OS: openSUSE Tumbleweed Status: NEW Severity: Normal Priority: P5 - None Component: Other Assignee: screening-team-bugs@suse.de Reporter: georg.pfuetzenreuter@suse.com QA Contact: qa-bugs@suse.de Target Milestone: --- Found By: --- Blocker: --- I never had a "redis@basename" instance! Yet after todays dup to 20240624 which replaced redis with valkey-7.2.5-2.1.x86_64 the migration logic enabled these bogus services, which naturally failed during boot: ``` ~> ll /etc/systemd/system/multi-user.target.wants/valkey* lrwxrwxrwx 1 root root 39 Jun 26 08:10 '/etc/systemd/system/multi-user.target.wants/valkey@basename.service' -> '/usr/lib/systemd/system/valkey@.service' lrwxrwxrwx 1 root root 48 Jun 26 08:10 '/etc/systemd/system/multi-user.target.wants/valkey-sentinel@basename.service' -> '/usr/lib/systemd/system/valkey-sentinel@.service' ``` -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1226986 Georg Pfuetzenreuter <georg.pfuetzenreuter@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |antonio.teixeira@suse.com, | |danilo.spinella@suse.com, | |dominik@wombacher.cc, | |ngompa13@gmail.com -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1226986 https://bugzilla.suse.com/show_bug.cgi?id=1226986#c1 --- Comment #1 from Georg Pfuetzenreuter <georg.pfuetzenreuter@suse.com> --- It's still early so I might be missing something, but I think there are missing dollar signs in lines 5 and 6? https://build.opensuse.org/projects/server:database/packages/valkey/files/mi... As of revision 4 these lines look like this: ``` redisunits=(basename $(find /etc/systemd/system -maxdepth 1 -name "redis@*.service")) sentinelunits=(basename $(find /etc/systemd/system -maxdepth 1 -name "redis-sentinel@*.service")) ``` -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1226986 https://bugzilla.suse.com/show_bug.cgi?id=1226986#c2 --- Comment #2 from Georg Pfuetzenreuter <georg.pfuetzenreuter@suse.com> --- I made a patch, please check - don't have means to test myself - Redis is gone from my system. :-) https://build.opensuse.org/request/show/1183296 -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1226986 Togan Muftuoglu <toganm@dinamizm.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |toganm@dinamizm.com -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1226986 Christian Boltz <suse-beta@cboltz.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |suse-beta@cboltz.de -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1226986 Sam Azer <sam@azertech.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sam@azertech.net -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1226986 https://bugzilla.suse.com/show_bug.cgi?id=1226986#c4 --- Comment #4 from Togan Muftuoglu <toganm@dinamizm.com> --- I don't understand what this patch does? There is nothing when I ran find /etc/systemd/system -maxdepth 1 -name "redis@*.service" -execdir basename {} \; however I have redis@amavis.service and redis@spamass.service listed as links under /etc/systemd/system/multi-user.target.wants/redis@.service /etc/systemd/system/redis.target.wants/redis@.service So the above find command doesn't do anything to these. Since this is a production server, I want to sure no services will be affected. -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1226986 Victor Kulichenko <onclev@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |onclev@gmail.com -- You are receiving this mail because: You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠suse.com