[Bug 732927] New: IOTOP crashes
https://bugzilla.novell.com/show_bug.cgi?id=732927 https://bugzilla.novell.com/show_bug.cgi?id=732927#c0 Summary: IOTOP crashes Classification: openSUSE Product: openSUSE 12.1 Version: Final Platform: x86-64 OS/Version: SuSE Other Status: NEW Severity: Normal Priority: P5 - None Component: Other AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: roland@logikalsolutions.com QAContact: qa@suse.de Found By: --- Blocker: --- User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20100101 Firefox/8.0 roland@linux-853v:~> iotop Traceback (most recent call last): File "/usr/bin/iotop", line 16, in <module> main() File "/usr/lib/python2.7/site-packages/iotop/ui.py", line 563, in main main_loop() File "/usr/lib/python2.7/site-packages/iotop/ui.py", line 553, in <lambda> main_loop = lambda: run_iotop(options) File "/usr/lib/python2.7/site-packages/iotop/ui.py", line 465, in run_iotop return curses.wrapper(run_iotop_window, options) File "/usr/lib64/python2.7/curses/wrapper.py", line 43, in wrapper return func(stdscr, *args, **kwds) File "/usr/lib/python2.7/site-packages/iotop/ui.py", line 457, in run_iotop_window process_list = ProcessList(taskstats_connection, options) File "/usr/lib/python2.7/site-packages/iotop/data.py", line 373, in __init__ self.update_process_counts() File "/usr/lib/python2.7/site-packages/iotop/data.py", line 429, in update_process_counts stats = self.taskstats_connection.get_single_task_stats(thread) File "/usr/lib/python2.7/site-packages/iotop/data.py", line 158, in get_single_task_stats reply = GeNlMessage.recv(self.connection) File "/usr/lib/python2.7/site-packages/iotop/genetlink.py", line 50, in recv msg = conn.recv() File "/usr/lib/python2.7/site-packages/iotop/netlink.py", line 229, in recv raise err OSError: Netlink error: Operation not permitted (1) Reproducible: Always Steps to Reproduce: 1. just install iotop then type the command 2. 3. Actual Results: crash and burn Expected Results: should show disk usage 64-bit 12.1 final -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=732927 https://bugzilla.novell.com/show_bug.cgi?id=732927#c1 Li Bin <bili@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |bili@suse.com Resolution| |INVALID --- Comment #1 from Li Bin <bili@suse.com> 2011-11-28 09:15:38 UTC --- You need the sudo permission to run it. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=732927 https://bugzilla.novell.com/show_bug.cgi?id=732927#c2 Roland Hughes <roland@logikalsolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|INVALID | --- Comment #2 from Roland Hughes <roland@logikalsolutions.com> 2011-11-28 13:34:09 UTC --- It was never needed before. I ran this script from my own account for years. cat top_dsk.sh iotop -d8 -o -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=732927 https://bugzilla.novell.com/show_bug.cgi?id=732927#c3 Li Bin <bili@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |NEEDINFO InfoProvider| |roland@logikalsolutions.com --- Comment #3 from Li Bin <bili@suse.com> 2011-11-29 03:20:05 UTC --- Roland, It's caused by kernel's change, now it need the root permission. We can apply the upstream patch to prompt a friendly message. You can view more info from below link, is it okay? commit 635b5838e95ed85767434207e463173fd91b6040 Author: Guillaume Chazarain <guichaz@gmail.com> Date: Sat Oct 15 18:39:32 2011 +0200 Explain that iotop now requires root. https://lkml.org/lkml/2011/10/1/170 http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdif... diff --git a/iotop/ui.py b/iotop/ui.py index ef2b3a6..e8da128 100644 --- a/iotop/ui.py +++ b/iotop/ui.py @@ -458,10 +458,19 @@ def run_iotop_window(win, options): ui.run() def run_iotop(options): - if options.batch: - return run_iotop_window(None, options) - else: - return curses.wrapper(run_iotop_window, options) + try: + if options.batch: + return run_iotop_window(None, options) + else: + return curses.wrapper(run_iotop_window, options) + except OSError, e: + if e.errno == errno.EPERM: + print >> sys.stderr, e + print >> sys.stderr, ('iotop requires root or the NET_ADMIN ' + 'capability.') + sys.exit(1) + else: + raise -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=732927 https://bugzilla.novell.com/show_bug.cgi?id=732927#c4 --- Comment #4 from Li Bin <bili@suse.com> 2011-11-29 03:38:50 UTC --- http://download.opensuse.org/repositories/home:/BinLi:/branches:/openSUSE:/1... I've applied the patch and you can test the rpm. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=732927 https://bugzilla.novell.com/show_bug.cgi?id=732927#c5 Roland Hughes <roland@logikalsolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |REOPENED InfoProvider|roland@logikalsolutions.com | --- Comment #5 from Roland Hughes <roland@logikalsolutions.com> 2011-11-29 04:25:24 UTC --- (In reply to comment #4)
http://download.opensuse.org/repositories/home:/BinLi:/branches:/openSUSE:/1...
I've applied the patch and you can test the rpm.
I don't need to test it. If the patch now gracefully exits stating the program must run under root or something like that I'm fine. A stack dump is not an error handler. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=732927 https://bugzilla.novell.com/show_bug.cgi?id=732927#c6 Li Bin <bili@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |NEEDINFO InfoProvider| |maintenance@opensuse.org --- Comment #6 from Li Bin <bili@suse.com> 2011-11-29 05:02:54 UTC --- Maintenance, Could we let it in updates? Thanks! -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=732927 https://bugzilla.novell.com/show_bug.cgi?id=732927#c7 Benjamin Brunner <bbrunner@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |REOPENED InfoProvider|maintenance@opensuse.org | --- Comment #7 from Benjamin Brunner <bbrunner@suse.com> 2011-12-02 13:26:17 CET --- Bin Li could you do a submitrequest to openSUSE:12.1:Update:Test please? We'll start an update. Thanks. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=732927 https://bugzilla.novell.com/show_bug.cgi?id=732927#c8 Li Bin <bili@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |ASSIGNED AssignedTo|bnc-team-screening@forge.pr |bili@suse.com |ovo.novell.com | --- Comment #8 from Li Bin <bili@suse.com> 2011-12-05 09:10:42 UTC --- Assign it. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=732927 https://bugzilla.novell.com/show_bug.cgi?id=732927#c9 Li Bin <bili@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEEDINFO InfoProvider| |bbrunner@suse.com --- Comment #9 from Li Bin <bili@suse.com> 2011-12-05 09:12:07 UTC --- (In reply to comment #7)
Bin Li could you do a submitrequest to openSUSE:12.1:Update:Test please? We'll start an update. Thanks.
So don't need maintenance team agreement? Thanks! -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=732927 https://bugzilla.novell.com/show_bug.cgi?id=732927#c10 --- Comment #10 from Li Bin <bili@suse.com> 2011-12-05 09:15:52 UTC --- Done. 95408 State:review By:BinLi When:2011-12-05T10:14:05 submit: home:BinLi:branches:openSUSE:12.1:Update/iotop -> openSUSE:12.1:Update:Test Review by Group is new: maintenance-opensuse.org Descr: Explain that iotop now requires root(bnc#732927). -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=732927 https://bugzilla.novell.com/show_bug.cgi?id=732927#c11 Li Bin <bili@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |RESOLVED InfoProvider|bbrunner@suse.com | Resolution| |FIXED --- Comment #11 from Li Bin <bili@suse.com> 2011-12-05 09:38:10 UTC --- Accepted. Close it. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=732927 https://bugzilla.novell.com/show_bug.cgi?id=732927#c12 --- Comment #12 from Bernhard Wiedemann <bwiedemann@suse.com> 2011-12-05 11:00:10 CET --- This is an autogenerated message for OBS integration: This bug (732927) was mentioned in https://build.opensuse.org/request/show/95408 12.1 / iotop -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com