[Bug 997467] New: setup-pulseaudio script fixes
http://bugzilla.opensuse.org/show_bug.cgi?id=997467 Bug ID: 997467 Summary: setup-pulseaudio script fixes Classification: openSUSE Product: openSUSE Distribution Version: Leap 42.1 Hardware: Other OS: Other Status: NEW Severity: Normal Priority: P5 - None Component: Sound Assignee: tiwai@suse.com Reporter: marcosfrm@gmail.com QA Contact: qa-bugs@suse.de Found By: --- Blocker: --- When /etc/profile.d/pulseaudio.sh does not exist yet (package install), "setup-pulseaudio --enable" is greping it anyway: # setup-pulseaudio --enable Enabling PulseAudio for ALSA... Missing /etc/alsa-pluse.conf; please install alsa-plugins-pulse package Enabling PulseAudio for libao... Enabling PulseAudio for mplayer... Enabling PulseAudio for OSS... grep: /etc/profile.d/pulseaudio.sh: No such file or directory Enabling PulseAudio for SDL... Enabling PulseAudio for Timidity... Enabling PulseAudio for Phonon... Enabling PulseAudio for Kmix... Enabling PulseAudio for speech dispatcher... Enabling PulseAudio for SoX... Setting auto sink/src for gstreamer Enabling PulseAudio for QEMU/KVM Enabling PulseAudio autospawn... Same thing with sed when disabling: # setup-pulseaudio --disable Disabling PulseAudio for ALSA... Disabling PulseAudio for libao... sed: can't read /etc/profile.d/pulseaudio.sh: No such file or directory sed: can't read /etc/profile.d/pulseaudio.sh: No such file or directory Disabling PulseAudio for SDL... Disabling PulseAudio for Timidity... sed: can't read /etc/profile.d/pulseaudio.sh: No such file or directory Disabling PulseAudio for Phonon... Disabling PulseAudio for Kmix... Disabling PulseAudio for speech dispatcher... Disabling PulseAudio for SoX... Setting alsasink/src for gstreamer Clearing QEMU/KVM audio setup Disabling PulseAudio autospawn... I did some changes to the script, protecting the offending grep/sed invocations to only run when files are in place. Also, cleaned up status messages to make them more uniform. I tried to follow the tab/space mix used to indent it. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=997467
http://bugzilla.opensuse.org/show_bug.cgi?id=997467#c1
--- Comment #1 from Marcos Mello
http://bugzilla.opensuse.org/show_bug.cgi?id=997467
http://bugzilla.opensuse.org/show_bug.cgi?id=997467#c2
Takashi Iwai
http://bugzilla.opensuse.org/show_bug.cgi?id=997467
http://bugzilla.opensuse.org/show_bug.cgi?id=997467#c3
Marcos Mello
http://bugzilla.opensuse.org/show_bug.cgi?id=997467
http://bugzilla.opensuse.org/show_bug.cgi?id=997467#c4
Takashi Iwai
Created attachment 691249 [details] Proposed fixes V2
- Untabfy - Simplified enable_libao(), grep ^default_driver=pulse - Check $PROFNAME existence in enable_timidity() - Simplified disable_festival() - All status messages are printed, no matter if config file in question is present or not. Before some functions would print, others would not. Please review and apply for me. I need to learn how OBS works first.
The patch isn't applicable cleanly to the latest package on TW which we have to fix primarily. Could you check the TW package (or the one in OBS multimedia:libs repo) at first? -- You are receiving this mail because: You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply@novell.com