http://bugzilla.novell.com/show_bug.cgi?id=510790 User suse@tlinx.org added comment http://bugzilla.novell.com/show_bug.cgi?id=510790#c510789 Summary: A 'feature' added to 'xfs.fsck' script in 11.1 (not in 10.3) causes boot failures Classification: openSUSE Product: openSUSE 11.1 Version: Final Platform: All OS/Version: openSUSE 11.1 Status: NEW Severity: Major Priority: P5 - None Component: Basesystem AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: suse@tlinx.org QAContact: qa@suse.de Depends on: 510789 Found By: --- +++ This bug was initially created as a clone of Bug #510789 +++ User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.10) Gecko/2009042316 Firefox/3.0.10 (.NET CLR 3.5.30729) Starting with openSUSE 11.0, someone added some unnecessary and BAD lines to the xfs.fsck script. After line 12, the following "garbage" was added: +eval DEV=\${$#} +if [ ! -e $DEV ]; then + echo "$0: $DEV does not exist" + exit 8 +fi -------- This DOES nothing useful -- and DECREASES the reliability of the boot process -- systems that used to boot stopped booting because this script couldn't find the 'dev' that was passed in. In one case, it was a device that was dynamically created and wasn't mounted (and was set to NOT be mounted, automatically -- it was set to 'noauto'). In the second case, the 'udev' user-device system was(is) broken due to a missing library -- so there is no '/dev' file system, so no devices, so they can't be checked by DEV (but mount 'mounts' them by label, just fine!). This code ONLY introduces new failure points -- one of the MAIN features of XFS was that it had no fsck and its fsck could NEVER fail. By adding this code, I've already ran into two cases where the system would have come up normally, except for this added noise check. Please remove these extra lines (note: likely should not revert to 10.3, as 11.0 also added "p" & "y" as equivalent switches for "a" and "A"). But please do not do unneeded checks which prevent a boot that would other wise work fine. Reproducible: Always Steps to Reproduce: 1. create an fstab entry for a dynamically added external disk. Set mount options for 'noauto', but otherwise, set fsck/dump options to 2 0. 2. 3. Actual Results: this script causes unnecessary boot failure Expected Results: older script ignored missing external disk and booted fine. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.