[Bug 533576] New: cdrdao-1.2.2-310.8: missing call to fclose
http://bugzilla.novell.com/show_bug.cgi?id=533576 Summary: cdrdao-1.2.2-310.8: missing call to fclose Classification: openSUSE Product: openSUSE 11.2 Version: Factory Platform: All OS/Version: openSUSE 11.1 Status: NEW Severity: Normal Priority: P5 - None Component: Other AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: dcb314@hotmail.com QAContact: qa@suse.de Found By: --- I just had a look at factory package cdrdao-1.2.2-310.8 For source code file cdrdao-1.2.2/trackdb/Cue2Toc.cc around line 310, function read_cue is the following code } else if (NULL == (f = fopen(cuefile, "r"))) { but I fail to find any matching call to fclose. This looks like a resource leak to me. Suggest add call to fclose. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=533576 shuang qiu <sqiu@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sqiu@novell.com AssignedTo|bnc-team-screening@forge.pr |nadvornik@novell.com |ovo.novell.com | -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=533576 User dcb314@hotmail.com added comment http://bugzilla.novell.com/show_bug.cgi?id=533576#c1 --- Comment #1 from David Binderman <dcb314@hotmail.com> 2009-09-30 04:45:26 MDT --- Something very similar happens in file cdrdao-1.2.2/utils/cue2toc.c, function read_cue, line about 330 } else if (NULL == (f = fopen(cuefile, "r"))) { Any chance of some progress on this problem ? It's been no-progress for over a month now. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=533576 User rguenther@novell.com added comment http://bugzilla.novell.com/show_bug.cgi?id=533576#c2 --- Comment #2 from Richard Guenther <rguenther@novell.com> 2009-10-17 08:55:12 MDT --- David, in case the issues are not introduced by a patch local to openSUSE please report the issues upstream. Packagers, please do not add openSUSE-local patches to fix this kind of errors but forward the bugs upstream and close the bugs as RESOLVED UPSTREAM. Note that it is perfectly fine to have "resource leaks" at the end of a program as the kernel will clean up for you. Manually freeing them only increases binary size and runtime. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com