[Bug 534732] New: hercules-20080407-36.14: missing call to close
http://bugzilla.novell.com/show_bug.cgi?id=534732 Summary: hercules-20080407-36.14: missing call to close Classification: openSUSE Product: openSUSE 11.2 Version: Factory Platform: All OS/Version: openSUSE 11.1 Status: NEW Severity: Normal Priority: P5 - None Component: Other AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: dcb314@hotmail.com QAContact: qa@suse.de Found By: --- I just had a look at factory package hercules-20080407-36.14 For source code file hercules/dasdload.c around line 390, function read_ipl_text is the following code tfd = open (pathname, O_RDONLY|O_BINARY); but I fail to find any matching call to close after the while loop, that matches a successful return. This looks like a resource leak to me. Suggest add call to close. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=534732 shuang qiu <sqiu@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sqiu@novell.com AssignedTo|bnc-team-screening@forge.pr |uli@novell.com |ovo.novell.com | -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=534732 User rguenther@novell.com added comment http://bugzilla.novell.com/show_bug.cgi?id=534732#c1 --- Comment #1 from Richard Guenther <rguenther@novell.com> 2009-10-17 08:55:14 MDT --- David, in case the issues are not introduced by a patch local to openSUSE please report the issues upstream. Packagers, please do not add openSUSE-local patches to fix this kind of errors but forward the bugs upstream and close the bugs as RESOLVED UPSTREAM. Note that it is perfectly fine to have "resource leaks" at the end of a program as the kernel will clean up for you. Manually freeing them only increases binary size and runtime. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=534732 http://bugzilla.novell.com/show_bug.cgi?id=534732#c2 Ulrich Hecht <uli@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |UPSTREAM Severity|Normal |Major --- Comment #2 from Ulrich Hecht <uli@novell.com> 2010-08-04 16:44:01 UTC --- That issue still exists upstream (3.07), needs to be fixed there. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com