[Bug 853227] New: gtk3 is compiled without support for deprecated symbols
https://bugzilla.novell.com/show_bug.cgi?id=853227 https://bugzilla.novell.com/show_bug.cgi?id=853227#c0 Summary: gtk3 is compiled without support for deprecated symbols Classification: openSUSE Product: openSUSE 13.1 Version: Final Platform: All OS/Version: openSUSE 13.1 Status: NEW Severity: Normal Priority: P5 - None Component: GNOME AssignedTo: bnc-team-gnome@forge.provo.novell.com ReportedBy: dap@open.by QAContact: qa-bugs@suse.de Found By: --- Blocker: --- Created an attachment (id=569870) --> (http://bugzilla.novell.com/attachment.cgi?id=569870) Build log. User-Agent: Opera/9.80 (X11; Linux x86_64; openSUSE 12.2 Mantis) Presto/2.12.388 Version/12.16 Some gtk3 apps like sakura fail to build for openSUSE 13.1+ because of the subject (GtkAction f.e.). See more at https://bugs.launchpad.net/sakura/+bug/1249157 Reproducible: Always Steps to Reproduce: Try to build sakura 3.1+ at openSUSE 13.1+. Actual Results: Error: unknown type name 'GtkAction'. Expected Results: «Succeeded». https://build.opensuse.org/package/show/home:DarkSS/sakura -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=853227 https://bugzilla.novell.com/show_bug.cgi?id=853227#c1 Dominique Leuenberger <dimstar@opensuse.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |dimstar@opensuse.org Resolution| |INVALID --- Comment #1 from Dominique Leuenberger <dimstar@opensuse.org> 2013-12-02 21:06:37 UTC --- This looks like a mis-understanding from your end. Were GTK built without GtkAction support, that would mean it would be binary incompatible and any binary relying on it would crash.. clearly not the point. What IS the case though is that GtkAction is deprecated and sakura defines in the CmakeLists.txt thet deprecated symbols are not to be used. This simple patch will help you build sakura, by allowing usage of deprecated symbols (they are likely to stay around until GTK+ 4.0). Cheers, Index: sakura-3.1.2/CMakeLists.txt =================================================================== --- sakura-3.1.2.orig/CMakeLists.txt +++ sakura-3.1.2/CMakeLists.txt @@ -38,7 +38,7 @@ ADD_DEFINITIONS (-DBUILDTYPE=\\\"${CMAKE IF (${CMAKE_BUILD_TYPE} MATCHES "Debug") SET (CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wall") ELSE (${CMAKE_BUILD_TYPE} NOT MATCHES "Debug") - SET (CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -O2 -Wno-deprecated-declarations -DGDK_DISABLE_DEPRECATED -DGTK_DISABLE_DEPRECATED") + SET (CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -O2 -Wno-deprecated-declarations") ENDIF (${CMAKE_BUILD_TYPE} MATCHES "Debug") INCLUDE_DIRECTORIES (. ${GTK_INCLUDE_DIRS} ${VTE_INCLUDE_DIRS}) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=853227 https://bugzilla.novell.com/show_bug.cgi?id=853227#c2 --- Comment #2 from Dmitriy Perlow <dap@open.by> 2013-12-03 16:46:58 UTC --- https://bugs.launchpad.net/sakura/+bug/1249157/comments/12
Hey thanks, i forgot there was a no-deprecated in the CMakelists. It seems a very bad idea from my part, i'll remove it.
Thank you! -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com