https://bugzilla.novell.com/show_bug.cgi?id=359546 User seife@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=359546#c8 --- Comment #8 from Stefan Seyfried 2008-02-19 13:34:04 MST --- Created an attachment (id=195784) --> (https://bugzilla.novell.com/attachment.cgi?id=195784) second patch hci conn child devices other than rfcomm tty should not be moved here. This is my lost, thanks for Barnaby's reporting and testing. Signed-off-by: Dave Young --- net/bluetooth/hci_sysfs.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff -upr linux/net/bluetooth/hci_sysfs.c linux.new/net/bluetooth/hci_sysfs.c --- linux/net/bluetooth/hci_sysfs.c 2008-02-16 06:38:56.000000000 +0800 +++ linux.new/net/bluetooth/hci_sysfs.c 2008-02-17 15:45:15.000000000 +0800 @@ -320,15 +320,14 @@ void hci_conn_add_sysfs(struct hci_conn queue_work(btaddconn, &conn->work); } +/* + * The rfcomm tty device will possibly retain even when conn + * is down, and sysfs doesn't support move zombie device, + * so we should move the device before conn device is destroyed. + */ static int __match_tty(struct device *dev, void *data) { - /* The rfcomm tty device will possibly retain even when conn - * is down, and sysfs doesn't support move zombie device, - * so we should move the device before conn device is destroyed. - * Due to the only child device of hci_conn dev is rfcomm - * tty_dev, here just return 1 - */ - return 1; + return !strncmp(dev->bus_id, "rfcomm", 6); } static void del_conn(struct work_struct *work) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=359546 User seife@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=359546#c11 --- Comment #11 from Stefan Seyfried 2008-02-20 04:21:55 MST --- Created an attachment (id=195913) --> (https://bugzilla.novell.com/attachment.cgi?id=195913) fix for Bug 359920 Another one found on bluez-devel/lkml, this time for the "duplicate" Bug 359920. Tested, works here. ------------------------------------------------------------------- Defer hci_unregister_sysfs because hci device could be destructed while hci conn devices still there. Signed-off-by: Dave Young --- net/bluetooth/hci_core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -upr linux/net/bluetooth/hci_core.c linux.new/net/bluetooth/hci_core.c --- linux/net/bluetooth/hci_core.c 2008-02-20 18:27:28.000000000 +0800 +++ linux.new/net/bluetooth/hci_core.c 2008-02-20 18:28:34.000000000 +0800 @@ -901,8 +901,6 @@ int hci_unregister_dev(struct hci_dev *h BT_DBG("%p name %s type %d", hdev, hdev->name, hdev->type); - hci_unregister_sysfs(hdev); - write_lock_bh(&hci_dev_list_lock); list_del(&hdev->list); write_unlock_bh(&hci_dev_list_lock); @@ -914,6 +912,8 @@ int hci_unregister_dev(struct hci_dev *h hci_notify(hdev, HCI_DEV_UNREG); + hci_unregister_sysfs(hdev); + __hci_dev_put(hdev); return 0; -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.