[Bug 697643] New: Submit request history can be changed
https://bugzilla.novell.com/show_bug.cgi?id=697643 https://bugzilla.novell.com/show_bug.cgi?id=697643#c0 Summary: Submit request history can be changed Classification: openSUSE Product: openSUSE.org Version: unspecified Platform: Other URL: https://build.opensuse.org/request/show/71640 OS/Version: Other Status: NEW Severity: Minor Priority: P5 - None Component: BuildService AssignedTo: adrian@novell.com ReportedBy: mvyskocil@novell.com QAContact: qa@suse.de CC: jw@novell.com Found By: Development Blocker: --- According osc rq show 71640 it seems that a submit has been made by user jnweiger, but the history of that request shows History: new 2011-05-27T16:42:25 jnweiger review 2011-05-27T11:20:12 licensedigger review 2011-05-27T11:16:01 mvyskocil So even if the first touch is made by me, the status is review. But I did not a review, I made the request. Even if it seems like minor issue, it's obvious there's bug in BuildService code allowing a change of request history in some not wanted way. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=697643 https://bugzilla.novell.com/show_bug.cgi?id=697643#c1 Juergen Weigert <jw@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO InfoProvider| |adrian@novell.com --- Comment #1 from Juergen Weigert <jw@novell.com> 2011-06-07 20:49:48 UTC --- This is a designed, unfortunatly. The way osc rq show presents its output leads to several common misinterpretations. First, 'new' is not new at all, it means 'ready for checkin, reviews passed'. Second, the state next to the timestamp is what was requested, not what was done. E.g. you 'requested' a review by creating a new request. Then 4 minutes later licensedigger requested another manual review, which was finally done by myself. To add some more confusion, internal build service logic changes states and attributes the state to the person that triggered the logic: You did not explicitly request a review, but the build service logic decided that when creating the request for you. Also I did not explicitly set the state to new, the build service logic did that, when the last open review got approved, which happend to be me. Sufficiently confused now? The bug is not in the implementation. It correctly follows a design. Adrian, do you want to defend the design? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=697643 https://bugzilla.novell.com/show_bug.cgi?id=697643#c2 --- Comment #2 from Michal Vyskocil <mvyskocil@novell.com> 2011-06-08 07:04:34 UTC --- Thanks for the explanation, Juergen. I think I now understand the logic, even if it's really confusing. One would say you can have the 'new' state first and then do 'review's and after all steps have 'done' or 'rejected' only. And the accepted message shows that not only me is confused by it and assumes the user with a 'new' status is the one who made the request :) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=697643 https://bugzilla.novell.com/show_bug.cgi?id=697643#c3 Sascha Peilicke <speilicke@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |RESOLVED CC| |speilicke@novell.com InfoProvider|adrian@novell.com | Resolution| |WONTFIX --- Comment #3 from Sascha Peilicke <speilicke@novell.com> 2011-06-17 10:43:27 UTC --- I'd say it's save to close this bug as WONTFIX :-) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=697643 https://bugzilla.novell.com/show_bug.cgi?id=697643#c4 Juergen Weigert <jw@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Submit request history can |Submit request history |be changed |appears to change | |mysteriously --- Comment #4 from Juergen Weigert <jw@novell.com> 2011-06-17 10:58:53 UTC --- fixing subject, history cannot actually be changed. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com