[Bug 525799] New: icecream-0.9.4-1.10: missing call to fclose
http://bugzilla.novell.com/show_bug.cgi?id=525799 Summary: icecream-0.9.4-1.10: missing call to fclose Classification: openSUSE Product: openSUSE 11.2 Version: Factory Platform: All OS/Version: openSUSE 11.1 Status: NEW Severity: Normal Priority: P5 - None Component: Other AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: dcb314@hotmail.com QAContact: qa@suse.de Found By: --- I just had a look at factory package icecream-0.9.4-1.10 For source code file icecc-0.9.4/client/remote.cpp around line 510 is the source code for the function md5_for_file. I notice the following line of code FILE *f = fopen( file.c_str(), "rb" ); but no matching call to fclose. This looks like a resource leak to me. Suggest add call to fclose. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=525799 Marcus Meissner <meissner@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|bnc-team-screening@forge.pr |coolo@novell.com |ovo.novell.com | -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=525799 User coolo@novell.com added comment http://bugzilla.novell.com/show_bug.cgi?id=525799#c1 Stephan Kulow <coolo@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #1 from Stephan Kulow <coolo@novell.com> 2009-07-29 05:44:49 MDT --- yep, fixed in SVN. As the client lives very shortly, it shouldn't really matter. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=525799 User dcb314@hotmail.com added comment http://bugzilla.novell.com/show_bug.cgi?id=525799#c2 David Binderman <dcb314@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED | --- Comment #2 from David Binderman <dcb314@hotmail.com> 2009-08-27 06:27:38 MDT --- (In reply to comment #1)
yep, fixed in SVN.
I checked icecream-0.9.4-1.14 and it doesn't seem to be fixed. Should I be checking a later version ? -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=525799 User coolo@novell.com added comment http://bugzilla.novell.com/show_bug.cgi?id=525799#c3 Stephan Kulow <coolo@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution| |FIXED --- Comment #3 from Stephan Kulow <coolo@novell.com> 2009-08-27 06:55:44 MDT --- fixed in svn, not released -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=525799 User dcb314@hotmail.com added comment http://bugzilla.novell.com/show_bug.cgi?id=525799#c4 David Binderman <dcb314@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED | --- Comment #4 from David Binderman <dcb314@hotmail.com> 2009-10-02 13:26:55 MDT --- (In reply to comment #3)
fixed in svn, not released
Over a month has elapsed and no fixed version has reached factory. Can I confirm that the fixed version will reach factory sometime before 11.2 ships ? -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=525799 User coolo@novell.com added comment http://bugzilla.novell.com/show_bug.cgi?id=525799#c5 Stephan Kulow <coolo@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution| |UPSTREAM --- Comment #5 from Stephan Kulow <coolo@novell.com> 2009-10-06 02:49:40 MDT --- no, it's fixed upstream but upstream did not release a new version. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=525799 http://bugzilla.novell.com/show_bug.cgi?id=525799#c6 --- Comment #6 from Bernhard Wiedemann <bwiedemann@suse.com> --- This is an autogenerated message for OBS integration: This bug (525799) was mentioned in https://build.opensuse.org/request/show/33678 Factory / icecream -- You are receiving this mail because: You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com