https://bugzilla.novell.com/show_bug.cgi?id=648830 https://bugzilla.novell.com/show_bug.cgi?id=648830#c20 Marius Tomaschewski <mt@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |ASSIGNED InfoProvider|mt@novell.com | --- Comment #20 from Marius Tomaschewski <mt@novell.com> 2011-06-08 07:15:40 UTC --- (In reply to comment #17)
Anyway, it would be nice if NetControl validated the input and reported invalid settings.
Yes, as at and many other places. But this is something for the future [when SLE-11-SP2 is done]. (In reply to comment #19)
(In reply to comment #17)
The option "No Encryption" differs in setting WIRELESS_AUTH_MODE='no-encryption' instead of WIRELESS_AUTH_MODE='open'.
Then this patch shall fix it [2]. I've built the sysconfig package to test in [1]. It works for me. Maybe Christian might want to test it too.
Marius is ok to submit it ?
No, see bellow. Further question is: are both cases covered now, that is [1] and [2] from comment 16?
[1] home:vbotka:branches:openSUSE:11.4:Update:Test/sysconfig
[2] diff --git a/scripts/ifup-wireless b/scripts/ifup-wireless index 105ebe9..7994a33 100755 --- a/scripts/ifup-wireless +++ b/scripts/ifup-wireless @@ -304,7 +304,7 @@ EOL # special hack for madwifi test "$DRIVER" = "ath_pci" && run_iw_tool priv authmode 2 ;; - open|opensystem|"") WIRELESS_SEC_MODE="open";; + open|opensystem|no-encryption"") WIRELESS_SEC_MODE="open";; ^^^^^^^^^^^^^^^
This should be open|opensystem|no-encryption|"") I think.
esac fi if [ -n "$WIRELESS_KEY_0" -a \ @@ -403,7 +403,7 @@ setup_wlanngdev() wlanctl dot11req_mibset mibattribute=dot11ExcludeUnencrypted=true AUTHTYPE=sharedkey ;; - open|opensystem|"") + open|opensystem|no-encryption"")
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Same.
wlanctl dot11req_mibset mibattribute=dot11ExcludeUnencrypted=false AUTHTYPE=opensystem ;; @@ -540,7 +540,7 @@ print_network_block() print_network_line ssid WIRELESS_ESSID "$SUFFIX" print_network_line_unquoted priority WIRELESS_PRIORITY "$SUFFIX" case "`eval echo \\$WIRELESS_AUTH_MODE$SUFFIX`" in - open) + open|no-encryption) echo " key_mgmt=NONE" for i in 0 1 2 3 ; do KEY="`eval print_key \\"\\$WIRELESS_KEY_$i$SUFFIX\\" \\$WIRELESS_KEY_LENGTH$SUFFIX`"
Can you please review & correct the above and create the patch using "git format-patch" (with author, date, comment, ...) and send to me, so I don't need to fake them while applying it to git? [You may also clone from http://gitorious.org/opensuse/sysconfig, then commit & push to your clone and request a merge then...]. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.