http://bugzilla.suse.com/show_bug.cgi?id=1091864 http://bugzilla.suse.com/show_bug.cgi?id=1091864#c19 Simon Lees <simonf.lees@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(simonf.lees@suse. | |com) | --- Comment #19 from Simon Lees <simonf.lees@suse.com> --- (In reply to Marcus Rückert from comment #12)
so the thing that is broken with the cmake version of the %make_jobs macro (compared to the version in the Qt package)
is
%make_jobs -C build/something
the params end up after the the %endif of the cmake make_jobs macro
the main difference between the 2 macros is enabling verbose mode and support for ninja. the first step is already handled by the __builder macro. but the verbose flag is why we need the %if, so my proposal would be the following change.
``` # added the %_make_output_sync from %make_build here as it is useful. %__builder_verbose \ %if "%__builder" == "%__make" \ %{?_make_output_sync} VERBOSE=1 \\\ %else \ -v \\\ %endif \ %{nil}
%make_jobs %__builder \\%__builder_verbose %{?_smp_mflags} ```
this makes Fabian's usecase work. now the question is on how do we make this change in a backwards compatible way. in ideal world we would just move the whole %make_jobs macro to the rpm macros file but that would require a maintenance update for rpm and everyone building against :Update.
or we just copy the macro around and have a comment that asks people to keep the macro in sync between the different places. thoughts?
I am now preparing a cmake update for SLE 15 sp1 so i'll include this change unless you see a good reason not to. -- You are receiving this mail because: You are on the CC list for the bug.