http://bugzilla.suse.com/show_bug.cgi?id=994322 http://bugzilla.suse.com/show_bug.cgi?id=994322#c12 --- Comment #12 from Steffen Winterfeldt <snwint@suse.com> ---
This seems to rely on df output. Does df return an usable device name, never things like "by-*/*-partN"? Would a stat + mknod be more reliable?
'df' is some classical unix tool and works quite fine. I don't think we improve by re-implementing finding the device ourselves. It returns the kernel names and even if it would not it wouldn't matter as long as the device node it reports actually exists at that time. And I'd trust it that far.
Looks like install() will always set installed even if grub2-install fails.
'install_tried' might be a semantically more appropriate name, yes. My idea was to find a valid device, then install. I don't think it's the task of the script to handle the situation 'device exists - but grub can't be installed there'. That would be a real config error and might as well be visible as such. -- You are receiving this mail because: You are on the CC list for the bug.