https://bugzilla.novell.com/show_bug.cgi?id=228344 ------- Comment #34 from bk@novell.com 2007-02-23 08:28 MST ------- Created an attachment (id=120787) --> (https://bugzilla.novell.com/attachment.cgi?id=120787&action=view) polished patch, reduces binary size by one for loop for all calls to set_fixed_range Attached updated patch, Description is: "reduces binary size by one for loop for all calls to set_fixed_range." Contains only small changes. I found that my test program to verify the MTTR contents had a bug so I didn't notice that the patch doesn't syncronize the MTRRs after the SMI for the transition to ACPI mode. Initially I thought that I could call mtrr_save_fixed_ranges() in the window between acpi_enable() and the init of the APs, but it would be better if do a smp_call_function_single(0, mtrr_save_fixed_ranges, NULL, 1, 1); in mtrr_ap_init, which works, but it triggers a WARN_ON smp_call_function_single() is called with interrupts disabled because it could deadlock then, so I will probably better lookup the places where the APs are signaled to boot and call mtrr_save_fixed_ranges() there. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.