https://bugzilla.novell.com/show_bug.cgi?id=815078 https://bugzilla.novell.com/show_bug.cgi?id=815078#c20 --- Comment #20 from Dominique Leuenberger <dimstar@opensuse.org> 2013-05-14 09:21:03 UTC --- (In reply to comment #19)
(In reply to comment #17)
James, you realize that your patch contains =================================================================== --- gnome-themes-standard-3.6.2.orig/configure.ac +++ gnome-themes-standard-3.6.2/configure.ac @@ -61,8 +61,9 @@ AC_MSG_CHECKING([building gtk2 engine]) AM_CONDITIONAL(GTK2_ENGINE, test "x$enable_gtk2_engine" = "xyes") AC_MSG_RESULT([$enable_gtk2_engine])
+GTK2_VERSION_REQUIRED=2.24.15 if test "x$enable_gtk2_engine" = "xyes"; then - PKG_CHECK_MODULES([GTK2_ENGINE], [gtk+-2.0 gdk-2.0]) + PKG_CHECK_MODULES([GTK2_ENGINE], [gtk+-2.0 >= $GTK2_VERSION_REQUIRED gdk-2.0
= $GTK2_VERSION_REQUIRED]) fi
And as such, not upgrading GTK2 is is any case going to be a bad way forward?
Two issues here..why does it not fail this test?
because you do not re-bootstrap (autoreconf) and the patch only changes configure.ac; configure does not know about that change in this situation.
and
I believe the requirement was not part of this fix, but about another crash that was occurring anyway.
If you feel it's too problematic, and I'm the only one reporting this xchat issue, just revert everything and I'll live with my own packages until 13..
I don't mind fixing the bug... but: The commit message of the patch you use states:
This also bumps the GTK2 required version to 2.24.15, which has a fix that makes this possible. which sounds like a very conscious decision to bump the gtk version requirement for THIS very fix.
Alternatively, I have a branch prepared with gnome-standard-themes upgraded to 3.6.5 and gtk2 bumped for that as well: http://download.opensuse.org/repositories/home:/dimstar:/bnc815078/openSUSE_... Tests welcome. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.