https://bugzilla.suse.com/show_bug.cgi?id=1226207 https://bugzilla.suse.com/show_bug.cgi?id=1226207#c2 --- Comment #2 from Mykola Krachkovsky <w01dnick@gmail.com> --- (In reply to Fabian Vogt from comment #1)
How's the size increase?
Without generation (as of current) ``` du -hs /usr/share/icons/breeze /usr/share/icons/breeze-dark 63M /usr/share/icons/breeze 34M /usr/share/icons/breeze-dark ``` With generation ``` du -hs /usr/share/icons/breeze /usr/share/icons/breeze-dark 72M /usr/share/icons/breeze 59M /usr/share/icons/breeze-dark ``` So about 34M.
Maybe we could enable generation of dark symbolic icons but skip the 24px generation?
From CMake they are controlled by one option: ``` add_feature_info("Icon generation" ${WITH_ICON_GENERATION} "for 24x24 and symbolic dark icons. This feature requires Python 3 and the lxml Python 3 module." ) # The exact amount of indentation used in the line(s) above is intentional ``` But they made by different calls, so with some patching I think it could be done. ``` if(WITH_ICON_GENERATION) # No trainling slashes on dirs. It will break scripts. add_custom_target(breeze-generate-symbolic-dark ALL COMMENT "Generating symbolic dark icons" COMMAND $<TARGET_FILE:generate-symbolic-dark> ${CMAKE_SOURCE_DIR}/icons ${ICON_GEN_DIR} ) # Auto-generate 24px monochrome icons from 22px versions add_custom_target(breeze-generate-24px-versions-dark ALL DEPENDS breeze-generate-symbolic-dark COMMENT "Generating 24px icons-dark" COMMAND ${Python_EXECUTABLE} ${CMAKE_SOURCE_DIR}/generate-24px-versions.py ${CMAKE_CURRENT_SOURCE_DIR} ${ICON_GEN_DIR} ${ICON_GEN_DIR} ) else() # create the target dir, we need it for resource creation add_custom_target(breeze-generate-24px-versions-dark ALL COMMENT "Generating 24px icons-dark placeholder" COMMAND ${CMAKE_COMMAND} -E make_directory ${ICON_GEN_DIR} ) endif() ``` -- You are receiving this mail because: You are on the CC list for the bug.