http://bugzilla.novell.com/show_bug.cgi?id=545268 Summary: x11vnc-0.9.8-1.5: two redundant calls to open Classification: openSUSE Product: openSUSE 11.2 Version: Factory Platform: All OS/Version: openSUSE 11.1 Status: NEW Severity: Normal Priority: P5 - None Component: X11 Applications AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: dcb314@hotmail.com QAContact: qa@suse.de Found By: --- I just had a look at factory package x11vnc-0.9.8-1.5 source code file x11vnc-0.9.8/x11vnc/screen.c function initialize_raw_fb line number 1493 local variable is fd. I notice the following code fd = open(tmp, O_WRONLY); unlink_me = strdup(tmp); sprintf(str, "map:%s@%dx%dx32", tmp, w, h); raw_fb_str = strdup(str); } else if (strstr(raw_fb_str, "swirl") == raw_fb_str) { The call to open looks redundant, because fd is a local variable. Suggest remove call to open. The same thing happens a little later, around line 1515 -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.