https://bugzilla.novell.com/show_bug.cgi?id=852652 https://bugzilla.novell.com/show_bug.cgi?id=852652#c13 --- Comment #13 from Jan Beulich <jbeulich@suse.com> 2013-12-06 10:49:44 UTC --- (In reply to comment #11)
Whats appearently missing is a call to add_prefered_console. Otherwise ->index will not be updated in register_console. This is what pvops does, I just copied it verbatim. With this change booting a PV guest with empty cmdline shows xvc0. And in addition root login via console works as well because now systemd can appearently recognize the console device.
drivers/xen/console/console.c already has such a call. But it appearently only triggers when booted with xencons=hvc (which is probably also the workaround for the initial report for the time being).
Jan, what do you think about such a change?
I agree with the intention, but not with how it is being carried out. Instead I'd see the HVC-specific code in drivers/xen/console/console.c to be generalized (i.e. moved out of the switch) - the changeset having introduced this (http://xenbits.xen.org/hg/linux-2.6.18-xen.hg/rev/a070228ac76e) provides no clarification at all why this is being done for HVC only. Doing it there has the advantage of also properly taking xc_num into consideration and not adding consoles as preferred that won't ever get registered. And from your description I understand that all that is needed is that it's being done before calling register_console(). -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.