http://bugzilla.novell.com/show_bug.cgi?id=622083 http://bugzilla.novell.com/show_bug.cgi?id=622083#c11 Guido Berhörster <guido+opensuse.org@berhoerster.name> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #375737|0 |1 is obsolete| | --- Comment #11 from Guido Berhörster <guido+opensuse.org@berhoerster.name> 2010-07-17 10:01:17 UTC --- Created an attachment (id=376583) --> (http://bugzilla.novell.com/attachment.cgi?id=376583) More robust fix, goes through a list of known locking commands until one succeeds (In reply to comment #10)
Ok, fair enough. It would be nice to have some kind of configuration for the preferred screensaver, but lxsession is definitely not the right place.
Last but not least: Checking for the running screensaver should be multi-seat save, e.g. if another user runs a screensaver but I'm not, it shouldn't lock my session if I suspend/hibernate.
Checking for the running screensaver through the process list is impossible to do in a portable way and error-prone. I think going through a list of locking commands and checking the exit code to see which one succeeds is more simple and solid. Does this look acceptable for inclusion upstream? If yes, I'll put a patch for the current git version in the SF.net bugtracker and re-submit to Factory and 11.3 Updates later. BTW, this should be changed in XFCE and xdg-screensaver as well. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.