https://bugzilla.novell.com/show_bug.cgi?id=424101 Summary: axis-1_4 : 97 * Java source code errors Product: openSUSE 11.1 Version: Factory Platform: All OS/Version: openSUSE 11.0 Status: NEW Severity: Normal Priority: P5 - None Component: Other AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: dcb314@hotmail.com QAContact: qa@suse.de Depends on: 424100 Found By: --- Hello there, I just tried to analyse the Suse Linux package axis-1_4 with the most excellent Java static analysis tool pmd. A subset of the results were /usr/src/packages/BUILD/axis-1_4/src/org/apache/axis/AxisFault.java:385 Avoid appending characters as strings in StringBuffer.append. /usr/src/packages/BUILD/axis-1_4/src/org/apache/axis/AxisFault.java:387 Avoid appending characters as strings in StringBuffer.append. /usr/src/packages/BUILD/axis-1_4/src/org/apache/axis/client/AdminClient.java:330 Avoid appending characters as strings in StringBuffer.append. /usr/src/packages/BUILD/axis-1_4/src/org/apache/axis/components/compiler/Jikes.java:247 Avoid appending characters as strings in StringBuffer.append. /usr/src/packages/BUILD/axis-1_4/src/org/apache/axis/components/net/DefaultSocketFactory.java:106 Avoid appending characters as strings in StringBuffer.append. /usr/src/packages/BUILD/axis-1_4/src/org/apache/axis/components/uuid/FastUUIDGen.java:103 Avoid appending characters as strings in StringBuffer.append. /usr/src/packages/BUILD/axis-1_4/src/org/apache/axis/components/uuid/FastUUIDGen.java:104 Avoid appending characters as strings in StringBuffer.append. /usr/src/packages/BUILD/axis-1_4/src/org/apache/axis/components/uuid/FastUUIDGen.java:105 Avoid appending characters as strings in StringBuffer.append. /usr/src/packages/BUILD/axis-1_4/src/org/apache/axis/components/uuid/FastUUIDGen.java:107 Avoid appending characters as strings in StringBuffer.append. /usr/src/packages/BUILD/axis-1_4/src/org/apache/axis/components/uuid/FastUUIDGen.java:121 Avoid appending characters as strings in StringBuffer.append. /usr/src/packages/BUILD/axis-1_4/src/org/apache/axis/components/uuid/SimpleUUIDGen.java:186 Avoid appending characters as strings in StringBuffer.append. /usr/src/packages/BUILD/axis-1_4/src/org/apache/axis/components/uuid/SimpleUUIDGen.java:188 Avoid appending characters as strings in StringBuffer.append. /usr/src/packages/BUILD/axis-1_4/src/org/apache/axis/components/uuid/SimpleUUIDGen.java:190 Avoid appending characters as strings in StringBuffer.append. /usr/src/packages/BUILD/axis-1_4/src/org/apache/axis/components/uuid/SimpleUUIDGen.java:193 Avoid appending characters as strings in StringBuffer.append. /usr/src/packages/BUILD/axis-1_4/src/org/apache/axis/components/uuid/SimpleUUIDGen.java:82 Avoid appending characters as strings in StringBuffer.append. /usr/src/packages/BUILD/axis-1_4/src/org/apache/axis/encoding/ser/DateSerializer.java:66 Avoid appending characters as strings in StringBuffer.append. /usr/src/packages/BUILD/axis-1_4/src/org/apache/axis/handlers/JWSHandler.java:223 Avoid appending characters as strings in StringBuffer.append. /usr/src/packages/BUILD/axis-1_4/src/org/apache/axis/SimpleChain.java:205 Avoid appending characters as strings in StringBuffer.append. /usr/src/packages/BUILD/axis-1_4/src/org/apache/axis/transport/http/AxisServletBase.java:346 Avoid appending characters as strings in StringBuffer.append. /usr/src/packages/BUILD/axis-1_4/src/org/apache/axis/transport/http/HTTPSender.java:244 Avoid appending characters as strings in StringBuffer.append. /usr/src/packages/BUILD/axis-1_4/src/org/apache/axis/transport/http/HTTPSender.java:331 Avoid appending characters as strings in StringBuffer.append. /usr/src/packages/BUILD/axis-1_4/src/org/apache/axis/transport/http/HTTPSender.java:429 Avoid appending characters as strings in StringBuffer.append. /usr/src/packages/BUILD/axis-1_4/src/org/apache/axis/transport/jms/Handler.java:44 Avoid appending characters as strings in StringBuffer.append. /usr/src/packages/BUILD/axis-1_4/src/org/apache/axis/transport/jms/JMSURLHelper.java:183 Avoid appending characters as strings in StringBuffer.append. /usr/src/packages/BUILD/axis-1_4/src/org/apache/axis/transport/jms/JMSURLHelper.java:189 Avoid appending characters as strings in StringBuffer.append. /usr/src/packages/BUILD/axis-1_4/src/org/apache/axis/transport/jms/JMSURLHelper.java:195 Avoid appending characters as strings in StringBuffer.append. /usr/src/packages/BUILD/axis-1_4/src/org/apache/axis/transport/jms/TopicConnector.java:397 Avoid appending characters as strings in StringBuffer.append. /usr/src/packages/BUILD/axis-1_4/src/org/apache/axis/transport/jms/TopicConnector.java:397 Avoid appending characters as strings in StringBuffer.append. /usr/src/packages/BUILD/axis-1_4/src/org/apache/axis/transport/jms/TopicConnector.java:400 Avoid appending characters as strings in StringBuffer.append. /usr/src/packages/BUILD/axis-1_4/src/org/apache/axis/types/Duration.java:383 Avoid appending characters as strings in StringBuffer.append. /usr/src/packages/BUILD/axis-1_4/src/org/apache/axis/types/Duration.java:395 Avoid appending characters as strings in StringBuffer.append. /usr/src/packages/BUILD/axis-1_4/src/org/apache/axis/types/IDRefs.java:56 Avoid appending characters as strings in StringBuffer.append. /usr/src/packages/BUILD/axis-1_4/src/org/apache/axis/types/NMTokens.java:55 Avoid appending characters as strings in StringBuffer.append. /usr/src/packages/BUILD/axis-1_4/src/org/apache/axis/utils/CLUtil.java:62 Avoid appending characters as strings in StringBuffer.append. /usr/src/packages/BUILD/axis-1_4/src/org/apache/axis/utils/URLHashSet.java:122 Avoid appending characters as strings in StringBuffer.append. /usr/src/packages/BUILD/axis-1_4/test/encoding/EncodingTest.java:145 Avoid appending characters as strings in StringBuffer.append. /usr/src/packages/BUILD/axis-1_4/samples/bidbuy/rfq.java:197 Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. /usr/src/packages/BUILD/axis-1_4/samples/bidbuy/rfq.java:208 Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. /usr/src/packages/BUILD/axis-1_4/samples/bidbuy/rfq.java:418 Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. /usr/src/packages/BUILD/axis-1_4/samples/bidbuy/rfq.java:445 Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. /usr/src/packages/BUILD/axis-1_4/samples/bidbuy/rfq.java:760 Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. /usr/src/packages/BUILD/axis-1_4/samples/bidbuy/v3.java:66 Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. /usr/src/packages/BUILD/axis-1_4/samples/echo/TestClient.java:524 Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. /usr/src/packages/BUILD/axis-1_4/samples/echo/TestClient.java:553 Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. /usr/src/packages/BUILD/axis-1_4/src/org/apache/axis/transport/http/AxisServlet.java:1212 Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. /usr/src/packages/BUILD/axis-1_4/src/org/apache/axis/transport/http/AxisServlet.java:1214 Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. /usr/src/packages/BUILD/axis-1_4/src/org/apache/axis/utils/ArrayUtil.java:200 Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. /usr/src/packages/BUILD/axis-1_4/test/encoding/TestDeser1999.java:20 Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. /usr/src/packages/BUILD/axis-1_4/test/encoding/TestDeser2000.java:20 Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. /usr/src/packages/BUILD/axis-1_4/test/encoding/TestDeser2001.java:325 Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. /usr/src/packages/BUILD/axis-1_4/test/encoding/TestDeser.java:210 Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. /usr/src/packages/BUILD/axis-1_4/test/encoding/TestDeser.java:212 Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. /usr/src/packages/BUILD/axis-1_4/test/encoding/TestDeser.java:214 Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. /usr/src/packages/BUILD/axis-1_4/test/encoding/TestDeser.java:216 Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. /usr/src/packages/BUILD/axis-1_4/test/md5attach/MD5AttachTest.java:22 Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. /usr/src/packages/BUILD/axis-1_4/test/wsdl/map/MapServiceTestCase.java:38 Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. /usr/src/packages/BUILD/axis-1_4/test/wsdl/map/MapServiceTestCase.java:46 Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. /usr/src/packages/BUILD/axis-1_4/test/wsdl/map/MapServiceTestCase.java:46 Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. /usr/src/packages/BUILD/axis-1_4/test/wsdl/oneway/OnewayTestCase.java:49 Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. /usr/src/packages/BUILD/axis-1_4/test/wsdl/roundtrip2/RoundTrip2TestServiceTestCase.java:62 Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. /usr/src/packages/BUILD/axis-1_4/test/wsdl/roundtrip/RoundtripTestServiceTestCase.java:225 Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. /usr/src/packages/BUILD/axis-1_4/test/wsdl/roundtrip/RoundtripTestServiceTestCase.java:282 Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. /usr/src/packages/BUILD/axis-1_4/test/wsdl/roundtrip/RoundtripTestServiceTestCase.java:374 Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. /usr/src/packages/BUILD/axis-1_4/test/wsdl/roundtrip/RoundtripTestServiceTestCase.java:458 Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. /usr/src/packages/BUILD/axis-1_4/test/wsdl/roundtrip/RoundtripTestServiceTestCase.java:512 Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. /usr/src/packages/BUILD/axis-1_4/test/wsdl/roundtrip/RoundtripTestServiceTestCase.java:675 Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. /usr/src/packages/BUILD/axis-1_4/test/wsdl/roundtrip/RoundtripTestServiceTestCase.java:911 Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. /usr/src/packages/BUILD/axis-1_4/test/wsdl/roundtrip/RoundtripTestServiceTestCase.java:913 Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. /usr/src/packages/BUILD/axis-1_4/test/wsdl/roundtrip/RoundtripTestSoapBindingImpl.java:109 Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. /usr/src/packages/BUILD/axis-1_4/test/wsdl/roundtrip/RoundtripTestSoapBindingImpl.java:162 Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. /usr/src/packages/BUILD/axis-1_4/test/wsdl/roundtrip/RoundtripTestSoapBindingImpl.java:217 Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. /usr/src/packages/BUILD/axis-1_4/test/wsdl/roundtrip/RoundtripTestSoapBindingImpl.java:269 Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. /usr/src/packages/BUILD/axis-1_4/test/wsdl/roundtrip/RoundtripTestSoapBindingImpl.java:384 Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. /usr/src/packages/BUILD/axis-1_4/test/wsdl/roundtrip/RoundtripTestSoapBindingImpl.java:580 Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. /usr/src/packages/BUILD/axis-1_4/test/wsdl/roundtrip/RoundtripTestSoapBindingImpl.java:581 Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. /usr/src/packages/BUILD/axis-1_4/test/wsdl/types/comprehensive_service/TypeTestServiceTestCase.java:1697 Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. /usr/src/packages/BUILD/axis-1_4/test/wsdl/types/comprehensive_service/TypeTestServiceTestCase.java:1697 Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. /usr/src/packages/BUILD/axis-1_4/test/wsdl/types/comprehensive_service/TypeTestServiceTestCase.java:41 Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. /usr/src/packages/BUILD/axis-1_4/test/wsdl/types/comprehensive_service/TypeTestServiceTestCase.java:62 Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. /usr/src/packages/BUILD/axis-1_4/test/wsdl/types/DynamicProxyTestCase.java:130 Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. /usr/src/packages/BUILD/axis-1_4/test/wsdl/types/DynamicProxyTestCase.java:193 Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. /usr/src/packages/BUILD/axis-1_4/test/wsdl/types/VerifyTestCase.java:166 Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. /usr/src/packages/BUILD/axis-1_4/test/wsdl/types/VerifyTestCase.java:209 Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. /usr/src/packages/BUILD/axis-1_4/test/wsdl/types/VerifyTestCase.java:807 Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. /usr/src/packages/BUILD/axis-1_4/src/org/apache/axis/wsdl/gen/WSDL2.java:300 StringBuffer constructor is initialized with size 16, but has at least 24 characters appended. /usr/src/packages/BUILD/axis-1_4/src/org/apache/axis/transport/http/HTTPSender.java:260 StringBuffer constructor is initialized with size 16, but has at least 38 characters appended. /usr/src/packages/BUILD/axis-1_4/test/utils/TestXMLUtils.java:272 StringBuffer constructor is initialized with size 16, but has at least 402 characters appended. /usr/src/packages/BUILD/axis-1_4/test/utils/TestXMLUtils.java:229 StringBuffer constructor is initialized with size 16, but has at least 434 characters appended. /usr/src/packages/BUILD/axis-1_4/samples/attachments/TestRef.java:158 StringBuffer constructor is initialized with size 16, but has at least 43 characters appended. /usr/src/packages/BUILD/axis-1_4/src/org/apache/axis/transport/http/AxisServlet.java:498 StringBuffer constructor is initialized with size 16, but has at least 45 characters appended. /usr/src/packages/BUILD/axis-1_4/src/org/apache/axis/attachments/BoundaryDelimitedStream.java:519 StringBuffer constructor is initialized with size 16, but has at least 47 characters appended. /usr/src/packages/BUILD/axis-1_4/test/utils/TestXMLUtils.java:295 StringBuffer constructor is initialized with size 16, but has at least 483 characters appended. /usr/src/packages/BUILD/axis-1_4/src/org/apache/axis/wsdl/Java2WSDL.java:657 StringBuffer constructor is initialized with size 16, but has at least 55 characters appended. /usr/src/packages/BUILD/axis-1_4/src/org/apache/axis/AxisFault.java:352 StringBuffer constructor is initialized with size 25, but has at least 89 characters appended. /usr/src/packages/BUILD/axis-1_4/samples/attachments/EchoAttachmentsService.java:156 StringBuffer constructor is initialized with size 39, but has at least 91 characters appended. /usr/src/packages/BUILD/axis-1_4/src/org/apache/axis/transport/http/AxisServlet.java:1084 Using equalsIgnoreCase() is cleaner than using toUpperCase/toLowerCase().equals(). /usr/src/packages/BUILD/axis-1_4/src/org/apache/axis/transport/http/AxisServlet.java:1180 Using equalsIgnoreCase() is cleaner than using toUpperCase/toLowerCase().equals(). In each of the 97 cases, an improvement can be made. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.