https://bugzilla.novell.com/show_bug.cgi?id=276464#c9 --- Comment #9 from Björn Voigt <bjoern@cs.tu-berlin.de> 2007-10-22 12:30:54 MST --- I don't think that fixing of this issue is so difficult as it looks. There is already a function "Quote" in Core.pm: # string Quote (string text, string when) sub Quote { my $self = shift; my $text = shift; my $when = shift; if ($when eq "always" || ($when eq "blanks" && index ($text, " ") >= 0) || ($when eq "blanks" && $text eq "")) { $text = "\"$text\""; } return $text; } The problem is, that Quoting only occurs if $when is "blanks" or "always". But for instance, "=" should always be quoted, as "man lilo.conf" says: Note: The command line root= parameter passed to the kernel will be: 'root=LABEL=MyDisk'; i.e., without the quotation marks. If the root= parameter is passed from the boot time boot: prompt, no quotes are used. The quotes are only there to sat- isfy the requirements of the boot-installer parser, which treats an equal sign as an operator. The kernel command line parser is very much simpler, and must not see any quotation marks. Simply stated, only use the quotation marks within /etc/lilo.conf. My patch quotes "=" unconditional. If it's guarantied, that $when must be "always" or "blanks" then it also could be used in case of "blanks". This is the patches function "Quote": # string Quote (string text, string when) sub Quote { my $self = shift; my $text = shift; my $when = shift; if ($when eq "always" || ($when eq "blanks" && index ($text, " ") >= 0) || ($when eq "blanks" && $text eq "") || index ($text, "=") >= 0) { $text = "\"$text\""; } return $text; } I tested the patched function a bit. My problem that kernel-update removes the quotes of append = "resume=/dev/sda5" is solved with the patch and I see no side effects. But maybe some more testing and/or code cleanup should follow. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.