http://bugzilla.novell.com/show_bug.cgi?id=540589 http://bugzilla.novell.com/show_bug.cgi?id=540589#c19 Jiri Benc <jbenc@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |ASSIGNED Info Provider|jbenc@novell.com | --- Comment #19 from Jiri Benc <jbenc@novell.com> 2010-01-14 14:03:40 UTC --- (In reply to comment #16)
... I should have pClonedPkt->head = pClonedPkt->data - pClonedPkt->len;
Hm, yes, after some thinking I tend to agree. However, the driver is such a mess I'm not sure about anything anymore :-( (In reply to comment #17)
This patch uses the ->head that "pData" is derived from earlier in the call chain. I think this is right.
I'm not sure this is correct. RTPKT_TO_OSPKT(pRxPkt) and RTPKT_TO_OSPKT(pRxBlk->pRxPacket) is the same, because RTPKT_TO_OSPKT is just a cast to (struct sk_buff *) and pRxPkt = RTPKT_TO_OSPKT(pRxBlk->pRxPacket); This makes the statement RTPKT_TO_OSPKT(pRxPkt)->head = RTPKT_TO_OSPKT(pRxBlk->pRxPacket)->head; noop. Unless I'm lost in the similarly looking identifiers. Which is quite possible. I think we should try Jeff's approach, build a test kernel and ask some of the reporters of the panic to test. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.