https://bugzilla.novell.com/show_bug.cgi?id=746595 https://bugzilla.novell.com/show_bug.cgi?id=746595#c19 Stanislav Brabec <sbrabec@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #483021|0 |1 is obsolete| | --- Comment #19 from Stanislav Brabec <sbrabec@suse.com> 2012-03-27 19:35:12 CEST --- Created an attachment (id=483532) --> (http://bugzilla.novell.com/attachment.cgi?id=483532) systemd-numlock-suse.patch New (final?) version of the patch: - Code cleanup. - Move seat specific code to udev rules. - configure checks for paths of hwinfo and setleds. Discussion: Support for /run/numlock-on is now generic, its setup in vconsole-setup.c is SUSE specific. I am not sure, whether other distros would want to implement its own code. When the kernel bug will be fixed once in future, the current SUSE solution (check for /var/run/numlock-on) will not be sufficient. It would require to transfer three values to seat and X: keep, set, unset. It would require either two files: /var/run/numlock-on for force on /var/run/numlock-off to force off, or one file with contents, e. g. /var/run/numlock with contents "on", "off", "keep". First solution would be just an enhancement, the second would break the current "API". The line close(open("/run/numlock-on", O_WRONLY|O_CREAT, 0644)) has no failure check. I guess it is OK. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.