https://bugzilla.novell.com/show_bug.cgi?id=396070 User jsuchome@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=396070#c6 --- Comment #6 from Jiří Suchomel <jsuchome@novell.com> 2008-06-02 06:40:04 MDT --- (From update of attachment 219497) Index: SambaNetJoin.pm =================================================================== --- SambaNetJoin.pm (revision 47068) +++ SambaNetJoin.pm (working copy) @@ -12,7 +12,7 @@ use strict; use Data::Dumper; -use YaST::YCP qw(:DATA :LOGGING); +use YaST::YCP qw(:LOGGING); use YaPI; textdomain "samba-client"; @@ -21,6 +21,7 @@ YaST::YCP::Import("SCR"); YaST::YCP::Import("SambaConfig"); YaST::YCP::Import("SambaAD"); +YaST::YCP::Import("String"); my %TestJoinCache; @@ -97,7 +98,7 @@ . ($protocol ne "ads" ? " -w '$domain'" : "") . " -s $conf_file" . (($protocol ne "ads" && $netbios_name)?" -n '$netbios_name'":"") - . " -U '" . ($user||"") . "%" . ($passwd||"") . "'"; + . " -U '" . String->Quote ($user) . "%" . String->Quote ($passwd) . "'"; if ($machine) { $machine =~ s/dc=([^,]*)//gi; # remove DC=* parts @@ -144,7 +145,7 @@ SCR->Write (".target.string", $conf_file, "[global]\n\trealm = $realm\n\tsecurity = ADS\n\tworkgroup = $domain\n"); my $cmd = "net ads leave -s $conf_file" - . " -U '" . ($user||"") . "%" . ($passwd||"") . "'"; + . " -U '" . String->Quote ($user) . "%" . String->Quote ($passwd) . "'"; my $result = SCR->Execute(".target.bash_output", $cmd); $cmd =~ s/(-U '[^%]*)%[^']*'/$1'/; # hide password in the log -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.