https://bugzilla.novell.com/show_bug.cgi?id=655804 https://bugzilla.novell.com/show_bug.cgi?id=655804#c1 Petr Uzel <puzel@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |puzel@novell.com AssignedTo|puzel@novell.com |lnussel@novell.com --- Comment #1 from Petr Uzel <puzel@novell.com> 2010-11-29 11:07:19 UTC ---
Either an error message mentioning the '-k' command line argument, which is new in version 2.18, should be printed, or a reasonable default value used.
This is not in upstream util-linux-ng, but implemented in a Ludwig's patch that is in openSUSE at least since 11.1. # losetup -a # losetup -e aes /dev/loop0 file Password: # losetup -v -e aes /dev/loop0 file Password: please specify a key length # losetup -a # Obvious fix: --- mount/lomount.c.orig 2010-11-29 11:44:05.000000000 +0100 +++ mount/lomount.c 2010-11-29 11:44:26.000000000 +0100 @@ -822,8 +822,7 @@ set_loop(const char *device, const char if(!loopinfo64.lo_encrypt_key_size) { if(!keysz) { - if(verbose) - fprintf(stderr, _("please specify a key length\n")); + fprintf(stderr, _("please specify a key length\n")); return 1; } loopinfo64.lo_encrypt_key_size = keysz>>3; Apart from that, I don't know how to use the -k/-e anyway: # losetup -v -e aes -k 256 /dev/loop0 file Password: ioctl: LOOP_SET_STATUS: Invalid argument (file was created as dd if=/dev/zero of=file ...). Is this supposed to work? Ludwig, the most important question is if we want to retain this patch in future openSUSE/SLE versions. As far as I see, it has been rejected by upstream u-l-ng because cryptoloop is considered deprecated (in favor of cryptsetup??). Thanks. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.