https://bugzilla.novell.com/show_bug.cgi?id=679980 https://bugzilla.novell.com/show_bug.cgi?id=679980#c0 Summary: openSUSE:Tools/osc-source_validator: Bug Classification: openSUSE Product: openSUSE.org Version: unspecified Platform: Other OS/Version: Other Status: NEW Severity: Normal Priority: P5 - None Component: 3rd party software AssignedTo: adrian@novell.com ReportedBy: viliam.pucik@gmail.com QAContact: opensuse-communityscreening@forge.provo.novell.com Found By: --- Blocker: --- osc source validator should include sub-package sources and patches into the validation. For example osc source validator ignores patches defined for netcf-devel sub-package and thinks they are not mentioned in the SPEC: --- BEGIN: part of RHEL6 netcf SPEC Name: netcf Version: 0.1.6 Release: 4%{?dist}%{?extra_release} Summary: Cross-platform network configuration library Group: System Environment/Libraries License: LGPLv2+ URL: https://fedorahosted.org/netcf/ Source0: https://fedorahosted.org/released/%{name}/%{name}-%{version}.tar.gz BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) BuildRequires: readline-devel augeas-devel >= 0.5.2 BuildRequires: libxml2-devel libxslt-devel BuildRequires: libnl-devel Requires: %{name}-libs = %{version}-%{release} %description A library for modifying the network configuration of a system. Network configurations are expresed in a platform-independent XML format, which netcf translates into changes to the system's 'native' network configuration files. %package devel Summary: Development files for %{name} Group: Development/Libraries Requires: %{name}-libs = %{version}-%{release} Requires: pkgconfig Patch01: netcf-0.1.6-bond-make-miimon-arpmon-optional.patch Patch02: netcf-0.1.6-empty-iptables.patch Patch03: netcf-0.1.6-handle-quoted-entries.patch Patch04: netcf-0.1.6-install-sysconfig.aug.patch Patch05: netcf-0.1.6-dont-delete-physical-on-vlan-define.patch --- END Steps to reproduce the error: $ wget ftp://ftp.redhat.com/redhat/linux/enterprise/6Server/en/os/SRPMS/netcf-0.1.6-4.el6.src.rpm $ osc importsrcpkg netcf-0.1.6-4.el6.src.rpm $ cd netcf $ ls netcf-0.1.6-bond-make-miimon-arpmon-optional.patch netcf-0.1.6-empty-iptables.patch netcf-0.1.6-install-sysconfig.aug.patch netcf.spec netcf-0.1.6-dont-delete-physical-on-vlan-define.patch netcf-0.1.6-handle-quoted-entries.patch netcf-0.1.6.tar.gz $ osc add * $ osc ci -m 'initial import' Attention, netcf-0.1.6-bond-make-miimon-arpmon-optional.patch is not mentioned in spec files as source or patch. Is this correct? [N/y/d] (y to ignore) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.