[opensuse-autoinstall] schema fixes for <files>
The autoyast schema currently lacks the file_location element and thus my profile fails to validate (despite working properly). I've fixed this in my "simple_files_fix" branch on github[1]. I've also made a "files_cleanup" branch that enforces what I think autoyast expects (open to correction, of course): * there should only be file_content or file_location, not both * file_path should be mandatory * everything else (file_owner, file_permissions, file_script) is optional but should only occur once per file * all of the file_* elements can occur in any order within the <file> tag Which brings me to a point of confusion: my profile, which I based on a previous version of the AutoYaST documentation, uses <file> rather than <config_file>, e.g.: <files config:type="list"> <file> <file_location>http://blah.blah/foo</file_location> <file_path>/foo/bar</file_path> </file> ... </files> However, the current documentation[2] uses <config_file> instead of <file>. My profile works correctly in both SLES 11 SP1 & SP2 and openSUSE 12.1, and the schema expects <file>, so this appears correct, but I hesitate to call the documentation wrong without further input. Whichever way is correct, everything should be reconciled. BTW, it's great that YaST on github now -- it makes fixes like this a lot easier! Uwe (or others), please let me know how you wish to proceed, and I'll file a github pull request and/or a BugZilla entry. Thanks, Andrew Daugherity Systems Analyst Division of Research, Texas A&M University [1] https://github.com/adaugherity/yast-autoinstallation/branches [2] http://www.suse.de/~ug/autoyast_doc/configuration.html#createprofile.complet... -- To unsubscribe, e-mail: opensuse-autoinstall+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-autoinstall+owner@opensuse.org
On 10.08.2012 18:53, Andrew Daugherity wrote:
I've also made a "files_cleanup" branch that enforces what I think autoyast expects (open to correction, of course): * there should only be file_content or file_location, not both
true
* file_path should be mandatory
true
* everything else (file_owner, file_permissions, file_script) is optional but should only occur once per file
true
* all of the file_* elements can occur in any order within the <file> tag
true
Which brings me to a point of confusion: my profile, which I based on a previous version of the AutoYaST documentation, uses <file> rather than <config_file>, e.g.: <files config:type="list"> <file> <file_location>http://blah.blah/foo</file_location> <file_path>/foo/bar</file_path> </file> ... </files>
However, the current documentation[2] uses <config_file> instead of <file>. My profile works correctly in both SLES 11 SP1 & SP2 and openSUSE 12.1, and the schema expects <file>, so this appears correct, but I hesitate to call the documentation wrong without further input. Whichever way is correct, everything should be reconciled.
the point with that is, that autoyast does not care at all how the elements inside a list are called. You can call one <file> and the next one <config_file> - it'll work. For the schema validation of course the name is important and for compatibility's sake, let's say the schema is right and the documentation is wrong :)
BTW, it's great that YaST on github now -- it makes fixes like this a lot easier!
I think so too
Uwe (or others), please let me know how you wish to proceed, and I'll file a github pull request and/or a BugZilla entry.
a pull request is fine. You don't have to file a bug for that. Thanks. -- ciao, Uwe Gansert SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer Home: http://www.suse.de/~ug - Blog: http://suse.gansert.net -- To unsubscribe, e-mail: opensuse-autoinstall+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-autoinstall+owner@opensuse.org
participants (2)
-
Andrew Daugherity -
Uwe Gansert