Hi team
Coolo has reported an issue with the KDE lock screen
As I'm busy with FOSDEM this weekend, and don't know KDE well, please can someone look at it?
https://github.com/openSUSE/branding/issues/18
Thank You!
Richard Branding Maintainer
Richard Brown Systems Engineering Team Leader City College Brighton and Hove
On Friday 01 of February 2013 12:53:46 Richard Brown wrote:
Hi team
Coolo has reported an issue with the KDE lock screen
As I'm busy with FOSDEM this weekend, and don't know KDE well, please can someone look at it?
OK, i've had a look in how locker works, we now have 3 options:
a) patch it: --- /usr/share/kde4/apps/ksmserver/screenlocker/org.kde.passworddialog/contents/ui/main.qml +++ /usr/share/kde4/apps/ksmserver/screenlocker/org.kde.passworddialog/contents/ui/main.qml @@ -42,6 +42,8 @@ Item { Image { id: background anchors.fill: parent + smooth: true + fillMode: Image.PreserveAspectFit source: theme.wallpaperPathForSize(parent.width, parent.height) }
b) adjust the metadata.desktop of our wallpaper package (remove the space in openSUSE default), as with space KDE seems can't detect wallpaper package properly. For this to make sense we then need to add following in plasma theme's metadata desktop: [Wallpaper] defaultWallpaperTheme=openSUSEdefault defaultFileSuffix=.jpg defaultWidth=1920 defaultHeight=1200
and also remove instances of defining default wallpapers in kdebase--openSUSE package (plasmarc/plasma-desktoprc files)
c) Remove the *full* path in plasma-desktoprc, which will still define wallpaper for workspaces and activities, but not for the locker. Locker would then have just a blackish background instead of wallpaper.
Note that a) and b) would require testing, in theory should improve situation, but i can't be 100% sure, as the locker looks fine for me without any of this adjustments.
https://github.com/openSUSE/branding/issues/18
Thank You!
Richard Branding Maintainer
Richard Brown Systems Engineering Team Leader City College Brighton and Hove
On Sunday 03 of February 2013 23:02:20 šumski wrote:
On Friday 01 of February 2013 12:53:46 Richard Brown wrote:
Hi team
Coolo has reported an issue with the KDE lock screen
As I'm busy with FOSDEM this weekend, and don't know KDE well, please can someone look at it?
OK, i've had a look in how locker works, we now have 3 options:
Forgot to mention (if it isn't obvious) that with b), if user changes the plasma theme, the default wallpaper wouldn't be used anymore, neither for plasma, or locker.
https://github.com/openSUSE/branding/issues/18
Thank You!
Richard Branding Maintainer
Richard Brown Systems Engineering Team Leader City College Brighton and Hove
On Sunday 03 February 2013 23:02:20 šumski wrote:
a) patch it: b) adjust the metadata.desktop of our wallpaper package (remove the space in openSUSE default), as with space KDE seems can't detect wallpaper package c) Remove the *full* path in plasma-desktoprc, which will still define
Hi Hrvoje,
What is your prefered method of resolving this ? Option C in my opinion would be the last resort if nothing else works, but maybe it is the best way.
So far it seems that we need to patch kdebase4-openSUSE regardless of the solution chosen. It would be good to do this in the next few days, so that we can submit the final version to 12.3/Factory. We have to keep in mind that the Pre-release freeze is tomorrow !
Thanks
Regards
Raymond
On Monday 04 of February 2013 08:23:57 Raymond Wooninck wrote:
On Sunday 03 February 2013 23:02:20 šumski wrote:
a) patch it: b) adjust the metadata.desktop of our wallpaper package (remove the space in openSUSE default), as with space KDE seems can't detect wallpaper package c) Remove the *full* path in plasma-desktoprc, which will still define
Hi Hrvoje,
What is your prefered method of resolving this ? Option C in my opinion would be the last resort if nothing else works, but maybe it is the best way.
Have the same feeling. If the patch resolves the issue, i'll create a review request in KDE's review board to try get it upstream, but as said, needs testing from someone who can reproduce the locker issue.
There is also an option d) which is a combination of b) and c) which would then leave the wallpaper in all situations except the locker, where it would fallback to Elarun wallpaper if the user changes plasma theme.
So far it seems that we need to patch kdebase4-openSUSE regardless of the solution chosen. It would be good to do this in the next few days, so that we can submit the final version to 12.3/Factory. We have to keep in mind that the Pre-release freeze is tomorrow !
Thanks
Regards
Raymond
On Monday 04 February 2013 12:53:27 šumski wrote:
Hi Hrvoje,
What is your prefered method of resolving this ? Option C in my opinion would be the last resort if nothing else works, but maybe it is the best way.
Have the same feeling. If the patch resolves the issue, i'll create a review request in KDE's review board to try get it upstream, but as said, needs testing from someone who can reproduce the locker issue.
As that Robert also agrees on this, let's not waste time and create a patch for this one. 4.10.0 has been submitted to Factory, but it is not too late to push in one small patch to resolve this issue.
Regards
Raymond
-
Raymond Wooninck -
Richard Brown -
šumski