New behavior affecting PR review approvals
Hi there, we recently changed a setting in GitHub affecting PR reviews and especially their approvals: Any approval on a PR for Uyuni (targeting the master branch) will now be dismissed in case additional changes are being pushed to it after it had been approved by a reviewer. This behavior is more accurate as an approval would always relate to the actual code in the PR. But everyone and especially community contributors should be aware that any subsequent small fix would dismiss a previous approval. If you are in this situation, please feel free to continue making more changes and once you are finished please re-request a review from the same person as before using the respective button in the UI (initial reviewers are assigned either by us or automatically). Please be mindful when issuing review requests and consider to bundle more changes before re-requesting a review. Many thanks for your understanding and happy hacking, Johannes -- Johannes Hahn - Engineering Manager SUSE Software Solutions Germany GmbH Frankenstraße 146 90461 Nürnberg Germany Managing Directors: Ivo Totev, Andrew McDonald, Werner Knoblich (HRB 36809, AG Nürnberg)
participants (1)
-
Johannes Hahn