AppleTalk atrtr_create missing write_unlock_bh
Hello, I found a possible missing unlock in the AppleTalk atrtr_create function. I believe it could be that kmalloc returns NULL which results into an missing unlock of atalk_routes_lock. Helmut Tschemernjak ----------- 2.6.9 diff -u patch for net/appletalk/dpp.c --------- --- ddp.c.sav 2004-11-15 17:31:30.091290400 +0100 +++ ddp.c 2004-11-16 09:50:38.631154808 +0100 @@ -570,7 +570,7 @@ retval = -ENOBUFS; if (!rt) - goto out; + goto out_unlock; memset(rt, 0, sizeof(*rt)); rt->next = atalk_routes;
On Tue, Nov 16, 2004 at 09:07:16AM +0100, Helmut Tschemernjak wrote:
Hello,
I found a possible missing unlock in the AppleTalk atrtr_create function. I believe it could be that kmalloc returns NULL which results into an missing unlock of atalk_routes_lock.
I believe it was just fixed in mainline, but I fixed it for SLES9 now too. Thanks. -Andi
participants (2)
-
Andi Kleen
-
Helmut Tschemernjak