Mailinglist Archive: zypp-devel (75 mails)
| < Previous | Next > |
[zypp-devel] Re: [zypp-commit] r10182 - in /trunk/libzypp: package/libzypp.changes zypp/Package.cc
- From: Michael Matz <matz@xxxxxxx>
- Date: Fri, 23 May 2008 11:17:51 +0200 (CEST)
- Message-id: <Pine.LNX.4.64.0805231114040.20583@xxxxxxxxxxxxx>
Hi,
On Fri, 23 May 2008, Duncan Mac-Vicar Prett wrote:
I don't think yum repos had the ChangeLogs. They are stored in other.xml,
and that wasn't downloaded IIRC.
I specifically remember that the memory was all taken up by the changelogs
of the installed packaged, and the sources looked exactly the same, i.e.
the function changelog() simply retrieved it from the rpm database.
Nevertheless it was read in completely, someone needs to make sure that
this doesn't happen anymore. Besides taking space it's also very slow
(seeking on the rpm database).
See above, I also didn't see it from just looking at the source, I also
expected it would be done on-demand. But someone called changelog() on
every package just for the fun of it, and I was very surprised that it
stayed in memory :-) Okay, we just need to make sure that this doesn't
happen anymore.
Ciao,
Michael.
--
To unsubscribe, e-mail: zypp-devel+unsubscribe@xxxxxxxxxxxx
For additional commands, e-mail: zypp-devel+help@xxxxxxxxxxxx
On Fri, 23 May 2008, Duncan Mac-Vicar Prett wrote:
That was because we parsed the changelogs for yum repositories, and had
it in the database (or in memory pre-10.3).
I don't think yum repos had the ChangeLogs. They are stored in other.xml,
and that wasn't downloaded IIRC.
This implementation only makes a rpm query to get the changelog
on-demand, and only for installed packages.
I specifically remember that the memory was all taken up by the changelogs
of the installed packaged, and the sources looked exactly the same, i.e.
the function changelog() simply retrieved it from the rpm database.
Nevertheless it was read in completely, someone needs to make sure that
this doesn't happen anymore. Besides taking space it's also very slow
(seeking on the rpm database).
I haven't tested memory usage, but I don't see why it should go up.
See above, I also didn't see it from just looking at the source, I also
expected it would be done on-demand. But someone called changelog() on
every package just for the fun of it, and I was very surprised that it
stayed in memory :-) Okay, we just need to make sure that this doesn't
happen anymore.
Ciao,
Michael.
--
To unsubscribe, e-mail: zypp-devel+unsubscribe@xxxxxxxxxxxx
For additional commands, e-mail: zypp-devel+help@xxxxxxxxxxxx
| < Previous | Next > |