[zypp-devel] Re: [zypp-commit] r10182 - in /trunk/libzypp: package/libzypp.changes zypp/Package.cc
Hi Duncan, On Thu, 22 May 2008, dmacvicar@svn.opensuse.org wrote:
Author: dmacvicar Date: Thu May 22 03:36:04 2008 New Revision: 10182
URL: http://svn.opensuse.org/viewcvs/zypp?rev=10182&view=rev Log: fix changelog retrieval for installed packages
Have you checked that memory use doesn't go through the roof again? The changelogs of installed packages was the single largest chunk of memory in old libzypp (10.3 era). Simply because it loaded all changelogs into memory during target initialization (i.e. not on demand). Ciao, Michael. -- To unsubscribe, e-mail: zypp-devel+unsubscribe@opensuse.org For additional commands, e-mail: zypp-devel+help@opensuse.org
Michael Matz wrote:
Hi Duncan,
On Thu, 22 May 2008, dmacvicar@svn.opensuse.org wrote:
Author: dmacvicar Date: Thu May 22 03:36:04 2008 New Revision: 10182
URL: http://svn.opensuse.org/viewcvs/zypp?rev=10182&view=rev Log: fix changelog retrieval for installed packages
Have you checked that memory use doesn't go through the roof again? The changelogs of installed packages was the single largest chunk of memory in old libzypp (10.3 era). Simply because it loaded all changelogs into memory during target initialization (i.e. not on demand).
Ciao, Michael.
That was because we parsed the changelogs for yum repositories, and had it in the database (or in memory pre-10.3). This implementation only makes a rpm query to get the changelog on-demand, and only for installed packages. I haven't tested memory usage, but I don't see why it should go up. It is like forking rpm -q --changelog package, but doing it using the rpm db directly. Duncan -- To unsubscribe, e-mail: zypp-devel+unsubscribe@opensuse.org For additional commands, e-mail: zypp-devel+help@opensuse.org
Hi, On Fri, 23 May 2008, Duncan Mac-Vicar Prett wrote:
That was because we parsed the changelogs for yum repositories, and had it in the database (or in memory pre-10.3).
I don't think yum repos had the ChangeLogs. They are stored in other.xml, and that wasn't downloaded IIRC.
This implementation only makes a rpm query to get the changelog on-demand, and only for installed packages.
I specifically remember that the memory was all taken up by the changelogs of the installed packaged, and the sources looked exactly the same, i.e. the function changelog() simply retrieved it from the rpm database. Nevertheless it was read in completely, someone needs to make sure that this doesn't happen anymore. Besides taking space it's also very slow (seeking on the rpm database).
I haven't tested memory usage, but I don't see why it should go up.
See above, I also didn't see it from just looking at the source, I also expected it would be done on-demand. But someone called changelog() on every package just for the fun of it, and I was very surprised that it stayed in memory :-) Okay, we just need to make sure that this doesn't happen anymore. Ciao, Michael. -- To unsubscribe, e-mail: zypp-devel+unsubscribe@opensuse.org For additional commands, e-mail: zypp-devel+help@opensuse.org
participants (2)
-
Duncan Mac-Vicar Prett -
Michael Matz