[zypp-devel] Re: [zypp-commit] r11408 - /trunk/libzypp/zypp/repo/PackageDelta.cc
On Monday 20 October 2008 15:30:48 kkaempf@svn.opensuse.org wrote:
Log: fix Dataiterator_init call
Modified: trunk/libzypp/zypp/repo/PackageDelta.cc
Modified: trunk/libzypp/zypp/repo/PackageDelta.cc URL: http://svn.opensuse.org/viewcvs/zypp/trunk/libzypp/zypp/repo/PackageDelta.c c?rev=11408&r1=11407&r2=11408&view=diff =========================================================================== === --- trunk/libzypp/zypp/repo/PackageDelta.cc (original) +++ trunk/libzypp/zypp/repo/PackageDelta.cc Mon Oct 20 15:30:48 2008 @@ -36,7 +36,7 @@ { MIL << "creating deltarpm from repo " << repo.alias() << ", id " << extraid << endl;
::Dataiterator di;
- ::dataiterator_init(&di, repo.get(), extraid, 0, 0, 0); + ::dataiterator_init(&di, NULL, repo.get(), extraid, 0, 0, 0);
Don't fix it that way. dataiterator_init segfaults with a NULL pool. -- cu, Michael Andres +------------------------------------------------------------------+ Key fingerprint = 2DFA 5D73 18B1 E7EF A862 27AC 3FB8 9E3A 27C6 B0E4 +------------------------------------------------------------------+ Michael Andres YaST Development ma@novell.com SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nuernberg) Maxfeldstrasse 5, D-90409 Nuernberg, Germany, ++49 (0)911 - 740 53-0 +------------------------------------------------------------------+ -- To unsubscribe, e-mail: zypp-devel+unsubscribe@opensuse.org For additional commands, e-mail: zypp-devel+help@opensuse.org
* Michael Andres
On Monday 20 October 2008 15:30:48 kkaempf@svn.opensuse.org wrote:
Log: fix Dataiterator_init call
Modified: trunk/libzypp/zypp/repo/PackageDelta.cc
Modified: trunk/libzypp/zypp/repo/PackageDelta.cc URL: http://svn.opensuse.org/viewcvs/zypp/trunk/libzypp/zypp/repo/PackageDelta.c c?rev=11408&r1=11407&r2=11408&view=diff =========================================================================== === --- trunk/libzypp/zypp/repo/PackageDelta.cc (original) +++ trunk/libzypp/zypp/repo/PackageDelta.cc Mon Oct 20 15:30:48 2008 @@ -36,7 +36,7 @@ { MIL << "creating deltarpm from repo " << repo.alias() << ", id " << extraid << endl;
::Dataiterator di;
- ::dataiterator_init(&di, repo.get(), extraid, 0, 0, 0); + ::dataiterator_init(&di, NULL, repo.get(), extraid, 0, 0, 0);
Don't fix it that way. dataiterator_init segfaults with a NULL pool.
Sorry. Then *please* lets fix dataiterator_init to get fetch repo->pool if pool is NULL. Klaus -- To unsubscribe, e-mail: zypp-devel+unsubscribe@opensuse.org For additional commands, e-mail: zypp-devel+help@opensuse.org
* Klaus Kaempf
* Michael Andres
[Oct 20. 2008 16:00]: On Monday 20 October 2008 15:30:48 kkaempf@svn.opensuse.org wrote:
Log: fix Dataiterator_init call
Modified: trunk/libzypp/zypp/repo/PackageDelta.cc
Modified: trunk/libzypp/zypp/repo/PackageDelta.cc URL: http://svn.opensuse.org/viewcvs/zypp/trunk/libzypp/zypp/repo/PackageDelta.c c?rev=11408&r1=11407&r2=11408&view=diff =========================================================================== === --- trunk/libzypp/zypp/repo/PackageDelta.cc (original) +++ trunk/libzypp/zypp/repo/PackageDelta.cc Mon Oct 20 15:30:48 2008 @@ -36,7 +36,7 @@ { MIL << "creating deltarpm from repo " << repo.alias() << ", id " << extraid << endl;
::Dataiterator di;
- ::dataiterator_init(&di, repo.get(), extraid, 0, 0, 0); + ::dataiterator_init(&di, NULL, repo.get(), extraid, 0, 0, 0);
Don't fix it that way. dataiterator_init segfaults with a NULL pool.
Sorry. Then *please* lets fix dataiterator_init to get fetch repo->pool if pool is NULL.
Fixed in satsolver/src/repodata.c Please have a look. Klaus -- To unsubscribe, e-mail: zypp-devel+unsubscribe@opensuse.org For additional commands, e-mail: zypp-devel+help@opensuse.org
On Mon, Oct 20, 2008 at 04:09:57PM +0200, Klaus Kaempf wrote:
Fixed in satsolver/src/repodata.c Please have a look.
I had a look and reverted your change. The dataiterator belongs conceptually to the pool class and thus needs the pool argument. M. -- To unsubscribe, e-mail: zypp-devel+unsubscribe@opensuse.org For additional commands, e-mail: zypp-devel+help@opensuse.org
On Monday 20 October 2008 17:39:16 Michael Schroeder wrote:
On Mon, Oct 20, 2008 at 04:09:57PM +0200, Klaus Kaempf wrote:
Fixed in satsolver/src/repodata.c Please have a look.
I had a look and reverted your change. The dataiterator belongs conceptually to the pool class and thus needs the pool argument.
And I already removed all the inserted NULL pool* within libzypp. So zypp should be clean. -- cu, Michael Andres +------------------------------------------------------------------+ Key fingerprint = 2DFA 5D73 18B1 E7EF A862 27AC 3FB8 9E3A 27C6 B0E4 +------------------------------------------------------------------+ Michael Andres YaST Development ma@novell.com SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nuernberg) Maxfeldstrasse 5, D-90409 Nuernberg, Germany, ++49 (0)911 - 740 53-0 +------------------------------------------------------------------+ -- To unsubscribe, e-mail: zypp-devel+unsubscribe@opensuse.org For additional commands, e-mail: zypp-devel+help@opensuse.org
participants (3)
-
Klaus Kaempf
-
Michael Andres
-
Michael Schroeder