[zypp-devel] satsolver: dataiterator_init needs Pool and Repo, why ?
Why does dataiterator_init() need a Pool and a Repo pointer ? The Pool pointer is already inside the Repo structure. Klaus --- SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) -- To unsubscribe, e-mail: zypp-devel+unsubscribe@opensuse.org For additional commands, e-mail: zypp-devel+help@opensuse.org
On Monday 20 October 2008 14:55:56 Klaus Kaempf wrote:
Why does dataiterator_init() need a Pool and a Repo pointer ?
The Pool pointer is already inside the Repo structure.
AFAIK it iterates all repos in case of a NULL repo ptr. For this it needs the pool. -- cu, Michael Andres +------------------------------------------------------------------+ Key fingerprint = 2DFA 5D73 18B1 E7EF A862 27AC 3FB8 9E3A 27C6 B0E4 +------------------------------------------------------------------+ Michael Andres YaST Development ma@novell.com SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nuernberg) Maxfeldstrasse 5, D-90409 Nuernberg, Germany, ++49 (0)911 - 740 53-0 +------------------------------------------------------------------+ -- To unsubscribe, e-mail: zypp-devel+unsubscribe@opensuse.org For additional commands, e-mail: zypp-devel+help@opensuse.org
Hi, On Mon, 20 Oct 2008, Michael Andres wrote:
On Monday 20 October 2008 14:55:56 Klaus Kaempf wrote:
Why does dataiterator_init() need a Pool and a Repo pointer ?
The Pool pointer is already inside the Repo structure.
AFAIK it iterates all repos in case of a NULL repo ptr. For this it needs the pool.
That was done with a flag before the change on the weekend. I liked that more than cluttering the API with an argument that is useless most of the time. Ciao, Michael. -- To unsubscribe, e-mail: zypp-devel+unsubscribe@opensuse.org For additional commands, e-mail: zypp-devel+help@opensuse.org
On Mon, Oct 20, 2008 at 03:02:53PM +0200, Michael Matz wrote:
That was done with a flag before the change on the weekend. I liked that more than cluttering the API with an argument that is useless most of the time.
Sorry, that flag was pretty brain-dead. M. -- To unsubscribe, e-mail: zypp-devel+unsubscribe@opensuse.org For additional commands, e-mail: zypp-devel+help@opensuse.org
* Michael Matz
Hi,
On Mon, 20 Oct 2008, Michael Andres wrote:
On Monday 20 October 2008 14:55:56 Klaus Kaempf wrote:
Why does dataiterator_init() need a Pool and a Repo pointer ?
The Pool pointer is already inside the Repo structure.
AFAIK it iterates all repos in case of a NULL repo ptr. For this it needs the pool.
That was done with a flag before the change on the weekend. I liked that more than cluttering the API with an argument that is useless most of the time.
Oh, good. Next time, please put a comment to the .h or the .c file ... Klaus -- To unsubscribe, e-mail: zypp-devel+unsubscribe@opensuse.org For additional commands, e-mail: zypp-devel+help@opensuse.org
On Mon, Oct 20, 2008 at 02:55:56PM +0200, Klaus Kaempf wrote:
Why does dataiterator_init() need a Pool and a Repo pointer ?
The Pool pointer is already inside the Repo structure.
Nope. Repo can be NULL. M. -- To unsubscribe, e-mail: zypp-devel+unsubscribe@opensuse.org For additional commands, e-mail: zypp-devel+help@opensuse.org
participants (4)
-
Klaus Kaempf -
Michael Andres -
Michael Matz -
Michael Schroeder