[yast-devel] Re: [yast-installation] Call hooks for installation clients (#107)
On 12/03/2013 10:44 AM, vmoravec wrote:
This is the UI widget that is displayed right before the reboot dialog: hooks-ui-widget-with-results https://f.cloud.github.com/assets/1215576/1662430/e6e98fb0-5bfe-11e3-80e8-52...
If there are several hook files with output for a single hook checkpoint, there are concatenated into one line and separated by a semicolon.
It's a great idea to show summary of failed hooks at the end of installation. I would just tune it a bit and show the results ONLY if there were some issues. I'd skip everything that is not needed in case of success. Bye Lukas -- Lukas Ocilka, Yast TL, Cloud & Systems Management Department SUSE LINUX s.r.o., Praha -- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org To contact the owner, e-mail: yast-devel+owner@opensuse.org
Dne 3.12.2013 13:20, Lukas Ocilka napsal(a):
On 12/03/2013 10:44 AM, vmoravec wrote:
This is the UI widget that is displayed right before the reboot dialog: hooks-ui-widget-with-results https://f.cloud.github.com/assets/1215576/1662430/e6e98fb0-5bfe-11e3-80e8-52...
If there are several hook files with output for a single hook checkpoint, there are concatenated into one line and separated by a semicolon.
It's a great idea to show summary of failed hooks at the end of installation.
I would just tune it a bit and show the results ONLY if there were some issues. I'd skip everything that is not needed in case of success.
Originally I let the pop-up window show only in case there were some failed hooks, but I changed it for the reason that if the user makes the effort of creating one or several hook files and puts them into the installation system (which is not a trivial task and must be done without the user friendly GUI), he will/might expect some visual feedback about the results before the first boot. In the end one of the goals of the installer GUI is to let the user inform about the succeeded or failed steps during the installation. It's just a single click to let the pop-up go away and continue with reboot. I think that the hooks will be useful mainly for automated installations where admins will test them a lot before going into production. Then they can even expect some more detailed hooks summary during the hooks' testing using the GUI installer (number of hook files, names of files, execution time). Currently they have to dig through the yast logs to get more details. Vlado
Bye Lukas
Dne 4.12.2013 10:16, Vladimir Moravec napsal(a): [...]
feedback about the results before the first boot. In the end one of the goals of the installer GUI is to let the user inform about the succeeded or failed steps during the installation. It's just a single click to let the pop-up go away and continue with reboot.
Just a note: use functions from the Report module, they are AutoYast friendly (can be optionally disabled in contrast to the standard Popup module). -- Ladislav Slezák Appliance department / YaST Developer Lihovarská 1060/12 190 00 Prague 9 / Czech Republic tel: +420 284 028 960 lslezak@suse.com SUSE -- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org To contact the owner, e-mail: yast-devel+owner@opensuse.org
On Wed, Dec 04, 2013 at 11:45:01AM +0100, Ladislav Slezak wrote:
Dne 4.12.2013 10:16, Vladimir Moravec napsal(a): [...]
feedback about the results before the first boot. In the end one of the goals of the installer GUI is to let the user inform about the succeeded or failed steps during the installation. It's just a single click to let the pop-up go away and continue with reboot.
Just a note: use functions from the Report module, they are AutoYast friendly (can be optionally disabled in contrast to the standard Popup module).
can you please add a comment to Popup telling users that they most likely should use Report instead? It will then be also visible on http://www.rubydoc.info/github/yast/yast-yast2/Yast/PopupClass Perhaps also to the most used ones, #Message, #Warning, #Error See my WIP about AsciiFile: https://github.com/yast/yast-yast2/pull/149/files which is unfortunately not rendered on rubydoc (not in master) Yes, I could do it myself, but I want to draw attention to how to improve the docs ;-) -- Martin Vidner, Cloud & Systems Management Team http://en.opensuse.org/User:Mvidner Kuracke oddeleni v restauraci je jako fekalni oddeleni v bazenu
On 4.12.2013 10:16, Vladimir Moravec wrote:
Originally I let the pop-up window show only in case there were some failed hooks, but I changed it for the reason that if the user makes the effort of creating one or several hook files and puts them into the installation system (which is not a trivial task and must be done without the user friendly GUI), he will/might expect some visual feedback about the results before the first boot. In the end one of the goals of the installer GUI is to let the user inform about the succeeded or failed steps during the installation. It's just a single click to let the pop-up go away and continue with reboot.
Well, but that's exactly what he designer, PM and PjM don't want to: Having new pop-ups during installation. It's fine if this is configurable, e.g., on commandline (for debugging purpose) but the default has to be "silent". You can set whatever you want at the Linuxrc commandline while the installer is starting: http://en.opensuse.org/SDB:Linuxrc See (as an example) http://en.opensuse.org/SDB:Linuxrc#p_ignore_features how this is done for another Installer feature.
I think that the hooks will be useful mainly for automated installations where admins will test them a lot before going into production. Then they can even expect some more detailed hooks summary during the hooks' testing using the GUI installer (number of hook files, names of files, execution time). Currently they have to dig through the yast logs to get more details.
Hooks should be used both for automated installations and by add-ons. Both usually need to do something in background. Of course, having the information, for instance, persistent in some kind of logs is a very good idea - better than dumping all to /dev/null - and logs are copied to the installed system (it just needs to be checked which logs or extend the functionality). Bye Lukas -- Lukas Ocilka, Yast TL, Cloud & Systems Management Department SUSE LINUX s.r.o., Praha -- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org To contact the owner, e-mail: yast-devel+owner@opensuse.org
On 12/04/2013 12:00 PM, Lukas Ocilka wrote:
On 4.12.2013 10:16, Vladimir Moravec wrote:
Originally I let the pop-up window show only in case there were some failed hooks, but I changed it for the reason that if the user makes the effort of creating one or several hook files and puts them into the installation system (which is not a trivial task and must be done without the user friendly GUI), he will/might expect some visual feedback about the results before the first boot. In the end one of the goals of the installer GUI is to let the user inform about the succeeded or failed steps during the installation. It's just a single click to let the pop-up go away and continue with reboot.
Well, but that's exactly what he designer, PM and PjM don't want to: Having new pop-ups during installation. It's fine if this is configurable, e.g., on commandline (for debugging purpose) but the default has to be "silent".
You can set whatever you want at the Linuxrc commandline while the installer is starting: http://en.opensuse.org/SDB:Linuxrc
See (as an example) http://en.opensuse.org/SDB:Linuxrc#p_ignore_features how this is done for another Installer feature.
I think that the hooks will be useful mainly for automated installations where admins will test them a lot before going into production. Then they can even expect some more detailed hooks summary during the hooks' testing using the GUI installer (number of hook files, names of files, execution time). Currently they have to dig through the yast logs to get more details.
Hooks should be used both for automated installations and by add-ons. Both usually need to do something in background. Of course, having the information, for instance, persistent in some kind of logs is a very good idea - better than dumping all to /dev/null - and logs are copied to the installed system (it just needs to be checked which logs or extend the functionality).
I fully agree - no interactive information about succeeded hooks. It is fine to log a summary of hooks which were executed - so that one can easily find if some hooks were not executed at all (e.g. because of a typo in the file name), but one should not bother users. After all, the end-user, installing the system, does not care whether there are any hooks run in the workflow, caused e.g. by a DUD. My suggestion: - log when executing a hook, including the result - show an error pop-up in case of failing hook - (*) log full stdout / stderr of the hook - at the end, log summary of executed hooks - show error in case of failed hooks (*) perhaps only for y2debug? Jiri -- Regards, Jiri Srain Project Manager --------------------------------------------------------------------- SUSE LINUX, s.r.o. e-mail: jsrain@suse.com Lihovarska 1060/12 tel: +420 284 084 659 190 00 Praha 9 fax: +420 284 084 001 Czech Republic http://www.suse.com -- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org To contact the owner, e-mail: yast-devel+owner@opensuse.org
participants (5)
-
Jiri Srain -
Ladislav Slezak -
Lukas Ocilka -
Martin Vidner -
Vladimir Moravec