March 2019 - YaST Development - openSUSE Mailing Lists

[yast-devel] Pending Pull Requests
by yast-ci＠opensuse.org 12 Mar '19

12 Mar '19

This email is automatic generated from yast CI node. It lists of pull requests that have no activity more then three working days. If your module is listed, please check all pull request, why they are not merged yet. Pending requests in repository yast-bootloader: - Not crash with internal error when grub install device not found (59 days) https://github.com/yast/yast-bootloader/pull/548 - Secure boot arm (108 days) https://github.com/yast/yast-bootloader/pull/544 - patch to not show popup when editenv list failed (178 days) https://github.com/yast/yast-bootloader/pull/537 - [no merge] More logging sle12 (265 days) https://github.com/yast/yast-bootloader/pull/523 Pending requests in repository yast-country: - Keyboard rewrite: encapsulate systemd actions (72 days) https://github.com/yast/yast-country/pull/200 - Keyboard rewrite: add documentation and license information (109 days) https://github.com/yast/yast-country/pull/199 - Keyboard rewrite: fix error setting x11 keymap (109 days) https://github.com/yast/yast-country/pull/198 - Keyboard rewrite: add more layouts to the module (109 days) https://github.com/yast/yast-country/pull/197 - Keyboard rewrite: select current layout on startup (109 days) https://github.com/yast/yast-country/pull/196 - Keyboard rewrite: Use strategy pattern to avoid coupling (109 days) https://github.com/yast/yast-country/pull/195 - Keyboard rewrite: Add rubocop (109 days) https://github.com/yast/yast-country/pull/174 - Keyboard rewrite: Test keyboard layout before change it (109 days) https://github.com/yast/yast-country/pull/173 - Keyboard rewrite: Change keyboard layout (109 days) https://github.com/yast/yast-country/pull/168 - Keyboard rewrite: Load keyboard layouts (109 days) https://github.com/yast/yast-country/pull/144 Pending requests in repository yast-devtools: - [RFC] Update the Rubocop config to version 0.59.2 (133 days) https://github.com/yast/yast-devtools/pull/134 Pending requests in repository yast-http-server: - Merged SLE-12-SP4 (17 days) https://github.com/yast/yast-http-server/pull/40 Pending requests in repository yast-installation: - Demo: eager mode of zombie-killer 0.5 (123 days) https://github.com/yast/yast-installation/pull/761 - Sp4 merge (285 days) https://github.com/yast/yast-installation/pull/708 Pending requests in repository yast-mail: - bsc#105491 setup of postfix with amavis DKIM signing does not work at all (137 days) https://github.com/yast/yast-mail/pull/37 Pending requests in repository yast-network: - [RFC] Create a backup of the modified interface and restore if canceled (15 days) https://github.com/yast/yast-network/pull/728 - [WIP] AutoYaST change the way the profile is intepreted (269 days) https://github.com/yast/yast-network/pull/646 - [RFC] Udev rule preparations (270 days) https://github.com/yast/yast-network/pull/639 - Fixed Internal Error on 'yast remote allow set=yes' (269 days) https://github.com/yast/yast-network/pull/635 - [WIP] Stop systemd socket associated services and ask for installing firewalld service definition (322 days) https://github.com/yast/yast-network/pull/624 - [WIP] Drop replace direct access to LanItems::Items whenever it is possible. (293 days) https://github.com/yast/yast-network/pull/588 Pending requests in repository yast-printer: - Security Audit Fixes: Hardening for Calling External Commands (83 days) https://github.com/yast/yast-printer/pull/23 Pending requests in repository yast-proxy: - Replace novell sites by SUSE ones for testing (bsc#1100366) (248 days) https://github.com/yast/yast-proxy/pull/19 ERROR: API query limit exceeded -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org To contact the owner, e-mail: yast-devel+owner(a)opensuse.org

1 0

[yast-devel] 389-ds and ldap maintainer in yast
by William Brown 11 Mar '19

11 Mar '19

Hi, I’m a new software engineer at suse labs. I was wondering who was involved in the YAST development of the LDAP module so I could talk to them about the integration to learn more about it? Thanks! — Sincerely, William Brown Software Engineer, 389 Directory Server SUSE Labs -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org To contact the owner, e-mail: yast-devel+owner(a)opensuse.org

3 4

[yast-devel] Pending Pull Requests
by yast-ci＠opensuse.org 11 Mar '19

11 Mar '19

This email is automatic generated from yast CI node. It lists of pull requests that have no activity more then three working days. If your module is listed, please check all pull request, why they are not merged yet. Pending requests in repository yast-bootloader: - Not crash with internal error when grub install device not found (58 days) https://github.com/yast/yast-bootloader/pull/548 - Secure boot arm (107 days) https://github.com/yast/yast-bootloader/pull/544 - patch to not show popup when editenv list failed (177 days) https://github.com/yast/yast-bootloader/pull/537 - [no merge] More logging sle12 (264 days) https://github.com/yast/yast-bootloader/pull/523 Pending requests in repository yast-country: - Keyboard rewrite: encapsulate systemd actions (71 days) https://github.com/yast/yast-country/pull/200 - Keyboard rewrite: add documentation and license information (108 days) https://github.com/yast/yast-country/pull/199 - Keyboard rewrite: fix error setting x11 keymap (108 days) https://github.com/yast/yast-country/pull/198 - Keyboard rewrite: add more layouts to the module (108 days) https://github.com/yast/yast-country/pull/197 - Keyboard rewrite: select current layout on startup (108 days) https://github.com/yast/yast-country/pull/196 - Keyboard rewrite: Use strategy pattern to avoid coupling (108 days) https://github.com/yast/yast-country/pull/195 - Keyboard rewrite: Add rubocop (108 days) https://github.com/yast/yast-country/pull/174 - Keyboard rewrite: Test keyboard layout before change it (108 days) https://github.com/yast/yast-country/pull/173 - Keyboard rewrite: Change keyboard layout (108 days) https://github.com/yast/yast-country/pull/168 - Keyboard rewrite: Load keyboard layouts (108 days) https://github.com/yast/yast-country/pull/144 Pending requests in repository yast-devtools: - [RFC] Update the Rubocop config to version 0.59.2 (132 days) https://github.com/yast/yast-devtools/pull/134 Pending requests in repository yast-http-server: - Merged SLE-12-SP4 (16 days) https://github.com/yast/yast-http-server/pull/40 Pending requests in repository yast-installation: - Demo: eager mode of zombie-killer 0.5 (122 days) https://github.com/yast/yast-installation/pull/761 - Sp4 merge (284 days) https://github.com/yast/yast-installation/pull/708 Pending requests in repository yast-mail: - bsc#105491 setup of postfix with amavis DKIM signing does not work at all (136 days) https://github.com/yast/yast-mail/pull/37 Pending requests in repository yast-network: - [RFC] Create a backup of the modified interface and restore if canceled (14 days) https://github.com/yast/yast-network/pull/728 - [WIP] AutoYaST change the way the profile is intepreted (268 days) https://github.com/yast/yast-network/pull/646 - [RFC] Udev rule preparations (269 days) https://github.com/yast/yast-network/pull/639 - Fixed Internal Error on 'yast remote allow set=yes' (268 days) https://github.com/yast/yast-network/pull/635 - [WIP] Stop systemd socket associated services and ask for installing firewalld service definition (321 days) https://github.com/yast/yast-network/pull/624 - [WIP] Drop replace direct access to LanItems::Items whenever it is possible. (292 days) https://github.com/yast/yast-network/pull/588 Pending requests in repository yast-printer: - Security Audit Fixes: Hardening for Calling External Commands (82 days) https://github.com/yast/yast-printer/pull/23 Pending requests in repository yast-proxy: - Replace novell sites by SUSE ones for testing (bsc#1100366) (247 days) https://github.com/yast/yast-proxy/pull/19 Pending requests in repository yast-python-bindings: - Update documentation to be useful (34 days) https://github.com/yast/yast-python-bindings/pull/25 ERROR: API query limit exceeded -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org To contact the owner, e-mail: yast-devel+owner(a)opensuse.org

1 0

[yast-devel] Pending Pull Requests
by yast-ci＠opensuse.org 08 Mar '19

08 Mar '19

This email is automatic generated from yast CI node. It lists of pull requests that have no activity more then three working days. If your module is listed, please check all pull request, why they are not merged yet. Pending requests in repository yast-bootloader: - Not crash with internal error when grub install device not found (55 days) https://github.com/yast/yast-bootloader/pull/548 - Secure boot arm (104 days) https://github.com/yast/yast-bootloader/pull/544 - patch to not show popup when editenv list failed (174 days) https://github.com/yast/yast-bootloader/pull/537 - [no merge] More logging sle12 (261 days) https://github.com/yast/yast-bootloader/pull/523 Pending requests in repository yast-country: - Keyboard rewrite: encapsulate systemd actions (68 days) https://github.com/yast/yast-country/pull/200 - Keyboard rewrite: add documentation and license information (105 days) https://github.com/yast/yast-country/pull/199 - Keyboard rewrite: fix error setting x11 keymap (105 days) https://github.com/yast/yast-country/pull/198 - Keyboard rewrite: add more layouts to the module (105 days) https://github.com/yast/yast-country/pull/197 - Keyboard rewrite: select current layout on startup (105 days) https://github.com/yast/yast-country/pull/196 - Keyboard rewrite: Use strategy pattern to avoid coupling (105 days) https://github.com/yast/yast-country/pull/195 - Keyboard rewrite: Add rubocop (105 days) https://github.com/yast/yast-country/pull/174 - Keyboard rewrite: Test keyboard layout before change it (105 days) https://github.com/yast/yast-country/pull/173 - Keyboard rewrite: Change keyboard layout (105 days) https://github.com/yast/yast-country/pull/168 - Keyboard rewrite: Load keyboard layouts (105 days) https://github.com/yast/yast-country/pull/144 Pending requests in repository yast-devtools: - [RFC] Update the Rubocop config to version 0.59.2 (129 days) https://github.com/yast/yast-devtools/pull/134 Pending requests in repository yast-http-server: - Merged SLE-12-SP4 (13 days) https://github.com/yast/yast-http-server/pull/40 Pending requests in repository yast-installation: - Demo: eager mode of zombie-killer 0.5 (119 days) https://github.com/yast/yast-installation/pull/761 - Sp4 merge (281 days) https://github.com/yast/yast-installation/pull/708 Pending requests in repository yast-mail: - bsc#105491 setup of postfix with amavis DKIM signing does not work at all (133 days) https://github.com/yast/yast-mail/pull/37 Pending requests in repository yast-network: - [RFC] Create a backup of the modified interface and restore if canceled (11 days) https://github.com/yast/yast-network/pull/728 - [WIP] AutoYaST change the way the profile is intepreted (265 days) https://github.com/yast/yast-network/pull/646 - [RFC] Udev rule preparations (266 days) https://github.com/yast/yast-network/pull/639 - Fixed Internal Error on 'yast remote allow set=yes' (265 days) https://github.com/yast/yast-network/pull/635 - [WIP] Stop systemd socket associated services and ask for installing firewalld service definition (318 days) https://github.com/yast/yast-network/pull/624 - [WIP] Drop replace direct access to LanItems::Items whenever it is possible. (289 days) https://github.com/yast/yast-network/pull/588 Pending requests in repository yast-printer: - Security Audit Fixes: Hardening for Calling External Commands (79 days) https://github.com/yast/yast-printer/pull/23 Pending requests in repository yast-proxy: - Replace novell sites by SUSE ones for testing (bsc#1100366) (244 days) https://github.com/yast/yast-proxy/pull/19 Pending requests in repository yast-python-bindings: - Update documentation to be useful (31 days) https://github.com/yast/yast-python-bindings/pull/25 ERROR: API query limit exceeded -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org To contact the owner, e-mail: yast-devel+owner(a)opensuse.org

1 0

[yast-devel] Pending Pull Requests
by yast-ci＠opensuse.org 07 Mar '19

07 Mar '19

This email is automatic generated from yast CI node. It lists of pull requests that have no activity more then three working days. If your module is listed, please check all pull request, why they are not merged yet. Pending requests in repository yast-bootloader: - Not crash with internal error when grub install device not found (54 days) https://github.com/yast/yast-bootloader/pull/548 - Secure boot arm (103 days) https://github.com/yast/yast-bootloader/pull/544 - patch to not show popup when editenv list failed (173 days) https://github.com/yast/yast-bootloader/pull/537 - [no merge] More logging sle12 (260 days) https://github.com/yast/yast-bootloader/pull/523 Pending requests in repository yast-country: - Keyboard rewrite: encapsulate systemd actions (67 days) https://github.com/yast/yast-country/pull/200 - Keyboard rewrite: add documentation and license information (104 days) https://github.com/yast/yast-country/pull/199 - Keyboard rewrite: fix error setting x11 keymap (104 days) https://github.com/yast/yast-country/pull/198 - Keyboard rewrite: add more layouts to the module (104 days) https://github.com/yast/yast-country/pull/197 - Keyboard rewrite: select current layout on startup (104 days) https://github.com/yast/yast-country/pull/196 - Keyboard rewrite: Use strategy pattern to avoid coupling (104 days) https://github.com/yast/yast-country/pull/195 - Keyboard rewrite: Add rubocop (104 days) https://github.com/yast/yast-country/pull/174 - Keyboard rewrite: Test keyboard layout before change it (104 days) https://github.com/yast/yast-country/pull/173 - Keyboard rewrite: Change keyboard layout (104 days) https://github.com/yast/yast-country/pull/168 - Keyboard rewrite: Load keyboard layouts (104 days) https://github.com/yast/yast-country/pull/144 Pending requests in repository yast-devtools: - [RFC] Update the Rubocop config to version 0.59.2 (128 days) https://github.com/yast/yast-devtools/pull/134 Pending requests in repository yast-http-server: - Merged SLE-12-SP4 (12 days) https://github.com/yast/yast-http-server/pull/40 Pending requests in repository yast-installation: - Demo: eager mode of zombie-killer 0.5 (118 days) https://github.com/yast/yast-installation/pull/761 - Sp4 merge (280 days) https://github.com/yast/yast-installation/pull/708 Pending requests in repository yast-mail: - bsc#105491 setup of postfix with amavis DKIM signing does not work at all (132 days) https://github.com/yast/yast-mail/pull/37 Pending requests in repository yast-network: - [RFC] First impressions of the current network configuration status (9 days) https://github.com/yast/yast-network/pull/729 - [RFC] Create a backup of the modified interface and restore if canceled (10 days) https://github.com/yast/yast-network/pull/728 - [WIP] AutoYaST change the way the profile is intepreted (264 days) https://github.com/yast/yast-network/pull/646 - [RFC] Udev rule preparations (265 days) https://github.com/yast/yast-network/pull/639 - Fixed Internal Error on 'yast remote allow set=yes' (264 days) https://github.com/yast/yast-network/pull/635 - [WIP] Stop systemd socket associated services and ask for installing firewalld service definition (317 days) https://github.com/yast/yast-network/pull/624 - [WIP] Drop replace direct access to LanItems::Items whenever it is possible. (288 days) https://github.com/yast/yast-network/pull/588 Pending requests in repository yast-packager: - Correct english wording for missing patterns (bsc#1117535) (6 days) https://github.com/yast/yast-packager/pull/405 Pending requests in repository yast-printer: - Security Audit Fixes: Hardening for Calling External Commands (78 days) https://github.com/yast/yast-printer/pull/23 Pending requests in repository yast-proxy: - Replace novell sites by SUSE ones for testing (bsc#1100366) (243 days) https://github.com/yast/yast-proxy/pull/19 ERROR: API query limit exceeded -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org To contact the owner, e-mail: yast-devel+owner(a)opensuse.org

1 0

[yast-devel] openSUSE Feature requests. Was: Fwd: [opensuse-factory] YaST: highlights of development sprint 71 and 72
by Ancor Gonzalez Sosa 06 Mar '19

06 Mar '19

Another forward from a different mailing list about a topic we could need to discuss. In the YaST team we used to get the SUSE feature requests via Fate and now we get them via Jira. But on the openSUSE side, the old mechanism used for that (the public Fate instance at features.opensuse.org) was declared dead long time ago. As you can see below in the mail I'm forwarding, the official position of the project is: "In openSUSE we try to stay as close to upstream as possible as such it makes far more sense to request features upstream. In this case upstream YaST development. In other cases directly into KDE's Phab instance if that's their preferred way." So people asking for new YaST features are encouraged to do it whatever mechanism is used by "upstream YaST" for managing those request. But, what would be that? SUSE's Jira instance is not public. Should we encourage people to use Bugzilla also for feature requests? Or maybe opening an issue in any of our Github repositories? Cheers. -------- Forwarded Message -------- Subject: Re: [opensuse-factory] YaST: highlights of development sprint 71 and 72 Date: Tue, 5 Mar 2019 10:06:38 +1030 From: Simon Lees <sflees(a)suse.de> To: opensuse-factory(a)opensuse.org On 05/03/2019 00:08, Vojtěch Zeisek wrote: > Dne pondělí 4. března 2019 14:24:28 CET, Richard Brown napsal(a): >> On Mon, 4 Mar 2019 at 13:56, Vojtěch Zeisek >> <vojtech.zeisek(a)opensuse.org> wrote: >>>>>> That's a good question. I don't know. >>>>>> In openSUSE we still don't have a replacement for Fate. >>>>> >>>>> Is openFATE officially dead? >>>>> https://features.opensuse.org/ >>>> >>>> Yes, it has been for quite some time already (I don't have the >>>> announcements about it at hand, but they should be easily findable). >>> >>> From https://features.opensuse.org/ >>> Disclaimer: >>> Dear visitor, please be advised that this page is outdated and >>> dysfunctional in parts and will be discontinued. If you are interested >>> in how to propose features for the openSUSE Project, then please join >>> the according discussions on our mailinglists. >>> For proposing new features in the openSUSE distributions, you can >>> use the opensuse-factory mailinglist. For project-related topics, >>> the opensuse-project mailinglist is a good place to start with. >>> See also https://en.opensuse.org/openSUSE:Openfate and links there >> >> Given that across entire project, it was very rare for anyone to do >> anything based on an openFATE request, yes, the Board approved its >> removal. > > IMHO, in such case, it should be removed, as on-line tool which is not working > properly is confusing and not good mark of the project organization state. > This is on the Hero's todo list, I believe they plan to give a final warning soon so people have a chance to extract any data they care about and then it will be closed. >> So for topics like this, we'd recommend using this mailinglist, or >> maybe more specific lists when they exist (eg. opensuse-kubic@, >> yast-devel@, etc) for any discussions needed to refine a feature idea. >> And once an idea is accepted by someone to be implemented, the Board >> don't presume to recommend which tool(s) those contributors should use >> for tracking their own planned work. >> I'm a fan of post-it notes ;) > > What I like(d) about the openFATE is that it is one central place where one > could easily see everything (lists, tags, filtration, notifications, tracing, > ...). In ML such topics are easily lost among other conversation and hard to > find later. What's wrong about requiring something like openFATE to be used to > trace features, their state, etc. (I know it only from user's perspective, not > from developer's)? See e.g. https://phabricator.kde.org/ > One of the problems is we have very few features that should be implemented in openSUSE itself, in openSUSE we try to stay as close to upstream as possible as such it makes far more sense to request features upstream, in this case upstream yast development, in other cases directly into kde's phab instance if that's there preferred way. For the things where openSUSE is the upstream we tend to keep the code in github and you can report an issue there. Cheers -- Simon Lees (Simotek) http://simotek.net Emergency Update Team keybase.io/simotek SUSE Linux Adelaide Australia, UTC+10:30 GPG Fingerprint: 5B87 DB9D 88DC F606 E489 CEC5 0922 C246 02F0 014B -- To unsubscribe, e-mail: opensuse-factory+unsubscribe(a)opensuse.org To contact the owner, e-mail: opensuse-factory+owner(a)opensuse.org -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org To contact the owner, e-mail: yast-devel+owner(a)opensuse.org

2 1

[yast-devel] Pending Pull Requests
by yast-ci＠opensuse.org 06 Mar '19

06 Mar '19

This email is automatic generated from yast CI node. It lists of pull requests that have no activity more then three working days. If your module is listed, please check all pull request, why they are not merged yet. Pending requests in repository yast-bootloader: - Not crash with internal error when grub install device not found (53 days) https://github.com/yast/yast-bootloader/pull/548 - Secure boot arm (102 days) https://github.com/yast/yast-bootloader/pull/544 - patch to not show popup when editenv list failed (172 days) https://github.com/yast/yast-bootloader/pull/537 - [no merge] More logging sle12 (259 days) https://github.com/yast/yast-bootloader/pull/523 Pending requests in repository yast-country: - Keyboard rewrite: encapsulate systemd actions (66 days) https://github.com/yast/yast-country/pull/200 - Keyboard rewrite: add documentation and license information (103 days) https://github.com/yast/yast-country/pull/199 - Keyboard rewrite: fix error setting x11 keymap (103 days) https://github.com/yast/yast-country/pull/198 - Keyboard rewrite: add more layouts to the module (103 days) https://github.com/yast/yast-country/pull/197 - Keyboard rewrite: select current layout on startup (103 days) https://github.com/yast/yast-country/pull/196 - Keyboard rewrite: Use strategy pattern to avoid coupling (103 days) https://github.com/yast/yast-country/pull/195 - Keyboard rewrite: Add rubocop (103 days) https://github.com/yast/yast-country/pull/174 - Keyboard rewrite: Test keyboard layout before change it (103 days) https://github.com/yast/yast-country/pull/173 - Keyboard rewrite: Change keyboard layout (103 days) https://github.com/yast/yast-country/pull/168 - Keyboard rewrite: Load keyboard layouts (103 days) https://github.com/yast/yast-country/pull/144 Pending requests in repository yast-devtools: - [RFC] Update the Rubocop config to version 0.59.2 (127 days) https://github.com/yast/yast-devtools/pull/134 Pending requests in repository yast-http-server: - Merged SLE-12-SP4 (11 days) https://github.com/yast/yast-http-server/pull/40 Pending requests in repository yast-installation: - Do not write displaymanager value (5 days) https://github.com/yast/yast-installation/pull/775 - Demo: eager mode of zombie-killer 0.5 (117 days) https://github.com/yast/yast-installation/pull/761 - Sp4 merge (279 days) https://github.com/yast/yast-installation/pull/708 Pending requests in repository yast-mail: - bsc#105491 setup of postfix with amavis DKIM signing does not work at all (131 days) https://github.com/yast/yast-mail/pull/37 Pending requests in repository yast-network: - [RFC] First impressions of the current network configuration status (8 days) https://github.com/yast/yast-network/pull/729 - [RFC] Create a backup of the modified interface and restore if canceled (9 days) https://github.com/yast/yast-network/pull/728 - [WIP] AutoYaST change the way the profile is intepreted (263 days) https://github.com/yast/yast-network/pull/646 - [RFC] Udev rule preparations (264 days) https://github.com/yast/yast-network/pull/639 - Fixed Internal Error on 'yast remote allow set=yes' (263 days) https://github.com/yast/yast-network/pull/635 - [WIP] Stop systemd socket associated services and ask for installing firewalld service definition (316 days) https://github.com/yast/yast-network/pull/624 - [WIP] Drop replace direct access to LanItems::Items whenever it is possible. (287 days) https://github.com/yast/yast-network/pull/588 Pending requests in repository yast-packager: - Correct english wording for missing patterns (bsc#1117535) (5 days) https://github.com/yast/yast-packager/pull/405 Pending requests in repository yast-printer: - Security Audit Fixes: Hardening for Calling External Commands (77 days) https://github.com/yast/yast-printer/pull/23 Pending requests in repository yast-proxy: - Replace novell sites by SUSE ones for testing (bsc#1100366) (242 days) https://github.com/yast/yast-proxy/pull/19 ERROR: API query limit exceeded -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org To contact the owner, e-mail: yast-devel+owner(a)opensuse.org

1 0

[yast-devel] The YaST gettext translation functions return frozen String now
by Ladislav Slezak 05 Mar '19

05 Mar '19

Hi all, related to the previous discussion about "can't modify frozen String" inconsistency I have updated the yast2-ruby-bindings package to always return a frozen String from the gettext translation functions regardless a translation is found or not. This should avoid some bugs in the code and make the unit tests more reliable. There is one tricky part: it freezes the passed argument, but as discussed before, this should not be a real issue. Applies to SLE15-SP1, Leap 15.1 and Factory/Tumbleweed. See the details in https://github.com/yast/yast-ruby-bindings/pull/228 -- Ladislav Slezák YaST Developer SUSE LINUX, s.r.o. Corso IIa Křižíkova 148/34 18600 Praha 8 -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org To contact the owner, e-mail: yast-devel+owner(a)opensuse.org

1 0

[yast-devel] "can't modify frozen String" and ruby-bindings
by Ladislav Slezak 05 Mar '19

05 Mar '19

Hi all, I was fixing a "can't modify frozen String" crash in YaST registration when processing a translated string. After debugging and trying to write an unit test for it I found an interesting difference: it depends whether the translation for the message is available or not. Translation Available --------------------- > rpm -q yast2-trans-cs yast2-trans-cs-84.87.20180514.157a0650d-lp150.1.1.noarch > LC_ALL=cs_CZ.UTF-8 ruby -ryast -e 'include Yast::I18n; textdomain "base"; puts _("&Yes"); puts _("&Yes").frozen?' &Ano true So the result is a *frozen* translated string. The code would crash in this case. Translation Not Available ------------------------- > rpm -q yast2-trans-es package yast2-trans-es is not installed > LC_ALL=es_ES.UTF-8 ruby -ryast -e 'include Yast::I18n; textdomain "base"; puts _("&Yes"); puts _("&Yes").frozen?' &Yes false In this case you'll get the original untranslated and *not frozen* string. In this case it would NOT crash. :-S The Problem ----------- The problem is that when running the unit tests in Travis, Jenkins or in OBS no translation is installed and the tests run in the English locale. However, on user systems or during installation the translations are usually available. That means it's hard to test it in the same environment, the unit tests might not find this problem in the code. Moreover the translations for new texts might be available later, so it could work fine but crash later after updating the translation package without changing the YaST module. That's a debugging nightmare... Proposed Solution ----------------- The ruby-bindings code contains this line [1]: found ? Translation._(str) : str The fast_gettext gem returns nil when the translation is not available. In that case we return the original text. My proposed solution is to also freeze the not translated message to have consistent output: found ? Translation._(str) : str.freeze The Disadvantage ---------------- The disadvantage is that as a side effect of this change the passed parameter will be modified (becomes frozen), like this: a = "text" a.frozen? # => false puts _(a) a.frozen? # => true Usually that should not make any troubles as we either use string literals _("foo") or we use constants which should be preferably frozen anyway: TEXT = N_("foo") ... _(TEXT) (Or at least I'm not aware of any place where it would make troubles.) Of course, we could duplicate the string to not modify the original one: found ? Translation._(str) : str.dup.freeze but I'm afraid this would have memory and performance impact as all not translated strings would be duplicated. So I'd prefer the first solution and if you need to avoid freezing the original string you can make the copy yourselves, e.g.: puts _(a.dup) a.frozen? # => false (Or course this behavior and the solution needs to be well documented.) Any comments or ideas to this topic? Thank you! [1] https://github.com/yast/yast-ruby-bindings/blob/4652448963160abc234d1199f06… -- Ladislav Slezák YaST Developer SUSE LINUX, s.r.o. Corso IIa Křižíkova 148/34 18600 Praha 8 -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org To contact the owner, e-mail: yast-devel+owner(a)opensuse.org

2 4

[yast-devel] Pending Pull Requests
by yast-ci＠opensuse.org 05 Mar '19

05 Mar '19

This email is automatic generated from yast CI node. It lists of pull requests that have no activity more then three working days. If your module is listed, please check all pull request, why they are not merged yet. Pending requests in repository yast-bootloader: - Not crash with internal error when grub install device not found (52 days) https://github.com/yast/yast-bootloader/pull/548 - Secure boot arm (101 days) https://github.com/yast/yast-bootloader/pull/544 - patch to not show popup when editenv list failed (171 days) https://github.com/yast/yast-bootloader/pull/537 - [no merge] More logging sle12 (258 days) https://github.com/yast/yast-bootloader/pull/523 Pending requests in repository yast-country: - Keyboard rewrite: encapsulate systemd actions (65 days) https://github.com/yast/yast-country/pull/200 - Keyboard rewrite: add documentation and license information (102 days) https://github.com/yast/yast-country/pull/199 - Keyboard rewrite: fix error setting x11 keymap (102 days) https://github.com/yast/yast-country/pull/198 - Keyboard rewrite: add more layouts to the module (102 days) https://github.com/yast/yast-country/pull/197 - Keyboard rewrite: select current layout on startup (102 days) https://github.com/yast/yast-country/pull/196 - Keyboard rewrite: Use strategy pattern to avoid coupling (102 days) https://github.com/yast/yast-country/pull/195 - Keyboard rewrite: Add rubocop (102 days) https://github.com/yast/yast-country/pull/174 - Keyboard rewrite: Test keyboard layout before change it (102 days) https://github.com/yast/yast-country/pull/173 - Keyboard rewrite: Change keyboard layout (102 days) https://github.com/yast/yast-country/pull/168 - Keyboard rewrite: Load keyboard layouts (102 days) https://github.com/yast/yast-country/pull/144 Pending requests in repository yast-devtools: - [RFC] Update the Rubocop config to version 0.59.2 (126 days) https://github.com/yast/yast-devtools/pull/134 Pending requests in repository yast-http-server: - Merged SLE-12-SP4 (10 days) https://github.com/yast/yast-http-server/pull/40 Pending requests in repository yast-installation: - Demo: eager mode of zombie-killer 0.5 (116 days) https://github.com/yast/yast-installation/pull/761 - Sp4 merge (278 days) https://github.com/yast/yast-installation/pull/708 Pending requests in repository yast-mail: - bsc#105491 setup of postfix with amavis DKIM signing does not work at all (130 days) https://github.com/yast/yast-mail/pull/37 Pending requests in repository yast-network: - [RFC] First impressions of the current network configuration status (7 days) https://github.com/yast/yast-network/pull/729 - [RFC] Create a backup of the modified interface and restore if canceled (8 days) https://github.com/yast/yast-network/pull/728 - [WIP] AutoYaST change the way the profile is intepreted (262 days) https://github.com/yast/yast-network/pull/646 - [RFC] Udev rule preparations (263 days) https://github.com/yast/yast-network/pull/639 - Fixed Internal Error on 'yast remote allow set=yes' (262 days) https://github.com/yast/yast-network/pull/635 - [WIP] Stop systemd socket associated services and ask for installing firewalld service definition (315 days) https://github.com/yast/yast-network/pull/624 - [WIP] Drop replace direct access to LanItems::Items whenever it is possible. (286 days) https://github.com/yast/yast-network/pull/588 Pending requests in repository yast-printer: - Security Audit Fixes: Hardening for Calling External Commands (76 days) https://github.com/yast/yast-printer/pull/23 Pending requests in repository yast-proxy: - Replace novell sites by SUSE ones for testing (bsc#1100366) (241 days) https://github.com/yast/yast-proxy/pull/19 Pending requests in repository yast-python-bindings: - Update documentation to be useful (28 days) https://github.com/yast/yast-python-bindings/pull/25 ERROR: API query limit exceeded -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org To contact the owner, e-mail: yast-devel+owner(a)opensuse.org

1 0