September 2009 - YaST Development - openSUSE Mailing Lists

[yast-devel] Re: [yast-commit] <web-client> master : more readable
by Josef Reidinger 07 Sep '09

07 Sep '09

On 09/07/2009 01:05 PM, Stefan Schubert wrote: > ref: refs/heads/master > commit 32be3734b62d83a68169620cf8ebaa8b5f4908e8 > Author: Stefan Schubert <schubi(a)suse.de> > Date: Mon Sep 7 13:05:09 2009 +0200 > > more readable > --- > .../app/controllers/patch_updates_controller.rb | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/plugins/patch_updates/app/controllers/patch_updates_controller.rb b/plugins/patch_updates/app/controllers/patch_updates_controller.rb > index 4747342..10daa3e 100644 > --- a/plugins/patch_updates/app/controllers/patch_updates_controller.rb > +++ b/plugins/patch_updates/app/controllers/patch_updates_controller.rb > @@ -29,7 +29,7 @@ class PatchUpdatesController < ApplicationController > patches_summary = { :security => 0, :important => 0, :optional => 0} > > [:security, :important, :optional].each do |patch_type| > - patches_summary[patch_type] = patch_updates.collect { |p| p.kind == patch_type.to_s ? p : nil }.nitems > + patches_summary[patch_type] = patch_updates.find_all { |p| p.kind == patch_type.to_s }.size Hi, little note to efficiency. This code iterate through patch_updates three times, creates three array for which then get size. I think that better is iterate only once and add size to. So you can instead [:security, :important, :optional].each do |patch_type| patches_summary[patch_type] = patch_updates.find_all { |p| p.kind == patch_type.to_s }.size use (you already init it to zero in hash initializer) patch_updates.each { |pu| patches_summary[pu.kind.to_sym] += 1 } you get some result, efficienty and I think that it is has same readability. -- Josef Reidinger YaST team maintainer of perl-Bootloader, YaST2-Repair, webyast modules language and time -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] Starting Rails application in debugger
by Ladislav Slezak 04 Sep '09

04 Sep '09

Miso needed to start a Rails application in debugger some time ago, using 'debugger' keyword doesn't help if you want to debug application loading. Now I have found the correct way - call the debugger directly: cd web-client/webclient rdebug script/server -- --debugger (the application parameters are passed after -- options) Enjoy! :-) -- Best Regards Ladislav Slezák Yast Developer ------------------------------------------------------------------------ SUSE LINUX, s.r.o. e-mail: lslezak(a)suse.cz Lihovarská 1060/12 tel: +420 284 028 960 190 00 Prague 9 fax: +420 284 028 951 Czech Republic http://www.suse.cz/ -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] WebYaST status, 2009-Sep-04
by Klaus Kaempf 04 Sep '09

04 Sep '09

WebYaST 04-Sep-2009 =================== present: kkaempf, dmacvicar, schubi, mzugec, mvidner, jsrain, lslezak, bbrunner, jsuchome, visnov absent: fnadge, mschmidkunz Status: ----------- kkaempf: started to move todo list to bnc working on bnc#533178 (test environment set too late) dmacvicar: working system logs view, including 'live' ajax updates research on colorizing output eta 2009-sep-11 schubi: found easy way for vendor translations next: wiki documentation mzugec: network YaPI now reads real system data Next: improve test make 'index' function work mvidner: network module 'read only' done Next: improve test make 'index' function work jsrain: - lslezak: wrote test in services plugin next: document rest interface research on how others document such apis bbrunner: learning Next: set up KVM environment for testing virtual appliance jsuchome: created package next: service ui documentation visnov: - --- SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] TCP port for webyast?
by Martin Vidner 04 Sep '09

04 Sep '09

Hi, how long are we going to stay with 8080 and 3000? Wouldn't it be useful to decide before the next milestone? -- Martin Vidner, YaST developer http://en.opensuse.org/User:Mvidner Kuracke oddeleni v restauraci je jako fekalni oddeleni v bazenu -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

2 3

[yast-devel] first draft of webyast style guide
by Martin Schmidkunz 03 Sep '09

03 Sep '09

Hi, please find a first draft of a webYaST style guide at: http:// en.opensuse.org/YaST/Web/Docu/Style_Guide Is there anything missing? Or is there anything you would like to discuss? Looking forward to your comments! Thanks, Martin --- Martin Schmidkunz User Experience Specialist mschmidkunz(a)novell.com +49 (0) 911 740 53-346 --- SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) --- Novell® Making IT Work As One™

1 0

[yast-devel] TraditionalYaST: searching YaST modules by keywords
by Katarina Machalkova 03 Sep '09

03 Sep '09

YaST hackers, I've just finished implementing ground for feature #305845 [1], that is support for defining additional keywords for YaST module and querying those (in addition to module names) in (Qt4) control centre search. However, to put the feature really into practice, I need your help. It is very simple: all you have to do is to modify .desktop file(s) your YaST module ships by adding a new key-value pair to it. The key name is 'X-SuSE-YaST- Keywords' (to conform to xdg standards [2]) and its value is comma-separated list of words describing the function of the module. Example: [Desktop Entry] Type=Application //those you already have Name=Flinstones GenericName=Modern Stone Age Family //this you will need to add X-SuSE-YaST-Keywords=fred,wilma,barney,betty I'm sure you know best which keywords to put in in order to make it easier for the users to find the module :) Thanks for the cooperation. hB. [1] https://features.opensuse.org/305845 [2] http://standards.freedesktop.org/desktop-entry-spec/desktop-entry- spec-1.0.html -- \\\\\ Katarina Machalkova \\\\\\\__o YaST developer __\\\\\\\'/_ & hedgehog painter

2 2

[yast-devel] Re: [yast-commit] <rest-service> network : dns model shows xml list
by Josef Reidinger 03 Sep '09

03 Sep '09

On 09/03/2009 12:14 PM, Michal Zugec wrote: > ref: refs/heads/network > commit b72baab724ea256472be56efe577c9231df97881 > Author: Michal Zugec <mzugec(a)suse.cz> > Date: Thu Sep 3 12:14:49 2009 +0200 > > dns model shows xml list > --- > plugins/network/app/models/dns.rb | 14 +++++++++++--- > 1 files changed, 11 insertions(+), 3 deletions(-) > > diff --git a/plugins/network/app/models/dns.rb b/plugins/network/app/models/dns.rb > index 6a03736..f153a75 100644 > --- a/plugins/network/app/models/dns.rb > +++ b/plugins/network/app/models/dns.rb > @@ -42,9 +42,17 @@ class DNS > xml = options[:builder] ||= Builder::XmlMarkup.new(options) > xml.instruct! unless options[:skip_instruct] > > - xml.hostname do > - xml.domains @domains > - xml.servers @servers > + xml.dns do > + xml.domains({:type => "array"}) do > + domains.each do |@domains, val| > + xml.tag!(:domain, domains) > + end > + end > + xml.servers({:type => "array"}) do > + servers.each do |@servers, val| > + xml.tag!(:nameserver, servers) > + end > + end > end > end > Hi, I see it quite often in code and Karel on session say, that instead xml.tag!(:domain, domains) we should use simple xml.domain domains -- Josef Reidinger YaST team maintainer of perl-Bootloader, YaST2-Repair, webyast modules language and time -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

2 1

[yast-devel] WebYaST status 03-Sep-2009
by J. Daniel Schmidt 03 Sep '09

03 Sep '09

WebYaST 03-Sep-2009 =================== present: kkaempf, dmacvicar, schubi, mschmidkunz, jdsn, mzugec, mvidner, jsuchomel, lslezak absent: jsrain, visnov, fnadge Status: ----------- kkaempf: work in fate dmacvicar: work on error handling plan to handle errors from proxy as well in flash section and pick next high prio. feature schubi: vendor theming done, documentation is in the wiki plan to do it for translations in a similar way mschmidkunz: discussed UI elements for error display plan to release first version of the WebYaST style guide jdsn: research for registration module succeeded to evaluate single lines of perl from ruby plan to do it as well with an entire perl module mzugec: extended REST API for DNS plan to implement YaPI interfaces mvidner: work on bugzilla bugs plan to implement the read only part of the network module jsuchomel: work on bugzilla bugs discussed custom services plan to pick next TODO from the list lslezak: work on error handling in the services module plan to pick next TODO from the list General decisions: - We will handle concrete TODO actions in bugzilla. (not the generic fate request itself, but single tasks/steps to fulfill one) Please hand unassigned bugs to Klaus. - If you look for a new feature to implement please pick one from the _top_ of the TODO file Ciao, Daniel -- J. Daniel Schmidt <jdsn(a)suse.de> SUSE Linux Products GmbH Research & Development Maxfeldstr. 5 GF: Markus Rex, HRB 16746 (AG Nürnberg) D-90409 Nürnberg -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] WebYaST: Vendor service - Summary + TODO
by Ladislav Slezak 03 Sep '09

03 Sep '09

(Resending to yast-devel for a broader discussion....) Dne 21.8.2009 10:08, Jiří Suchomel napsal(a): > On Thursday 20 of August 2009 13:30:12 Ladislav Slezak wrote: >> The REST service >> ================ >> >> - provides a REST API for both LSB and custom services >> - uses YaPI for LSB services >> - custom services are handled directly, config files are read/parsed >> directly, SCR service is used for execution >> - uses new YaST::ConfigFile library >> >> >> Web UI (webclient) >> ================== >> >> - provides a separate view on LSB services and custom services >> - allows custom branding (via modifications in /public directory) > > TODO > > The REST service > ================ > - enhance testsuite > - add function to query service status (Q: use new policy for query, or use > the one for "execute"?) I'd reuse the existing right, no need for extra one IMHO. > Web UI (webclient) > ================== > - testsuite > - design the UI (talk to mschmidkunz), may be different for System vs. Custom > services The question is if vendors would like to change "Custom Services" to a better name (with real service name). With current implementation they need to change the name directly in .yml config file. Is that OK? > - show the service status: > - for system services, probably first show list of services, that update the > status of each one service with AJAX calls Maybe one AJAX call for all services could be better (I'm not sure about the overhead, running 30 requests in parallel instead of big one might be too slow.) Any idea? I'm not an AJAX expert... > - custom service is expected to be only one currently, so the status could > be load on loading index page I'd keep the same functionality, this creates unnecessary complexity. More over reading the current status might take long time so the complete page would be displayed after a (possibly long) delay. > - think how the service execution result should be shown better -- Best Regards Ladislav Slezák Yast Developer ------------------------------------------------------------------------ SUSE LINUX, s.r.o. e-mail: lslezak(a)suse.cz Lihovarská 1060/12 tel: +420 284 028 960 190 00 Prague 9 fax: +420 284 028 951 Czech Republic http://www.suse.cz/ -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

4 4

[yast-devel] Error handling - rest service side
by Josef Reidinger 03 Sep '09

03 Sep '09

Hi, as you can see from commits I merge my error handling branch to master. So what changes: in short: errors in backend is reported via exceptions, all webservice exceptions should have one ancestor BackendException, so if you want add own exception please create it as child of this class uncatched BackendExceptions is reported as 503 and content is xml description of problem. BackendException must have unique enum identificator, english description if anyone read directly xml and to_xml method, that creates content of respond. I create 3 exceptions for permission check as example, so now permission_check method throws exceptions instead returning false and if you don't want return something special, don't catch it. For yapi based modules I create shortcut yapi_perm_check where you only specify last part of permission (e.g. "time.read") more in yast_roles documentation. Duncan - can we generate documentation on some public place to easier link it and be easier accesible? Welcome any comments and I suggest create own exceptions. I plan in near future addapt client side error reporting for this 503 response. Documented also on wiki http://en.opensuse.org/YaST/Web/Development/Error_Handling Welcome any comments and suggestions -- Josef Reidinger YaST team maintainer of perl-Bootloader, YaST2-Repair, webyast modules language and time -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0