September 2009 - YaST Development - openSUSE Mailing Lists

[yast-devel] WebYaST status, 2009-09-14
by Jiri Srain 16 Sep '09

16 Sep '09

present: kkaempf, dmacvicar, jdsn, schubi, mschmidkunz, mvidner, mzugec, jsrain kkaempf: - looking into patch model dmacvicar: - log module - refactoring the status controller, to be merged jdsn: - working on registration, YaPI interface - first working version ETA today (general registration working) schubi: - patch installation - should be able to install patch today or tomorrow mschmidkunz: - getting glimpse on what happened during FTO mvidner: - REST documentation of network WIP - will submit RPMs mzugec: - small progress in network - can configure default route + hostname, DNS in progress - interface setting - hopefully today jsuchome (via jsrain): - admin module basically working - TBD: testcases, docu -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 1

[yast-devel] Re: [yast-commit] <rest-service> network : Added a note to s/404/422/ in test_update_noparams.
by Josef Reidinger 15 Sep '09

15 Sep '09

Martin Vidner wrote: > ref: refs/heads/network > commit 95f714b375f3dadfb35060427a0280c8a9f04bc6 > Author: Martin Vidner <mvidner(a)suse.cz> > Date: Tue Sep 15 13:13:48 2009 +0200 > > Added a note to s/404/422/ in test_update_noparams. > --- > webservice/test/plugin_basic_tests.rb | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/webservice/test/plugin_basic_tests.rb b/webservice/test/plugin_basic_tests.rb > index f77ffb7..11907cd 100644 > --- a/webservice/test/plugin_basic_tests.rb > +++ b/webservice/test/plugin_basic_tests.rb > @@ -66,6 +66,8 @@ module PluginBasicTests > def test_update_noparams > @model_class.stubs(:save) > put :update > + # FIXME: it is not 404, but 422 unprocessable entity, > + # see "Validation errors" in http://api.rubyonrails.org/classes/ActiveResource/Base.html > assert_response :missing > end > Hi, I think that this is one of thinks when we should use our new error reporting in backend. So I prefer throwing exception where is defined what parameter is invalid or missing (due to rest service should be used without webclient). I prefer solution with exception because it provide better description of problem and also it is easier to handle in frontend. Any reason why not use exceptions? Josef -- Josef Reidinger YaST team maintainer of perl-Bootloader, YaST2-Repair, webyast modules language and time -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] style guide add-on: module titles
by Martin Schmidkunz 15 Sep '09

15 Sep '09

Hi everybody, because of the recent version of webYaST it was necessary to add some lines about module titles into the style guide (http:// en.opensuse.org/YaST/Web/Docu/Style_Guide). Again: this is all to increase consistency and therefore the usability of webYaST. So, when you create a module title, please keep the following in mind: * Use title style for the module title. * Keep the title short and meaningful. * The module title is consistent with the module title in „Show All“ or "Home" page. * Do not use "Configure" or any other verb in the title. * If the module is used to configure a client, use the word "Client" in the title. * If the module is used to configure a server, use the word "Server" in the title. Thanks and have a nice week! Martin -- Crossmedialer Kontakt via: Martin Schmidkunz Forchheimer Str. 3 90542 Eckental Tel.: +499126/2090189 Mobil: +49176/80127858 ICQ: 457001671/Schmidi1803 --- Martin Schmidkunz User Experience Specialist mschmidkunz(a)novell.com +49 (0) 911 740 53-346 --- SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) --- Novell® Making IT Work As One™

1 0

[yast-devel] Power Outage
by ml-admin＠opensuse.org 11 Sep '09

11 Sep '09

Broadcast message from ml-admin(a)opensuse.org (/dev/pts/0) at 07:30 GMT ... The system is going down for halt NOW! -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] WebYast: Documenting REST API - findings
by Ladislav Slezak 10 Sep '09

10 Sep '09

Hi all, Currently we don't have any standard or guidelines how to document Yast REST API. Duncan sent me two links: Rapidoc ------- (http://code.google.com/p/rapidoc/) It generates on-line documentation (controller and view) which is part of the application. The API is documented in the code (inline). Unfortunately it needs quite a lot of changes (where to search for input files, where stote generated files) and the templates need to be modified for our needs. This seems be not a trivial task... Anyway, I like the fact that the documentation is provided by the REST server itself - the documentation is automatically available (no need to install extra packages or search the web) and there is no problem with versions, the documentation will (or should) always match the current API on the server. Vasco ----- (http://blog.thinkrelevance.com/2008/10/22/introducing-vasco-a-route-explore…) Actually this is not a documentation generator, but it provides a nice GUI to REST API (see the link). This would be a good tool for testing during development - you should be able to browse the available methods and even test them without need to code a frontend first. Unfortunately it didn't work for me, the page was empty telling me to run a rake task to collect the data even though it had been already called and the data file was present... I'd like to discuss the REST documentation problem with Karel tomorrow, maybe he knows better tools... BTW I found that twitter documentation might be a good example how a REST API documentation could look like and what it should contain. (See e.g. http://apiwiki.twitter.com/Twitter-Search-API-Method%3A-search) -- Best Regards Ladislav Slezák Yast Developer ------------------------------------------------------------------------ SUSE LINUX, s.r.o. e-mail: lslezak(a)suse.cz Lihovarská 1060/12 tel: +420 284 028 960 190 00 Prague 9 fax: +420 284 028 951 Czech Republic http://www.suse.cz/ -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

4 7

[yast-devel] Documenting REST API using restility
by Ladislav Slezak 10 Sep '09

10 Sep '09

Hi all, I have integrated restility to WebYaST - restility is now available as a ruby gem (rubygem-restility) and there is a new rake task 'restdoc' which is called from 'package' task (the REST documentation is automatically generated during package build). If you want to check how it looks like then - install restility gem from YaST:Web repository [ well, the build has not been finished completely yet, e.g. FACTORY package still waits in the queue... :-( ] - update to the latest rest service from GIT - call 'rake restdoc' in plugins/system - restart the rest service (because of the new public/ overlay) - and finally point your browser to http://localhost:8080/system/restdoc/index.html You can look at plugins/system/restdoc/api.txt to see the source. (I'm going to write a wiki page how to create a REST documentation...) -- Best Regards Ladislav Slezák Yast Developer ------------------------------------------------------------------------ SUSE LINUX, s.r.o. e-mail: lslezak(a)suse.cz Lihovarská 1060/12 tel: +420 284 028 960 190 00 Prague 9 fax: +420 284 028 951 Czech Republic http://www.suse.cz/ -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

3 2

[yast-devel] Re: [yast-commit] Build failed in Hudson: webyast-service-11.1-i586 #296
by Klaus Kaempf 10 Sep '09

10 Sep '09

* Hudson Integration Service <hudson(a)suse.de> [Sep 10. 2009 16:53]: > error: Failed build dependencies: > rubygem-restility is needed by yast2-webservice-0.0.3-0.noarch Can we postpone requiring rubygem-restility until after the power-down ? Else I guess the build will fail until next week. Klaus --- SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] Howto prepare your module for base system settings
by Josef Reidinger 10 Sep '09

10 Sep '09

Hi, if your module should be used in base system sequence it needs little change. I describe it in wiki http://en.opensuse.org/YaST/Web/Development/Client It is just two lines changes that allows correct redirect and use different labels for form submit buttons. If you have any question I welcome it. jsuchome - administration should be used in basic system settings so please read it and add it to code, thanks. -- Josef Reidinger YaST team maintainer of perl-Bootloader, YaST2-Repair, webyast modules language and time -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] Re: [yast-commit] <rest-service> master : call the real YaPI, update tests
by Josef Reidinger 10 Sep '09

10 Sep '09

Jiri Suchomel wrote: > ref: refs/heads/master > commit 61f65df178461f324728e5de041e91936a62d2b3 > Author: Jiri Suchomel <jsuchome(a)suse.cz> > Date: Thu Sep 10 16:07:16 2009 +0200 > > call the real YaPI, update tests > --- > .../app/controllers/administrator_controller.rb | 9 ++++++++- > plugins/administrator/app/models/administrator.rb | 20 ++++++++++++++++---- > .../administrator/test/unit/administrator_test.rb | 19 ++++++++++--------- > 3 files changed, 34 insertions(+), 14 deletions(-) > > diff --git a/plugins/administrator/app/controllers/administrator_controller.rb b/plugins/administrator/app/controllers/administrator_controller.rb > index 2542c4c..60b90e0 100644 > --- a/plugins/administrator/app/controllers/administrator_controller.rb > +++ b/plugins/administrator/app/controllers/administrator_controller.rb > @@ -4,7 +4,10 @@ class AdministratorController < ApplicationController > > # GET action > def show > -# @aliases = Administrator.instance.aliases > + unless permission_check("org.opensuse.yast.modules.yapi.administrator.read") > + render ErrorResult.error(403, 1, "no permission for reading") and return > + end > + Hi, new error reporting uses exceptions os for check if permission is set use just permission_check("org.opensuse.yast.modules.yapi.administrator.read") and because I create for yapi shortcut you can use just yapi_perm_check "administrator.read" > @admin = Administrator.instance > @aliases = @admin.read_aliases > > @@ -17,6 +20,10 @@ class AdministratorController < ApplicationController > > # PUT action > def update > + > + unless permission_check("org.opensuse.yast.modules.yapi.administrator.write") > + render ErrorResult.error(403, 1, "no permission for writing") and return > + end > > @admin = Administrator.instance > > diff --git a/plugins/administrator/app/models/administrator.rb b/plugins/administrator/app/models/administrator.rb > index c51bbf5..87186fd 100644 > --- a/plugins/administrator/app/models/administrator.rb > +++ b/plugins/administrator/app/models/administrator.rb > @@ -22,13 +22,25 @@ class Administrator > end > > def save_password(pw) > - Rails.logger.debug "--------------------- saving password #{pw}--------" > + parameters = { > + "password" => ["s", pw ] > + } > + yapi_ret = YastService.Call("YaPI::ADMINISTRATOR::Write", parameters) > + Rails.logger.debug "YaPI returns: '#{yapi_ret}'" > end > > def save_aliases(new_aliases) > - # TODO compare new_aliases with aliases > - Rails.logger.debug "--------------------- current aliases #{aliases.inspect}" > - Rails.logger.debug "--------------------- saving aliases #{new_aliases.inspect}" > + if @aliases.sort == new_aliases > + Rails.logger.debug "mail aliases have not been changed" > + return > + end > + parameters = { > + "aliases" => ["as", new_aliases] > + } > + yapi_ret = YastService.Call("YaPI::ADMINISTRATOR::Write", parameters) > + Rails.logger.debug "YaPI returns: '#{yapi_ret}'" > + > + raise yapi_ret unless yapi_ret.empty? > @aliases = new_aliases > end > > diff --git a/plugins/administrator/test/unit/administrator_test.rb b/plugins/administrator/test/unit/administrator_test.rb > index bff12ab..1e8ef08 100644 > --- a/plugins/administrator/test/unit/administrator_test.rb > +++ b/plugins/administrator/test/unit/administrator_test.rb > @@ -9,21 +9,22 @@ class AdministratorTest < ActiveSupport::TestCase > end > > def test_save_password > + YastService.stubs(:Call).with('YaPI::ADMINISTRATOR::Write', {"password" => ["s", "new password"]}).returns("") > ret = @model.save_password("new password") > assert ret > end > > -# def test_read_aliases > -# assert @model.aliases.size == 0 > -# YastService.stubs(:Call).with('YaPI::ADMINISTRATOR::Read').returns({ "aliases" => [ "a@b" ] }) > -# ret = @model.read_aliases > -# assert ret > -# assert @model.aliases.size == 1 > -# end > + def test_read_aliases > + YastService.stubs(:Call).with('YaPI::ADMINISTRATOR::Read').returns({ "aliases" => [ "a@b" ] }) > + ret = @model.read_aliases > + assert ret > + assert @model.aliases.size == 1 > + end > > def test_save_aliases > - assert @model.aliases.size == 0 > - ret = @model.save_aliases([ "test(a)domain.com", "a@b" ]) > + new_aliases = [ "test(a)domain.com", "a@b" ]; > + YastService.stubs(:Call).with('YaPI::ADMINISTRATOR::Write', {"aliases" => [ "as", new_aliases ]}).returns("") > + ret = @model.save_aliases(new_aliases) > assert ret > assert @model.aliases.size == 2 > end -- Josef Reidinger YaST team maintainer of perl-Bootloader, YaST2-Repair, webyast modules language and time -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] SLE-11 SP1 development, which svn branch?
by Ralf Haferkamp 10 Sep '09

10 Sep '09

Hi, will there be a special development branch in svn for SP1 features? If not, which branch should SP1 features go to? -- regards, Ralf -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

2 1