November 2009 - YaST Development - openSUSE Mailing Lists

[yast-devel] New video reviews
by Josef Reidinger 03 Nov '09

03 Nov '09

Hi, in short: I update wiki page with two new videos - http://en.opensuse.org/YaST/Web/Development/TrainingKit/Learning_Ruby_and_R… longer description: First what I see is instruction video from railscast about new things in rails 2.3 (so little older). It introduce three features. Scope and batches is useful for ActiveRecord (database). Third one is method try on Object. I think it is really useful method which we should start using to simplify our code (but do not overuse). especially if code contains if o && o.map && o.map[:test] you can simple type if o.try(:map).try(:"[]",:test) If you don't know this feature I suggest look at that short video, because your quality of your code is limited by your knowledge of used api. Second one is from Gotham conference SOLID object design. I really recommend this video, because if you are not design guru which knows the latest news you give a lot of new ideas how to improve your code quality (so everyone in webyast team should look at it, especially if he want change something in framework). The presentation shows in example what is advantage of dynamic languages and why rails has so popular api. It shows how you can write code which need not to modify much and which is easily extendable. Also shows what to do if your class depends on class (libraries, modules, config files) which is changed more often then your class. It takes 47 minutes, but it is full of information ( I don't fall asleep which detect really good presentation and speaker :) -- Josef Reidinger YaST team maintainer of perl-Bootloader, YaST2-Repair, webyast modules language and time -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] Re: [yast-commit] <web-client> master : fix the case basesystem workflow, in which no licenses are configured
by Josef Reidinger 03 Nov '09

03 Nov '09

Martin Kudlvasr write: > ref: refs/heads/master > commit 5708db961e45f398c98aed47abdc46ef2c8310fb > Author: Martin Kudlvasr <mkudlvasr(a)suse.cz> > Date: Tue Nov 3 17:18:22 2009 +0100 > > fix the case basesystem workflow, in which no licenses are configured > --- > plugins/eulas/app/views/eulas/no_licenses.erb | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/plugins/eulas/app/views/eulas/no_licenses.erb > b/plugins/eulas/app/views/eulas/no_licenses.erb new file mode 100644 > index 0000000..9c30a9e > --- /dev/null > +++ b/plugins/eulas/app/views/eulas/no_licenses.erb > @@ -0,0 +1,3 @@ > +<h1><%=_("Accept End User Licence Agreement")-%></h1><br/> > +<h3><%= _("There are no licenses to accept.") %></h3> > +<%= form_back_button + form_str_spacer + (link_to "Next", :controller => > "controlpanel", :action => "nextstep")%> > Is there reason to not use form_send_buttons? I think that there also doesn't work back button as form_back_button doesn't work in basesystem. -- Josef Reidinger YaST team maintainer of perl-Bootloader, YaST2-Repair, webyast modules language and time -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] ruby bindings 0.3.5
by Duncan Mac-Vicar Prett 03 Nov '09

03 Nov '09

I submitted yast2-ruby-bindings 0.3.5 to YaST:Head. It now supports ruby components with nested modules. That is a file like: /usr/share/YaST2/modules/Foo::Bar.rb or /usr/share/YaST2/modules/Foo/Bar.rb containing: module Foo module Bar def self.hello ... end end end Can be called from ycp as expected. Still, I don't understand why people use the YaPI namespace? I haven't submitted to factory, please test :-) -- Duncan Mac-Vicar P. - Engineering Manager, YaST SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nuernberg) -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] WebYaST status call 03-Nov-2009
by Benjamin Brunner 03 Nov '09

03 Nov '09

WebYaST call, 03 Nov 2009 participants: bbrunner, kkaempf, duncanmv, jdsn, schubi, mvidner, jsuchome, jsrain, mkudlvasr, stano, jreidinger kkaempf: - deadlines for bugs: P2 - 5. 11. midday P3 - 19. 11. if someone can't comply with this dates please contact Klaus - review bugs - worked on AutoBuild with Maintenance Team - WebYaST should be an addon product for SLE11 - not in office from 04 Nov - 06 Nov schubi: - added detail option in registration module - worked on bugs (patch, hashes) duncanmv: - fixed ruby bindings bug jdsn: - debug internal server error in registration module mvidner: - Beta still not released to partners - reviewed P2 bugs stano: - no updates jsrain: - tested appliances jreidinger: - works on bugs, if someone needs help you can contact him mkudlvasr: - worked on UI-bugs - minor refactoring the code - continued working with bugzilla -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] [webYaST] :dasherize => false not enough to stop dasherizing? (bug 551284)
by Jiří Suchomel 03 Nov '09

03 Nov '09

Hi! Bug 551284 describes a problem of mail_settings plugin when it is called for a second time (while first time it was during basesystem sequence). The problem itself is that underscores are changed to dashes in the POST call. And indeed, mail_settings_controller of the webservice lacks the option to set dasherize to false in respond_to function, so the solution looked easy. However, I added that option, restarted both service and server, tried again and seen the same problem again. Any idea what else might be wrong? Other strange part of the problem is that when I remove registration step from the initial sequence, mail settings error does not occur. Jiri -- Jiri Suchomel SUSE LINUX, s.r.o. e-mail: jsuchome(a)suse.cz Lihovarská 1060/12 tel: +420 284 028 960 190 00 Praha 9, Czech Republic http://www.suse.cz -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

4 9

[yast-devel] Re: [yast-commit] <rest-service> master : add Brute force protection
by Martin Kudlvasr 03 Nov '09

03 Nov '09

On Monday 02 November 2009 16:31:56 Josef Reidinger wrote: > ref: refs/heads/master > commit 4f74fe5c2ec8c1927b9ebac0073e5b703fb484df > Author: Josef Reidinger <jreidinger(a)suse.cz> > Date: Mon Nov 2 16:24:21 2009 +0100 > > add Brute force protection > --- > webservice/app/controllers/sessions_controller.rb | 6 ++- > webservice/lib/brute_force_protection.rb | 63 > ++++++++++++++++++++ webservice/package/yast2-webservice.changes | > 5 ++ > .../test/unit/brute_force_protection_test.rb | 33 ++++++++++ > 4 files changed, 106 insertions(+), 1 deletions(-) > > diff --git a/webservice/app/controllers/sessions_controller.rb > b/webservice/app/controllers/sessions_controller.rb index 86295c2..d88f3e0 > 100644 > --- a/webservice/app/controllers/sessions_controller.rb > +++ b/webservice/app/controllers/sessions_controller.rb > @@ -34,7 +34,10 @@ class SessionsController < ApplicationController > self.current_account = Account.authenticate(params[:login], > params[:password]) end > @cmd_ret = Hash.new > - if logged_in? > + if BruteForceProtection.instance.blocked? > + @cmd_ret["login"] = "blocked" > + @cmd_ret["remain"] = BruteForceProtection.instance.last_fail + > BruteForceProtection::BAN_TIMEOUT + elsif logged_in? > if params[:remember_me] > current_account.remember_me unless current_account.remember_token? > cookies[:auth_token] = { :value => > self.current_account.remember_token , :expires => > self.current_account.remember_token_expires_at } @@ -44,6 +47,7 @@ class > SessionsController < ApplicationController @cmd_ret["auth_token"] = { > :value => self.current_account.remember_token , :expires => > self.current_account.remember_token_expires_at } else > @cmd_ret["login"] = "denied" > + BruteForceProtection.instance.fail_attempt > end > end > > diff --git a/webservice/lib/brute_force_protection.rb > b/webservice/lib/brute_force_protection.rb new file mode 100644 > index 0000000..b5fc899 > --- /dev/null > +++ b/webservice/lib/brute_force_protection.rb > @@ -0,0 +1,63 @@ > +# == Brute force Protection class > +# === Overview > +# > +# Singleton class thant remember fail attempts to log to REST-SERVICE. > +# After specified time period is failed attemps cleared. > +# > +# === Usage > +# > +# When user tries to login ensure that it is not blocked by > BruteForceProtection.instance.blocked? +# When user failed to login call > BruteForceProtection.instance.fail_attempt + > +class BruteForceProtection > + include Singleton > + Maybe I misunderstood the code, but using Singleton module will not preserve the instance between requests. Just try to create a simple Singleton counter and view it a few times in some controller. Singletons are regular instances of regular ruby class. The only difference is, that you can make (new) only one of them. But they are lost at the end of request like any other instance. For storing values between requests AFAIK only database and module namespace hacks work. I don't have anything against storing values in module namespace, but I suggest doing it readable. For instance by writing some "ModuleStorage" class/module whose only purpose would be to store and retrieve values using module namespace. -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

2 3

[yast-devel] on storing values in module namespace
by Martin Kudlvasr 02 Nov '09

02 Nov '09

Hi, Josef inspired me to do some research in $SUBJ. The results are in new branch of webclient called module-storage. Just pull this branch, switch to it a reload /eulas a few times. I was too lazy to create a special controller for this, so the counter is displayed under the sign "All licenses have already been accepted" ;-) The code itself is located in files: /web-client/plugins/eulas/app/models/{module_storage,counter,counter_store}.rb The code is very short and there are even some comments. Caveeats found in the process: - module, where the values are stored must not be in the same file as the model. Model file get reloaded on every request. - when using custom setters and getters, you have to explicitly type "self.". Otherwise ruby thinks it is just a local variable. Enjoy! Martin -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] WebYaST status call 02-Nov-2009
by Benjamin Brunner 02 Nov '09

02 Nov '09

WebYaST call, 02 Nov 2009 participants: bbrunner,kkaempf, dmacvicar, kkaempf, jdsn, mvidner, mkudlvasr, jsuchome bbrunner: - tested Beta 3.9 (4) and filed bugs schubi: - no update, will work on registration-UI kkaempf: - no update, currently looks over bugs in Bugzilla dmacvicar: - no update, today will have a look on a ruby-bindings bug jdsn: - no update mvidner: - will also have a look on ruby-bindings bug - will release WebYaST Beta4 to external partners mkudlvasr: - wrote tests for UI-controller - will looking for UI-tests jsuchome: - looked how to use ruby from PHP - works on a Bug in mailsettings misc: Check your bugs! -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] RC2: Yast without SaX2?
by Sascha 'saigkill' Manns 02 Nov '09

02 Nov '09

Hello Mates, i like the new Features from YaST in RC2. But i'm missing the SaX2 Buttion. Is that no longer in YaST? -- Sincerely yours Sascha Manns openSUSE Member openSUSE Ambassador openSUSE Marketing Team openSUSE Build Service Web: http://saschamanns.gulli.to Blog: http://saigkill.wordpress.com ClaimID: http://claimid.com/saigkill -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

3 2