November 2009 - YaST Development - openSUSE Mailing Lists

[yast-devel] How to stay in a tab in DialogTree after clicking Next
by Johannes Meixner 06 Nov '09

06 Nov '09

Hello, short story: in yast2-printer I use a DialogTree and in one of its tabs (which is not its initial tab) I like to stay in the tab after the user clicked Next when an error happened while writing the settings to the system so that the user can change the settings in the tab until it works or he can click [Cancel] to enforce leaving the dialog. Details: in yast2-printer I have in src/dialogs.ycp -------------------------------------------------------------------------- widgets_handling = ... "NETWORKPRINTING" : $[ "widget" : `custom, "custom_widget" : widgetNetworkPrinting, "init" : initNetworkPrinting, "handle" : handleNetworkPrinting, "help" : HELPS["printing_via_network_dialog"]:"" ], . . . tabs_description = ... "network" : $[ "header" : _("Print via Network"), "tree_item_label" : _("Print via Network"), "caption" : _("Print via Network"), "contents" : `VBox( "NETWORKPRINTING" ), "widget_names" : ["NETWORKPRINTING"] ], . . . DialogTree::ShowAndRun ( $[ "ids_order" : [ "overview", "network", ... ], "initial_screen" : "overview", -------------------------------------------------------------------------- I like to stay in the "NETWORKPRINTING" tab when writing its settings fails. In src/printingvianetwork.ycp I have currently in the handleNetworkPrinting() function: ---------------------------------------------------------------------------- if( `next == event["ID"]:nil ) { if( ! ApplyNetworkPrintingSettings() ) { Popup::Error( // Popup::Error message: _("Failed to apply the settings to the system.") ); // In case of an error stay on the "Print via Network" dialog // so that the user can either change his settings until it works // or he can use the [Cancel] button to return to the Overview dialog: return nil; } ---------------------------------------------------------------------------- but this does not work. Instead the whole YaST module is exiting with `next regardless that I explicitely "return nil" and in y2log there is: ------------------------------------------------------------------------------ 2009-11-06 11:06:28 <1> nelson(6379) [liby2] Y2ProgramComponent.cc(result):159 Sending result: `result (nil) 2009-11-06 11:06:28 <1> nelson(6379) [liby2] genericfrontend.cc(main):777 Finished YaST2 component 'y2base' 2009-11-06 11:06:28 <1> nelson(6379) [liby2] genericfrontend.cc(main):782 Exiting with client return value '`next' ------------------------------------------------------------------------------ Kind Regards Johannes Meixner -- SUSE LINUX Products GmbH, Maxfeldstrasse 5, 90409 Nuernberg, Germany AG Nuernberg, HRB 16746, GF: Markus Rex -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

3 4

[yast-devel] WebYaST status call 06-Nov-2009
by Benjamin Brunner 06 Nov '09

06 Nov '09

WebYaST call, 06 Nov 2009 participants: jsrain, schubi, bbrunner, jreidinger, jdsn, mvidner, jsuchome, stano, bbrunner schubi: - finished last bug in status module - today will work with icons and images for license-stuff jdsn: - worked on registration module - tested SLMS and SMT jsuchome: - custom services does not work for RC1 - worked at log viewer jsrain: - no updates - installed the latest snapshot mvidner: - RC1 looks okay - release today soon after lunch jreidinger: - removed scr_execute for custom logs - today will change permission controller in backend -stano: - everybody must set up support-level for their maintained packages (L3) - figured out a SLMS problem Have a nice weekend! -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] Webyast: Improvements after first release (discussion)
by Josef Reidinger 06 Nov '09

06 Nov '09

Hi, I would like to summarize and also start discussion what should be improved after first webyast release. Because I think that things which affects infrastructure should be done before changes in plugin to benefit from improvements and also if we collect useful things which should framework provide, then it is easier to implement it together and cooperate between features. I separate issues to simple and more complex. Simple: - all webclient plugins should have testsuite (related to improvement activeResource usage on webclient as now it is quite hard to create good tests ) - all rest service should have REST documentation - all rest service should properly report invalid values ( related to validations in ActiveModel ). Properly report is to use InvalidValue exception which reports 422 and xml description which ActiveResource understand ( done automatic in InvalidValue exception) - remove static rest_authentificate file and use gem, because current solution require that we also port all security changes in rest_authentificate manually Complex: - Rest-service framework should provide Basic model and two Basic controller for REST. model should contain helper for permission check for read and write permission, validations, automatic loading and storing xml. Controllers should provide basic REST operation for single resource and multiple resource REST service provides xml and json api. After some research the best look to backport ActiveModel from rails 3.0 and add own specific yast extensions. I can maintain it as gem. Example plugin after this improvement: controller: LanguageController < SingleRESTController end model: Language < YaSTModel #permissions checks read_permission yapi("language.read") write_permission yapi("language.write") #validations, generally known from ActiveResource and ActiveRecord + own specific if it is needed for DBUS validates_inclusion_of :language, :in => @known_languages #etc... def find (...) #Active model parameters create( yastdbuscall (language.read,params...)) #create uses automatic new a load end def save yastdbuscall (language.read,params...) #maybe some checks etc. end end Thats what should simple plugin which is backended by DBus contain, Other non- problem related things should be handled in framework (if you must copy and paste code, then something is wrong, when you write plugin you should add only specific things related to that plugin). - Change permissions and resource call in frontend. It is huge wasting of sourced and one of problems that leads to slow webyast. My solution is to ask webservice for all resources and all permission for logged user after login and then use this values stored in webclient. This helps avoid calling three rest resources instead of one ( you can see example in network, where is 4 rest calls which lead to 12!!! rest service call just to provide information about network). Related also to next note. - Simplify ActiveResource handling in webclient. Current generated way is uncommon and each person, which want create own plugin fight with it. Solution used in network, which provide some basic class is for me just half solution. What should be done is class which act like common ActiveResource which is well known rails source. My suggestion is to join with previous task and provide extension of ActiveResource which takes site from a storage (known after login), path on site from a storage (known after login if we do previous note) and credentials (same as now or improved). This is what ActiveResource need to improve. So after this change our code should look like common ActiveResource code and not as some strange code which looks like it doesn't use rails. Welcome any opinions, suggestion and ideas what should be also improved Josef -- Josef Reidinger YaST team maintainer of perl-Bootloader, YaST2-Repair, webyast (language,time,basesystem,ntp) -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] WebYaST: use ||= Ruby operator
by Ladislav Slezak 05 Nov '09

05 Nov '09

Use message ||= "Unknown error" instead of if message.nil? message = "Unknown error" end It makes the code shorter and more readable. -- Best Regards Ladislav Slezák Yast Developer ------------------------------------------------------------------------ SUSE LINUX, s.r.o. e-mail: lslezak(a)suse.cz Lihovarská 1060/12 tel: +420 284 028 960 190 00 Prague 9 fax: +420 284 028 951 Czech Republic http://www.suse.cz/ -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] WebYaST status call 04-Nov-2009
by Benjamin Brunner 05 Nov '09

05 Nov '09

WebYaST call, 04 Nov 2009 participants: bbrunner, schubi, jdsn, duncanmv, jsuchome, jsrain, jreidinger schubi: - bugfixed system_check rake tasks - today will work on bugs in status module jdsn: - created an xml for registration module duncanmv: - fixed ruby-bindings bugs - today will work on bug 5512706 bbrunner: - reviewed public-folder and deleted unused images and icons - tested WebYaST-UI - overworked the package-list on opensuse.org jsrain: - no updates jreidinger: - fixed bugs, if someone needs help for his bugs you can contact him jsuchome: - worked on services to providing ruby bindings additional: Tomorrow, jsrain will have the reports, thank you! -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

2 1

[yast-devel] RC 1 upcoming
by Martin Vidner 05 Nov '09

05 Nov '09

Hi! today at noon is the check-in deadline for WebYaST RC1, and the following is next: * building the packages and the appliance * while getting last minute fixes from you * overnight QA in Beijing will run validation tests (new!) * we will release it on Friday morning document your changes in .changes * refer to bug numbers (and mark the bugs fixed) * point to README_FOR_APP, especially for vendor customization * don't forget that others may have changed your module (Robert most likely did) Use this to check the real changes: git log --stat -- plugins/$MINE submit to YaST:Web:STABLE osc sr -m "many new bugs. fixed." YaST:Web $PKG YaST:Web:STABLE -- Martin Vidner, YaST developer http://en.opensuse.org/User:Mvidner Kuracke oddeleni v restauraci je jako fekalni oddeleni v bazenu

1 0

[yast-devel] Webyast - calling another rest-services
by Josef Reidinger 04 Nov '09

04 Nov '09

Hi, As time comes we should start to think how in our infrastructure we should call another modules. E.g. call collectd status from status module should use services module. I see there few problems: 1) How to avoid permission check for another controllers? For example if status just want to run rccollectd status user should have just permission to status and not need to read services ( if we create permission mess no one set it and paranoid customer doesn't webyast) 2) How to avoid load correct controller with interface and another little strange things in our rest-service? And should we create hard dependencies or have fallback if target module is not available? 3) We should study how to do it properly to avoid future problems. Josef -- Josef Reidinger YaST team maintainer of perl-Bootloader, YaST2-Repair, webyast modules language and time -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] Deleted unused images
by Benjamin Brunner 04 Nov '09

04 Nov '09

I removed the unused images and the unused yast.js and fake-data.js script in the public folder. Here the complete list of the deleted items: # deleted: plugins/custom_services/public/icons/custom-service.png # deleted: webclient/public/icons/kupdateapplet_busy.png # deleted: webclient/public/icons/kupdateapplet_gray.png # deleted: webclient/public/icons/pattern-network.png # deleted: webclient/public/icons/yast-apparmor.png # deleted: webclient/public/icons/yast-bluetooth.png # deleted: webclient/public/icons/yast-dhcp-server.png # deleted: webclient/public/icons/yast-dsl.png # deleted: webclient/public/icons/yast-firewall.png # deleted: webclient/public/icons/yast-hdd.png # deleted: webclient/public/icons/yast-http-server.png # deleted: webclient/public/icons/yast-ldap-server.png # deleted: webclient/public/icons/yast-misc.png # deleted: webclient/public/icons/yast-package-manager.png # deleted: webclient/public/icons/yast-partitioning.png # deleted: webclient/public/icons/yast-pm.png # deleted: webclient/public/icons/yast-printer.png # deleted: webclient/public/icons/yast-raid.png # deleted: webclient/public/icons/yast-service-22.png # deleted: webclient/public/icons/yast-sound.png # deleted: webclient/public/icons/yast-x11.png # deleted: webclient/public/images/Yast_crystal_logo_gray.png # deleted: webclient/public/images/button_critical.png # deleted: webclient/public/images/button_ok.png # deleted: webclient/public/images/button_warning.png # deleted: webclient/public/images/computer_connected.png # deleted: webclient/public/images/configure.png # deleted: webclient/public/images/empty.png # deleted: webclient/public/images/geckohead-green.png # deleted: webclient/public/images/geckohead-grey.png # deleted: webclient/public/images/geckohead-grey_001.png # deleted: webclient/public/images/icons/48/clock.png # deleted: webclient/public/images/icons/48/computer.png # deleted: webclient/public/images/icons/48/computer_48.png # deleted: webclient/public/images/icons/48/user.png # deleted: webclient/public/images/icons/48/user_add.png # deleted: webclient/public/images/icons/48/user_delete.png # deleted: webclient/public/images/icons/48/user_manage.png # deleted: webclient/public/images/icons/48/user_warning.png # deleted: webclient/public/images/key_add.png # deleted: webclient/public/images/n-geeko.png # deleted: webclient/public/images/probe.png # deleted: webclient/public/images/rails.png # deleted: webclient/public/images/reload.png # deleted: webclient/public/images/restart.png # deleted: webclient/public/images/start.png # deleted: webclient/public/images/status.png # deleted: webclient/public/images/stop.png # deleted: webclient/public/images/suse-logo.png # deleted: webclient/public/images/webyast.png # deleted: webclient/public/inc/fake-data.js # deleted: webclient/public/inc/yast.js # deleted: webclient/public/stylesheets/images/bg-head-gradient-blue.png # deleted: webclient/public/stylesheets/images/bg-head-gradient-bluegrey.png -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] Re: [yast-commit] <web-client> master : display correct language name
by Martin Vidner 04 Nov '09

04 Nov '09

On Tue, Nov 03, 2009 at 06:36:27PM +0100, Ladislav Slezak wrote: > ref: refs/heads/master > commit 055f49b8bd433d33b00dd88fdec3e390b8508a74 > --- a/webclient/vendor/plugins/lang_helper/lib/lang_helper.rb > +++ b/webclient/vendor/plugins/lang_helper/lib/lang_helper.rb > @@ -42,6 +42,12 @@ module LangHelper > end > > def current_locale_name > + # check full locale at first (language + country) > + if LANGUGAGES.has_key?(locale.to_s) toog manyg g's (fortunately consistently in the code) -- Martin Vidner, YaST developer http://en.opensuse.org/User:Mvidner Kuracke oddeleni v restauraci je jako fekalni oddeleni v bazenu

2 1

[yast-devel] [webYaST] Bug 551276 - remove Scr.execute from services plugin
by Jiří Suchomel 04 Nov '09

04 Nov '09

Hi! We are still undecided which way to go in bug 551276. Picture: we need a way to call (from rest service) a custom script which is written in custom config file. Currently we are parsing the config file directly in rest service plugin and calling the script with Scr.execute. We have these options so far: a) use YaPI::SERVICES and call the script from here. The problem is, to parse yml file, we'd need perl-YAML package, which is not on SLE11, but on SDK. b) use YaPI::SERVICES, and from perl file, call ruby module which would care for parsing yml file. But for using ruby at this place, we'd need yast2-ruby-bindings, which also is not on SLE11. Could we include in as a part of webYaST? c) write new dbus service. We'd need ruby-dbus package: also not part of SLE11, but included in webYaST repo anyway. Comparing to a+b, this would mean more code, and new service which may need new security audit. d) do not use YML as config file, but something parsable from Perl without additional requires. d2) use file called custom_services.yml, and parse it directly from Perl. This means, it could not be true yml, only minimal subset. There's ongoing discussion in bug 551276, but maybe more people can find the right solution. Jiri -- Jiri Suchomel SUSE LINUX, s.r.o. e-mail: jsuchome(a)suse.cz Lihovarská 1060/12 tel: +420 284 028 960 190 00 Praha 9, Czech Republic http://www.suse.cz -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 2