On 10/19/2010 10:32 AM, Philipp Thomas wrote:
* Philipp Thomas (pth@suse.de) [20101019 17:13]:
I'd say the OBS should run an additional check on .spec files to ensure that Author names are encoded in utf8. I'll discuss that with collegues.
Actually rpmlint *does* give a warning when a spec file isn't encoded in utf8.But as it's only a warning, you should just bug the maintainer of a given package to fix the spec file.
Philipp
Philipp, While we're on the topic, why does suse still use PreReq in packaging? The yum/creatrepo upstream guys had to create a patch to make createrepo 0.9.8 work with my suse repos. Without it, the following errors were received on metadata update: <snip> AttributeError: 'module' object has no attribute 'RPMSENSE_PREREQ' The patch required was: --- yum/packages.py.orig +++ yum/packages.py @@ -1353,11 +1353,14 @@ is a pre-requires or a not""" # FIXME this should probably be put in rpmUtils.miscutils since # - that's what it is + RPMSENSE_PREREQ = (1 << 6) + RPMSENSE_SCRIPT_PRE = (1 << 9) + RPMSENSE_SCRIPT_POST = (1 << 10) if flag is not None: # Note: RPMSENSE_PREREQ == 0 since rpm-4.4'ish - if flag & (rpm.RPMSENSE_PREREQ | - rpm.RPMSENSE_SCRIPT_PRE | - rpm.RPMSENSE_SCRIPT_POST): + if flag & (RPMSENSE_PREREQ | + RPMSENSE_SCRIPT_PRE | + RPMSENSE_SCRIPT_POST): return 1 return 0 There comments were: "only suse uses PreReq nowadays", so the question is "Why?" -- David C. Rankin, J.D.,P.E. Rankin Law Firm, PLLC 510 Ochiltree Street Nacogdoches, Texas 75961 Telephone: (936) 715-9333 Facsimile: (936) 715-9339 www.rankinlawfirm.com -- To unsubscribe, e-mail: opensuse+unsubscribe@opensuse.org For additional commands, e-mail: opensuse+help@opensuse.org