xf86-video-radeonhd:master: 3 commit(s)
Reporting from xf86-video-radeonhd: Radeon HD video driver
Please visit:
http://gitweb.freedesktop.org/?p=xorg/driver/xf86-video-radeonhd
Or get your own copy by using:
git-clone git://anongit.freedesktop.org/xorg/driver/xf86-video-radeonhd
3 commits against master at ed98d731...:
man/radeonhd.man | 21 +++++++++++----------
src/rhd_dri.c | 13 -------------
src/rhd_driver.c | 21 ++++++++-------------
src/rhd_id.c | 10 +---------
4 files changed, 20 insertions(+), 45 deletions(-)
commit 45e733556671e78adbb2afafd6b98a461bb29825
Author: Yang Zhao
Hi Yang,
Do not log about "Unknown card detected" when AtomBIOS is available
There's a lot of confusion about this message; time to kill it now that AtomBIOS modesetting is significantly more stable.
Maybe additionally change the text from "Unknown card detected" to "card not found in quirk table" or something like that? Greetings, Frieder -- To unsubscribe, e-mail: radeonhd+unsubscribe@opensuse.org For additional commands, e-mail: radeonhd+help@opensuse.org
2009/8/17 Frieder Ferlemann
Hi Yang,
Do not log about "Unknown card detected" when AtomBIOS is available
There's a lot of confusion about this message; time to kill it now that AtomBIOS modesetting is significantly more stable.
Maybe additionally change the text from "Unknown card detected" to "card not found in quirk table" or something like that?
AFAIU, without AtomBIOS, we don't have generic modesetting, so any GPU not recognized is effectively unknown. I think it's appropriate to keep this working for this case. -- Yang Zhao http://yangman.ca -- To unsubscribe, e-mail: radeonhd+unsubscribe@opensuse.org For additional commands, e-mail: radeonhd+help@opensuse.org
On Aug 17, 09 23:51:22 -0700, Yang Zhao wrote:
2009/8/17 Frieder Ferlemann
: Do not log about "Unknown card detected" when AtomBIOS is available
I do not agree with this change completely. Yes, we have received bad "bug" reports, but if we remove this message we'll probably even get more... More important, your patch removes the logging of the three-hex-numbers string, one that is *very* important for bug reports. Maybe I can rephrase that to looks less provocative.
There's a lot of confusion about this message; time to kill it now that AtomBIOS modesetting is significantly more stable.
I agree that it is pretty weird that the message is encapsuled in #ifdef ATOM_BIOS.
Maybe additionally change the text from "Unknown card detected" to "card not found in quirk table" or something like that? AFAIU, without AtomBIOS, we don't have generic modesetting, so any GPU not recognized is effectively unknown. I think it's appropriate to keep this working for this case.
What bites us (again) here is that we do not yet separate between a
names list and the quirks table.
Matthias
--
Matthias Hopf
Sorry, took me much too long to actually come back to deal with this.
2009/8/18 Matthias Hopf
On Aug 17, 09 23:51:22 -0700, Yang Zhao wrote:
2009/8/17 Frieder Ferlemann
: Do not log about "Unknown card detected" when AtomBIOS is available
I do not agree with this change completely. Yes, we have received bad "bug" reports, but if we remove this message we'll probably even get more... More important, your patch removes the logging of the three-hex-numbers string, one that is *very* important for bug reports. Maybe I can rephrase that to looks less provocative.
The PCI ID is logged earlier by xserver, so I thought this wouldn't be a big issue. However, then I realized that this is the only place were we log a message about asking the mailling list for help, so it's been reverted with a modified message. The new message mentions "generic modesetting" explicitly, and gets rid of "Unknown card". I think this is an effective compromise without getting too verbose in the logs. Cheers, -- Yang Zhao http://yangman.ca -- To unsubscribe, e-mail: radeonhd+unsubscribe@opensuse.org For additional commands, e-mail: radeonhd+help@opensuse.org
participants (4)
-
Frieder Ferlemann
-
Matthias Hopf
-
Yang Zhao
-
yzhao@kemper.freedesktop.org