Am Donnerstag, 1. Dezember 2011, 12:37:12 schrieb Richard Guenther:
On Thu, 1 Dec 2011, Stephan Kulow wrote:
Hi,
I'm testing a new version of the format_spec_file service (you can find the sources on github's openSUSE project) and this results in submit requests of mine to:
- remove #norootforbuild - remove duplicated group and license from sub packages - patch license field to apply to spdx.org (where I can,
this needs to improve and is in discussion with legal how to handle the corner cases)
- split buildrequires in single lines (I'll try to keep
two adjacent buildrequire lines sorted).
That should be what I changed, but just so you don't get afraid :)
Umm....
How are "duplicated license" detected?
And why do we add more to this service rather than removing it? Or, make running it optional (how do I turn this off for a devel project or a specific package for example?)
That would mean that sources may turn into broken or conflicts after checkin into factory. Our goal is to see obvious violations as soon as possible, in best case even before the packager is commiting. That makes the checks transparent, is reducing the amount of needed reviews and the packager does not need to wait just to see the result of checks.
It makes reviewing local changes impossible for packages which generate their spec files automatically from input files.
Well, our policy is to have a unique layout and we even are required to do so legal wise to some degree. So if you generate spec files, best is also to run the formater directly so you can see the differences.
Thanks, Richard. -- Adrian Schroeter SUSE Linux Products GmbH email: adrian@suse.de
-- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org